From: Li Zefan <lizefan@huawei.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Tejun Heo <tj@kernel.org>, Glauber Costa <glommer@parallels.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Michal Hocko <mhocko@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>,
LKML <linux-kernel@vger.kernel.org>,
Cgroups <cgroups@vger.kernel.org>,
linux-mm@kvack.org
Subject: [PATCH 5/8] memcg: convert to use cgroup->id
Date: Mon, 8 Apr 2013 16:22:11 +0800 [thread overview]
Message-ID: <51627E33.4090107@huawei.com> (raw)
In-Reply-To: <51627DA9.7020507@huawei.com>
This is a preparation to kill css_id.
Signed-off-by: Li Zefan <lizefan@huawei.com>
---
mm/memcontrol.c | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 3561d0b..c4e0173 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -492,6 +492,11 @@ static inline bool mem_cgroup_is_root(struct mem_cgroup *memcg)
return (memcg == root_mem_cgroup);
}
+static inline unsigned short mem_cgroup_id(struct mem_cgroup *memcg)
+{
+ return memcg->css.cgroup->id;
+}
+
/* Writing them here to avoid exposing memcg's inner layout */
#if defined(CONFIG_INET) && defined(CONFIG_MEMCG_KMEM)
@@ -4234,7 +4239,7 @@ mem_cgroup_uncharge_swapcache(struct page *page, swp_entry_t ent, bool swapout)
* css_get() was called in uncharge().
*/
if (do_swap_account && swapout && memcg)
- swap_cgroup_record(ent, css_id(&memcg->css));
+ swap_cgroup_record(ent, mem_cgroup_id(memcg));
}
#endif
@@ -4286,8 +4291,8 @@ static int mem_cgroup_move_swap_account(swp_entry_t entry,
{
unsigned short old_id, new_id;
- old_id = css_id(&from->css);
- new_id = css_id(&to->css);
+ old_id = mem_cgroup_id(from);
+ new_id = mem_cgroup_id(to);
if (swap_cgroup_cmpxchg(entry, old_id, new_id) == old_id) {
mem_cgroup_swap_statistics(from, false);
@@ -6428,7 +6433,7 @@ static enum mc_target_type get_mctgt_type(struct vm_area_struct *vma,
}
/* There is a swap entry and a page doesn't exist or isn't charged */
if (ent.val && !ret &&
- css_id(&mc.from->css) == lookup_swap_cgroup_id(ent)) {
+ mem_cgroup_id(mc.from) == lookup_swap_cgroup_id(ent)) {
ret = MC_TARGET_SWAP;
if (target)
target->ent = ent;
--
1.8.0.2
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-04-08 8:22 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-08 8:19 [PATCH 0/8] memcg, cgroup: kill css_id Li Zefan
2013-04-08 8:20 ` [PATCH 1/8] cgroup: implement cgroup_is_ancestor() Li Zefan
2013-04-08 14:47 ` Michal Hocko
2013-04-08 15:57 ` Tejun Heo
2013-04-08 16:33 ` Michal Hocko
2013-04-08 18:03 ` Michal Hocko
2013-04-08 21:36 ` Tejun Heo
2013-04-09 6:42 ` Michal Hocko
2013-04-08 15:39 ` Tejun Heo
2013-04-09 3:21 ` Kamezawa Hiroyuki
2013-04-09 3:29 ` Li Zefan
2013-04-08 8:20 ` [PATCH 2/8] cgroup: implement cgroup_from_id() Li Zefan
2013-04-08 15:43 ` Tejun Heo
2013-04-09 3:12 ` Li Zefan
2013-04-08 15:48 ` Tejun Heo
2013-04-09 3:56 ` Kamezawa Hiroyuki
2013-04-09 4:08 ` Kamezawa Hiroyuki
2013-04-08 8:21 ` [PATCH 3/8] memcg: convert to use cgroup_is_ancestor() Li Zefan
2013-04-09 3:58 ` Kamezawa Hiroyuki
2013-04-09 6:49 ` Michal Hocko
2013-04-08 8:21 ` [PATCH 4/8] memcg: convert to use cgroup_from_id() Li Zefan
2013-04-08 14:53 ` Michal Hocko
2013-04-09 3:00 ` Li Zefan
2013-04-09 3:59 ` Kamezawa Hiroyuki
2013-04-08 8:22 ` Li Zefan [this message]
2013-04-08 14:57 ` [PATCH 5/8] memcg: convert to use cgroup->id Michal Hocko
2013-04-09 3:02 ` Li Zefan
2013-04-09 6:49 ` Michal Hocko
2013-04-09 4:02 ` Kamezawa Hiroyuki
2013-04-08 8:22 ` [PATCH 6/8] memcg: fail to create cgroup if the cgroup id is too big Li Zefan
2013-04-08 15:01 ` Michal Hocko
2013-04-08 8:23 ` [PATCH 7/8] memcg: don't use css_id any more Li Zefan
2013-04-08 15:01 ` Michal Hocko
2013-04-09 4:11 ` Kamezawa Hiroyuki
2013-04-08 8:23 ` [PATCH 8/8] cgroup: kill css_id Li Zefan
2013-04-08 15:51 ` Tejun Heo
2013-04-08 14:37 ` [PATCH 0/8] memcg, " Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51627E33.4090107@huawei.com \
--to=lizefan@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=glommer@parallels.com \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox