From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 096CEC433B4 for ; Wed, 19 May 2021 15:48:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A26CC6112F for ; Wed, 19 May 2021 15:48:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A26CC6112F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1936C6B0036; Wed, 19 May 2021 11:48:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1434B6B006E; Wed, 19 May 2021 11:48:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F25C36B0070; Wed, 19 May 2021 11:48:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0008.hostedemail.com [216.40.44.8]) by kanga.kvack.org (Postfix) with ESMTP id C1E856B0036 for ; Wed, 19 May 2021 11:48:16 -0400 (EDT) Received: from smtpin37.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 4DB96180AD82F for ; Wed, 19 May 2021 15:48:16 +0000 (UTC) X-FDA: 78158412192.37.5FF9D9B Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf09.hostedemail.com (Postfix) with ESMTP id C3C536000252 for ; Wed, 19 May 2021 15:48:14 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 9B7F5AD2D; Wed, 19 May 2021 15:48:14 +0000 (UTC) Subject: Re: [PATCH] mm, page_alloc: really disable DEBUG_PAGEALLOC with hibernation To: David Hildenbrand , Krzysztof Kozlowski , Andrew Morton , Akinobu Mita , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Michal Hocko , "Rafael J . Wysocki" , Andrea Righi , Guilherme Piccoli References: <20210519152804.27063-1-krzysztof.kozlowski@canonical.com> From: Vlastimil Babka Message-ID: <515ca9c5-ba60-5b90-0941-2b3dfe1d61f3@suse.cz> Date: Wed, 19 May 2021 17:48:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Authentication-Results: imf09.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf09.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.15 as permitted sender) smtp.mailfrom=vbabka@suse.cz X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: C3C536000252 X-Stat-Signature: m4tg3rtbpmafbar54j9udfi9pkpqgy5t X-HE-Tag: 1621439294-323687 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/19/21 5:30 PM, David Hildenbrand wrote: > On 19.05.21 17:28, Krzysztof Kozlowski wrote: >> The documentation of DEBUG_PAGEALLOC states that it cannot be used wit= h >> hibernation, however the Kconfig entry would allow it if >> ARCH_SUPPORTS_DEBUG_PAGEALLOC && !PPC && !SPARC. >> >> Fixes: ee3b4290aec0 ("generic debug pagealloc: build fix") >> Signed-off-by: Krzysztof Kozlowski >> --- >> =C2=A0 mm/Kconfig.debug | 2 +- >> =C2=A0 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/mm/Kconfig.debug b/mm/Kconfig.debug >> index 1e73717802f8..0ace5b2a9d04 100644 >> --- a/mm/Kconfig.debug >> +++ b/mm/Kconfig.debug >> @@ -11,7 +11,7 @@ config PAGE_EXTENSION >> =C2=A0 config DEBUG_PAGEALLOC >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 bool "Debug page memory allocations" >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 depends on DEBUG_KERNEL >> -=C2=A0=C2=A0=C2=A0 depends on !HIBERNATION || ARCH_SUPPORTS_DEBUG_PAG= EALLOC && !PPC && !SPARC >> +=C2=A0=C2=A0=C2=A0 depends on !HIBERNATION && ARCH_SUPPORTS_DEBUG_PAG= EALLOC && !PPC && !SPARC >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 select PAGE_POISONING if !ARCH_SUPPORTS= _DEBUG_PAGEALLOC >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 help >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Unmap pages from the kernel= linear mapping after free_pages(). >> >=20 > I remember this should be working now, as we temporarily map the pages = in the > direct map when hibernating? Yeah, and if the problem was the page poisoning based implementation/fall= back, that was also fixed. The current dependencies come from the unification by ee3b4290aec03 The question is if PPC and SPARC still really need to disable hibernation= .