From: Glauber Costa <glommer@parallels.com>
To: Tejun Heo <tj@kernel.org>
Cc: Michal Hocko <mhocko@suse.cz>, Li Zefan <lizefan@huawei.com>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>,
Cgroups <cgroups@vger.kernel.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [RFC][PATCH 5/7] cgroup: make sure parent won't be destroyed before its children
Date: Fri, 5 Apr 2013 12:10:02 +0400 [thread overview]
Message-ID: <515E86DA.1090907@parallels.com> (raw)
In-Reply-To: <20130404152213.GL9425@htj.dyndns.org>
On 04/04/2013 07:22 PM, Tejun Heo wrote:
> On Thu, Apr 04, 2013 at 05:20:28PM +0200, Michal Hocko wrote:
>>> But what harm does an additional reference do?
>>
>> No harm at all. I just wanted to be sure that this is not yet another
>> "for memcg" hack. So if this is useful for other controllers then I have
>> no objections of course.
>
> I think it makes sense in general, so let's do it in cgroup core. I
> suppose it'd be easier for this to be routed together with other memcg
> changes?
>
> Thanks.
>
You guys seems already settled, but FWIW I agree with Tejun here. It
makes sense from a design point of view for a cgroup to pin its parent.
cgroup core it is.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-04-05 8:09 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 9:11 [RFC][PATCH 0/7] memcg: make memcg's life cycle the same as cgroup Li Zefan
2013-04-03 9:11 ` [RFC][PATCH 1/7] memcg: use css_get in sock_update_memcg() Li Zefan
2013-04-03 12:58 ` Glauber Costa
2013-04-03 15:29 ` Michal Hocko
2013-04-05 8:08 ` Glauber Costa
2013-04-05 13:38 ` Michal Hocko
2013-04-05 13:42 ` Glauber Costa
2013-04-05 5:01 ` Kamezawa Hiroyuki
2013-04-05 13:39 ` Michal Hocko
2013-04-03 9:12 ` [RFC][PATCH 2/7] memcg: don't use mem_cgroup_get() when creating a kmemcg cache Li Zefan
2013-04-03 13:05 ` Glauber Costa
2013-04-03 15:31 ` Michal Hocko
2013-04-05 10:28 ` Glauber Costa
2013-04-05 13:45 ` Michal Hocko
2013-04-07 3:32 ` Li Zefan
2013-04-05 5:51 ` Kamezawa Hiroyuki
2013-04-05 13:46 ` Michal Hocko
2013-04-03 9:12 ` [RFC][PATCH 3/7] memcg: use css_get/put when charging/uncharging kmem Li Zefan
2013-04-04 9:43 ` Michal Hocko
2013-04-05 10:19 ` Glauber Costa
2013-04-05 13:48 ` Michal Hocko
2013-04-05 10:19 ` Glauber Costa
2013-04-03 9:12 ` [RFC][PATCH 4/7] memcg: use css_get/put for swap memcg Li Zefan
2013-04-04 11:25 ` Michal Hocko
2013-04-05 5:56 ` Kamezawa Hiroyuki
2013-04-03 9:13 ` [RFC][PATCH 5/7] cgroup: make sure parent won't be destroyed before its children Li Zefan
2013-04-04 11:37 ` Michal Hocko
2013-04-04 13:53 ` Tejun Heo
2013-04-04 15:20 ` Michal Hocko
2013-04-04 15:22 ` Tejun Heo
2013-04-04 15:30 ` Michal Hocko
2013-04-05 8:10 ` Glauber Costa [this message]
2013-04-04 15:31 ` Michal Hocko
2013-04-05 5:58 ` Kamezawa Hiroyuki
2013-04-03 9:13 ` [RFC][PATCH 6/7] memcg: don't need to get a reference to the parent Li Zefan
2013-04-04 15:34 ` Michal Hocko
2013-04-05 9:22 ` Kamezawa Hiroyuki
2013-04-03 9:14 ` [RFC][PATCH 7/7] memcg: kill memcg refcnt Li Zefan
2013-04-04 15:35 ` Michal Hocko
2013-04-05 9:24 ` Kamezawa Hiroyuki
2013-04-03 9:19 ` [RFC][PATCH 0/7] memcg: make memcg's life cycle the same as cgroup Glauber Costa
2013-04-03 21:43 ` Tejun Heo
2013-04-04 12:00 ` Michal Hocko
2013-04-07 6:00 ` Li Zefan
2013-04-07 20:21 ` Michal Hocko
2013-04-07 8:44 ` Li Zefan
2013-04-07 19:51 ` Michal Hocko
2013-04-08 7:18 ` Glauber Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515E86DA.1090907@parallels.com \
--to=glommer@parallels.com \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizefan@huawei.com \
--cc=mhocko@suse.cz \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox