From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BC65C77B7A for ; Wed, 31 May 2023 07:45:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 199FF280003; Wed, 31 May 2023 03:45:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 14B63280001; Wed, 31 May 2023 03:45:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 038DA280003; Wed, 31 May 2023 03:45:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E916F280001 for ; Wed, 31 May 2023 03:45:11 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id BF07740275 for ; Wed, 31 May 2023 07:45:11 +0000 (UTC) X-FDA: 80849764422.19.696D7E1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf03.hostedemail.com (Postfix) with ESMTP id A0CDB2000F for ; Wed, 31 May 2023 07:45:09 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=W+ZhyBKj; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685519109; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XOB0vfWNd/3N8aaFlpLooYega2vQlYMAF6QRKGMinKw=; b=CTNlvuXvwF71mHi9uYXlCJ1meQPp470Xj9FAnJem/VWRivN6gm7oyn6raIE9O3uysbvdKZ IeLARvUzm7niUAwRzFUy52q1l6G4vZinIHJ5noDCejgeEozYjtnCEogRRQD5SvmzFbEeC3 ewD6+s2ebnwoMuUVa7Hphyks04evzDI= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=W+ZhyBKj; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685519109; a=rsa-sha256; cv=none; b=2qFSmttuTS4dsGT/VsyNGpwrQxpcCrCgGQu6NA0dGlXnsFAImYKiCI7eKbl7fNs4Sv68K/ UY9ZoRM4kDZYpy50ZSNHT8NYudp50h54qmFzlHyeHQZPiHwHVUR8qWzVG5HatGUY/ORzVZ hR7NsvT9ZYgrJGdlPuew1pQ5s6mC/p8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685519109; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XOB0vfWNd/3N8aaFlpLooYega2vQlYMAF6QRKGMinKw=; b=W+ZhyBKjcl8hFFpaoykieQ5PnPfsyVAQZtEvKnx6yHSMFUdZLXQ5zbickQyV2Wq6XWzz1f ghqIkFfuIPWFbPLByT8X1NlQLjckw1bWBVUzWJAonZ8cy6UhoIoW1TjYIJevvUPd4LnaBP 7gCMip8aeZ8DhKJckusJ4uVsf01l5nY= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-664-LKxOZerfNv6_Zlf2awAn0g-1; Wed, 31 May 2023 03:45:07 -0400 X-MC-Unique: LKxOZerfNv6_Zlf2awAn0g-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3079c6648e3so3310101f8f.2 for ; Wed, 31 May 2023 00:45:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685519106; x=1688111106; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XOB0vfWNd/3N8aaFlpLooYega2vQlYMAF6QRKGMinKw=; b=IatIU8oBx6CC0eznkQq5EyvKXfXSbxRJUd24WR1xXpU9EAnInKbsC5RWiYLom36YQB mNvrptUdAIjPKGHbQC9LjjMQTKLgvwlpfotDeHHKZfzPlZ78jNY97AePRDu/OzIN83Od lkxL3SyyFiBtsqdy2T8aLKXh78CEp0zfAtQ3BKRjK+d8bWr1TVBW4ftDKyrDrH9IoVDK MH5Jj0adfgInPLQwn8wvoyWBSxyVUfoLyc6ctWsR+AWoSKKVt0vuHshC5V2710cG/DhZ tmngwa/7/tdIK7/SJZ5n0+YMOI/jRTMRKaEPRXsguRCwWMJ88ma1xPf9Yj1CFt0+9Dgf 4KQA== X-Gm-Message-State: AC+VfDxWvcxyUr6VN1ZKPvv5LXGxAtyQu4Us52GbZHulKWpR48seLJH2 5Va5U6FFIiwBkGQDmegQkwztFQQAFHdjMiA/kOvNDFky2UdiRFcjAwyiCUGQtT4ISYxL6FE1qXA zchbjAcGb/gQ= X-Received: by 2002:a5d:4cd2:0:b0:307:a52c:26b4 with SMTP id c18-20020a5d4cd2000000b00307a52c26b4mr3221203wrt.66.1685519106538; Wed, 31 May 2023 00:45:06 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7vHaOAB4dSjF4uctl0lqe2UkA9cnoir5JVWgD45qApy0tRQfcKjzysYCBklfFSSYDvAZh1YQ== X-Received: by 2002:a5d:4cd2:0:b0:307:a52c:26b4 with SMTP id c18-20020a5d4cd2000000b00307a52c26b4mr3221182wrt.66.1685519106183; Wed, 31 May 2023 00:45:06 -0700 (PDT) Received: from ?IPV6:2003:cb:c749:cb00:fc9f:d303:d4cc:9f26? (p200300cbc749cb00fc9fd303d4cc9f26.dip0.t-ipconnect.de. [2003:cb:c749:cb00:fc9f:d303:d4cc:9f26]) by smtp.gmail.com with ESMTPSA id o1-20020a5d4741000000b002f9e04459desm5686117wrs.109.2023.05.31.00.45.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 May 2023 00:45:05 -0700 (PDT) Message-ID: <5151bb67-550b-87f1-f656-20683052b0aa@redhat.com> Date: Wed, 31 May 2023 09:45:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH -V3 2/5] swap, __read_swap_cache_async(): enlarge get/put_swap_device protection range To: Huang Ying , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hugh Dickins , Johannes Weiner , Matthew Wilcox , Michal Hocko , Minchan Kim , Tim Chen , Yang Shi , Yu Zhao , Chris Li , Yosry Ahmed References: <20230529061355.125791-1-ying.huang@intel.com> <20230529061355.125791-3-ying.huang@intel.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230529061355.125791-3-ying.huang@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: u1qpuastahinhiwfbemabs65efnirarz X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A0CDB2000F X-HE-Tag: 1685519109-805079 X-HE-Meta: U2FsdGVkX19sa/A73TJekN2naTbfGpmmJjaaNvHUSYAZ8SdufuD85KQ2yCTGWhFDiBsXXOtzDSOum/9p7XKKvsK2MQ5HpeU7NDUTwn7Utj6O+t2cdvcRsWUtWR08T+0crCv6tuQs1Ceen+L5d953Q4cXAfXX2NpVaI6fjW75uYsPvRQNQgzAzfw5E7+emU2CwC74a9hPOKxhO+tW0d+iN0CAWlh3AvwVPD4VzVIY0wmCrWhtUjv0znYvHSLwLQOwx4lQ3f3AYlu1SH/N1QWozxXcs1EPHzaOoMXwVX8W5aQHdv1/ZM7o/KAmGgYHIpCYZHGtGObdkwJYrNN9Mq/RHlnA9SaW47q9p6gpzcgaJQfpCN554a9LX3T0s2gCDgkFaLK8R/69D/wfOoPDFq6aTtCAdIy47KYGl1pc3HmKbGgI1dJta+2Hb3lg6WcEiAMH47/w/M2iaetIqRW4l92TB9m0Lwy78GltqZne7rc4mOi+SYAVDLjO75b6TThlNnNRf1YbZ2qhYN3r1H+0udUfJfsI7KZXgbfigrnpu7NpWRxqMelPz1AzoiuWdSTaHS8hE8DrqGjjTrgTi7mjFSfojag81lzbbYmZxzSR4GJbuA0hEqrua2mSxP+U1p/0t4KvUqZXU3RmWLSA6vpHm7e7MmS8zSlHV/nkvFtbmmB2WuYlSZCjnaQ7kMnhyDH2Gbgo+H39pTp/DnxdRY+ka3JVfzsU3AciDGwQxtOKxKw+CYzVhqD/AToNrDaoIhzsBHh40xbhLP72nLCbJFIH6sDGJ+etIsejYwD6ovoA+grDWcH6T8IXRp6pawQU4xfG9+YWx56qnj/ALRJOkA6F8lBls49XyzPfRY//XA0UYOUwYXzOERj+iRUGwdglVFRqwjSLDGF3z0icPTvONGeEVrhFA+V7YJFpWn4RVXB8ccr2Gp2M1Q0Xud6lM68c9btV2d/fB5+HL/3JD/FbBuChpjJ 8XLB8w/Q 0TCVDRUjmGllIyDhDUvxLzdunM7WES2wpgxHBYL2e4FyQyiMssabhf7wZdJMSblER6f49agYBbPbiw0STLp31BMMujgBtCSL8zPBHngDvA/d16LNUoeq577hdaUWgZkke4P6JJ1q0N53m1FtthsQz/E0iOPYRE79vLa1hSdtjfI7BeE4Oju+bA8j+AEOXnA00SXXZR39fxo1yYANPptSeeTlFUax95NrWy3CfmHbmU9RkgUAaQGmXEZ3zE0O6uSXyv8Jjb8jFlj6pnM/Ayy6jB6KFNNp27upBvWWdPTbOPqtiEX3PXgmpbGLM6kVDs/yAHjixg6oT46al110im0lNiTmueQMYam3vl6Osv4LOfPQt2yX3k0+uKDqJFcqS3nnFSE6aw/9H3LXgqj3FPC8rc5WRvfnWl55A8K/TQ6JWwrW5KQuOJhsgQBCENwvtQGGkgjHrqu1k6V2BkbxmJ6ryWuz48En2fVjDrYtEcOhlCPAm3B65NJu3gogZ1EvYiwQphEi8fUcL/1f00MjnwKjolLeb5SZA61205D8ESd2uGN07yXcGsP1HbGOJpNJz4K11qZCvhx9Jiwug2nzWQJ1/bqyRzMV2QXf3ZMJluuO67oRcy+7Jhh7o1vkdaE//dNacnxIqoYU/hbSlzxBjAKuO7brrweyUDBM9ha9xBxZJE3hfftvyJ/XeFHT+hevKkM3Tmyozcrf71H02zl5eld0um592P8LpMUbNXDBEtLCcD0PxaqeaWB+36O3kzxRW1eCwr+/O X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 29.05.23 08:13, Huang Ying wrote: > This makes the function a little easier to be understood because we > don't need to consider swapoff. And this makes it possible to remove > get/put_swap_device() calling in some functions called by > __read_swap_cache_async(). > > Signed-off-by: "Huang, Ying" > Cc: David Hildenbrand > Cc: Hugh Dickins > Cc: Johannes Weiner > Cc: Matthew Wilcox > Cc: Michal Hocko > Cc: Minchan Kim > Cc: Tim Chen > Cc: Yang Shi > Cc: Yu Zhao > Cc: Chris Li > Cc: Yosry Ahmed > --- Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb