From: "David Hildenbrand (Red Hat)" <david@kernel.org>
To: Kevin Brodsky <kevin.brodsky@arm.com>,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Dev Jain <dev.jain@arm.com>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Mark Brown <broonie@kernel.org>,
Ryan Roberts <ryan.roberts@arm.com>,
Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH v3 9/9] selftests/mm: report SKIP in pfnmap if a check fails
Date: Thu, 22 Jan 2026 23:23:11 +0100 [thread overview]
Message-ID: <514a3e29-6f5e-4d7c-9e67-cb001573d41c@kernel.org> (raw)
In-Reply-To: <20260122170224.4056513-10-kevin.brodsky@arm.com>
On 1/22/26 18:02, Kevin Brodsky wrote:
> pfnmap currently checks the target file in FIXTURE_SETUP(pfnmap),
> meaning once for every test, and skips the test if any check fails.
>
> The target file is the same for every test so this is a little
> overkill. More importantly, this approach means that the whole suite
> will report PASS even if all the tests are skipped because kernel
> configuration (e.g. CONFIG_STRICT_DEVMEM=y) prevented /dev/mem from
> being mapped, for instance.
>
> Let's ensure that KSFT_SKIP is returned as exit code if any check
> fails by performing the checks in pfnmap_init(), run once. That
> function also takes care of finding the offset of the pages to be
> mapped and saves it in a global. The file is now opened only once
> and the fd saved in a global, but it is still mapped/unmapped for
> every test, as some of them modify the mapping.
>
> Signed-off-by: Kevin Brodsky <kevin.brodsky@arm.com>
> ---
Acked-by: David Hildenbrand (Red Hat) <david@kernel.org>
--
Cheers
David
next prev parent reply other threads:[~2026-01-22 22:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-22 17:02 [PATCH v3 0/9] Various mm kselftests improvements/fixes Kevin Brodsky
2026-01-22 17:02 ` [PATCH v3 1/9] selftests/mm: default KDIR to build directory Kevin Brodsky
2026-01-22 17:02 ` [PATCH v3 2/9] selftests/mm: remove flaky header check Kevin Brodsky
2026-01-22 17:02 ` [PATCH v3 3/9] selftests/mm: pass down full CC and CFLAGS to check_config.sh Kevin Brodsky
2026-01-22 17:02 ` [PATCH v3 4/9] selftests/mm: fix usage of FORCE_READ() in cow tests Kevin Brodsky
2026-01-22 17:02 ` [PATCH v3 5/9] selftests/mm: check that FORCE_READ() succeeded Kevin Brodsky
2026-01-22 17:36 ` Usama Anjum
2026-01-23 8:20 ` Kevin Brodsky
2026-01-22 22:18 ` David Hildenbrand (Red Hat)
2026-01-23 8:17 ` Kevin Brodsky
2026-01-22 17:02 ` [PATCH v3 6/9] selftests/mm: introduce helper to read every page Kevin Brodsky
2026-01-22 17:39 ` Muhammad Usama Anjum
2026-01-22 22:20 ` David Hildenbrand (Red Hat)
2026-01-23 8:25 ` Kevin Brodsky
2026-01-22 17:02 ` [PATCH v3 7/9] selftests/mm: fix faulting-in code in pagemap_ioctl test Kevin Brodsky
2026-01-22 17:43 ` Muhammad Usama Anjum
2026-01-22 17:02 ` [PATCH v3 8/9] selftests/mm: fix exit code in pagemap_ioctl Kevin Brodsky
2026-01-22 17:02 ` [PATCH v3 9/9] selftests/mm: report SKIP in pfnmap if a check fails Kevin Brodsky
2026-01-22 22:23 ` David Hildenbrand (Red Hat) [this message]
2026-01-22 18:25 ` [PATCH v3 0/9] Various mm kselftests improvements/fixes Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=514a3e29-6f5e-4d7c-9e67-cb001573d41c@kernel.org \
--to=david@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=broonie@kernel.org \
--cc=dev.jain@arm.com \
--cc=kevin.brodsky@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=ryan.roberts@arm.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox