From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx188.postini.com [74.125.245.188]) by kanga.kvack.org (Postfix) with SMTP id 4B6596B0083 for ; Fri, 22 Mar 2013 06:00:06 -0400 (EDT) Message-ID: <514C2C36.3060709@cn.fujitsu.com> Date: Fri, 22 Mar 2013 18:02:30 +0800 From: Tang Chen MIME-Version: 1.0 Subject: Re: [PATCH] mm/hotplug: only free wait_table if it's allocated by vmalloc References: <514C2A43.3020008@huawei.com> In-Reply-To: <514C2A43.3020008@huawei.com> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=UTF-8; format=flowed Sender: owner-linux-mm@kvack.org List-ID: To: Jianguo Wu Cc: Andrew Morton , Wen Congyang , Liujiang , qiuxishi , linux-mm@kvack.org, Tang Chen On 03/22/2013 05:54 PM, Jianguo Wu wrote: > zone->wait_table may be allocated from bootmem, it can not be freed. > > Cc: Andrew Morton > Cc: Wen Congyang > Cc: Tang Chen > Cc: Jiang Liu > Cc: linux-mm@kvack.org > Signed-off-by: Jianguo Wu > --- > mm/memory_hotplug.c | 6 +++++- > 1 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 07b6263..91ed7cd 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1779,7 +1779,11 @@ void try_offline_node(int nid) > for (i = 0; i< MAX_NR_ZONES; i++) { > struct zone *zone = pgdat->node_zones + i; > > - if (zone->wait_table) > + /* > + * wait_table may be allocated from boot memory, > + * here only free if it's allocated by vmalloc. > + */ > + if (is_vmalloc_addr(zone->wait_table)) > vfree(zone->wait_table); Reviewed-by: Tang Chen FYI, I'm trying add a flag member into memblock to mark memory whose life cycle is the same as a node. I think maybe this flag could be used to free this kind of memory from bootmem. Thanks. :) > } > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org