From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx166.postini.com [74.125.245.166]) by kanga.kvack.org (Postfix) with SMTP id 6CB366B0002 for ; Thu, 21 Mar 2013 13:58:46 -0400 (EDT) Message-ID: <514B4A9F.5090004@sr71.net> Date: Thu, 21 Mar 2013 10:59:59 -0700 From: Dave Hansen MIME-Version: 1.0 Subject: Re: [PATCHv2, RFC 12/30] thp, mm: add event counters for huge page alloc on write to a file References: <1363283435-7666-1-git-send-email-kirill.shutemov@linux.intel.com> <1363283435-7666-13-git-send-email-kirill.shutemov@linux.intel.com> In-Reply-To: <1363283435-7666-13-git-send-email-kirill.shutemov@linux.intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: "Kirill A. Shutemov" Cc: Andrea Arcangeli , Andrew Morton , Al Viro , Hugh Dickins , Wu Fengguang , Jan Kara , Mel Gorman , linux-mm@kvack.org, Andi Kleen , Matthew Wilcox , "Kirill A. Shutemov" , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org On 03/14/2013 10:50 AM, Kirill A. Shutemov wrote: > --- a/include/linux/vm_event_item.h > +++ b/include/linux/vm_event_item.h > @@ -71,6 +71,8 @@ enum vm_event_item { PGPGIN, PGPGOUT, PSWPIN, PSWPOUT, > THP_FAULT_FALLBACK, > THP_COLLAPSE_ALLOC, > THP_COLLAPSE_ALLOC_FAILED, > + THP_WRITE_ALLOC, > + THP_WRITE_FAILED, > THP_SPLIT, > THP_ZERO_PAGE_ALLOC, > THP_ZERO_PAGE_ALLOC_FAILED, I think these names are a bit terse. It's certainly not _writes_ that are failing and "THP_WRITE_FAILED" makes it sound that way. Also, why do we need to differentiate these from the existing anon-hugepage vm stats? The alloc_pages() call seems to be doing the exact same thing in the end. Is one more likely to succeed than the other? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org