From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0AEAC87FD6 for ; Thu, 29 Aug 2024 19:46:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 573996B0083; Thu, 29 Aug 2024 15:46:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 523826B009C; Thu, 29 Aug 2024 15:46:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3EA586B009D; Thu, 29 Aug 2024 15:46:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1E38C6B0083 for ; Thu, 29 Aug 2024 15:46:38 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 97FB5A848A for ; Thu, 29 Aug 2024 19:46:37 +0000 (UTC) X-FDA: 82506315234.08.ACB5011 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf01.hostedemail.com (Postfix) with ESMTP id D5BAC40008 for ; Thu, 29 Aug 2024 19:46:34 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JKlOH1Xd; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf01.hostedemail.com: domain of broonie@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=broonie@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724960722; a=rsa-sha256; cv=none; b=2zzqtNcr18BVbI9oacaAqoLAj15WhBXM0ehiIiYA0/7GXomdmZhQ1KKmWMTbCLVB1D3H0h K7wUlAU+fZ+SaYTepnXZLJ9YvONKT2AdqUiyqHGPakTGpGoJfgygIwKxZJaDeAptfCUR0Q UPLzxsiv1bNzDDovUTlFVHhHgxPHY1I= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JKlOH1Xd; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf01.hostedemail.com: domain of broonie@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=broonie@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724960722; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5oK8u3SROaEpcvuxcyKqPmLI/0oweUbfGGBSGhLz+Zk=; b=wsJv7RMkR9zTa4g8t0n3gsbY0MieE/k069gnqb26eNx33hcTKE+zSwhOFQYXdxEEZZdWES tNBbvPfk+vATDk036zp8+MemLmEKvljcDCkglkGNdaZ8FjUscHZcNzWRDrt+3Nz+EOXd3y 2JzQgP34gUn9XNqj+ALN2KcFZ+SjMvI= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 18A1FA432FE; Thu, 29 Aug 2024 19:46:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C416CC4CEC1; Thu, 29 Aug 2024 19:46:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724960793; bh=10dh7jnjT81MN0q3B+Lrr3xtfTLmhCikedT0exQ8d5w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JKlOH1Xds/tunf71DHY+DPWMAGwrEodyappwyScajNqgUnINNAsrntwdTJmvJlHi0 ViabpkAKRgz15UNHFzVIpiX18QGXaP4px2pFWPXj1sDnqVJByt0g8I8o2+JFFD9Gmj VNgZydgFUvrBH2Wrl+vrx90ZN8zkOj8cxZ/9SULiuLOUvBvwSi8q3wRhMAzun8SLQC /goTiYOL7uTrRKRzz1pQQ5Wc+xVFriQ4jC3+lojZPyzKFKXHGODdk1QwXu3CJ9sOCx /LiRVLUTAVUcbkAmk9THtNcL3tnWajzNYwwaSmPg0GM6RTQNYvUVHGaEX2xh7Yr0m9 GMHrteM4u8VFQ== Date: Thu, 29 Aug 2024 20:46:28 +0100 From: Mark Brown To: Lorenzo Stoakes Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , "Liam R . Howlett" , Vlastimil Babka , Ryan Roberts , Aishwarya TCV , dev.jain@arm.com Subject: Re: [PATCH v2 06/10] mm: avoid using vma_merge() for new VMAs Message-ID: <51452bab-65ef-4924-8ca8-61536d2bc168@sirena.org.uk> References: <57f55a1473586a88211e04b44c6b128332d4272c.1724441678.git.lorenzo.stoakes@oracle.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="f5NSZ20PrPX2cu+u" Content-Disposition: inline In-Reply-To: <57f55a1473586a88211e04b44c6b128332d4272c.1724441678.git.lorenzo.stoakes@oracle.com> X-Cookie: YOU PICKED KARL MALDEN'S NOSE!! X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: D5BAC40008 X-Stat-Signature: ncimr3rbjeqtnpmsqjex9yymhjacc6ai X-Rspam-User: X-HE-Tag: 1724960794-499384 X-HE-Meta: U2FsdGVkX197Ji8uq1592ALx+A7YUiGNVh9xKwHVSnL4UhT59T/ygOmzu/8tR+eCcOx8Bknawu4M5ecmQcIAq/jNnLfIusNqPODRQuywkr1P00SCEEfzgwfPj+mGJWnDl4gboITw1TwZoFDJPpp/+QnbhijN201sY+4Ctrpg/SssImSSAXqmuaQ1Q78b7zCNwkmTIVeepG0TnLNuoS4d099WRdMGg9NnvJumRFzsDCkwAR52n5REItDuhnKiYWH/ixiOirrFTtBb7B/kaMCY6qje+uqJl7ks6z7gmfgMmWRiM6+yXxOhQe/205sNpe3yQ/q8hT2ywf7ii8FQwf1DBVInmYuXZv4ylOis3HJB2NdDeQPDBzh+4E4Ls/q911+di9dJEtADkOST80sUMUTFk3XGfI17PudSVYgt6QXPLDGR+xLf7u5K7VaAXiJJW8voL3+iRajJHYYFL5ZKsm5Ykp6I/GGZCMFuXaLu82ifAVroB56iE8V8R2+5C7roLTHCmrNMSF6yvgemIA+1Z/VC8s//a2XTDPhOz/lci6tGSBgSW9fPjHkOq9JQDxYkhAQgiibKSdcUncXiFR3AaRKAQ9Yy1HzUIPSGCBrOztv+1mQkX67iFBg2Bcuvp5XvAAGLUnKX4r4ZDDRL3NZi4//AdQtGRsbTaMii5k577hEvxFJujFVtM3md1HCEYResa6ZRCXAay1GmdAqaIifNJdqn0krc5Ko4R5kA4dtulrnxaIjD5KKbEy8q2WUCUy7XDUV0AZF39V9XHGmhVWlbryqgKB2uLJWuigqC8eS6i8ra7/D6hvn9pR+GzrNhrxjEypebH8Mpksz+Z3wsc4HF1OJFBJbSsewN6Uy/bkNXy07DzFYjOPvSwpWIt0XdOZ3Dyx4gU4b7Khd8f+WLLUPP3FFy2Ovp3lD8ibnvFp9RhGdlK9cn9WrJa8w9qkMUhy+zyrwCvooRt8qVTVXy+FtUwei S31s2xxf i2ut/iH1a0D3t++lMLm/GoZ0SFzUwOjy7X+BYG4keGBxuV8WlcL5pxVNdgtHWS7NSoSlkvLV5KKj4VM1lZiuUnRKLcotxc+gu3GqoH4uqbpzznIVk9AKSTnk43jOPxgnPPHICbqehas51SNaW0o8K8tx1eGbXx8wwRSrQo0XL6SWCyXCEY43BRaLyn/xCgT6TpiqeuNfC9utIPdeFq8ge4EWEYh9b1uj1V5FFR1qNGhURUozm8Bglp23Lx32FBRjGPxjkZFmhKbu13DrKSV67u3i4PCzgYUiH/neKXGFQVttbXuxbBA64LGbP5WsReXZKbCdS7jV4CrvklhftdGOxjQpu/8JAG8k8EeUY8bCzuqR2jWzft4fJRTLizrlN4mfMDNlYhjsrNEK91JGoRXPbyV3BR5l26QaExX/mlkzZcqY7hOJrJaONiDWldA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --f5NSZ20PrPX2cu+u Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Aug 23, 2024 at 09:07:01PM +0100, Lorenzo Stoakes wrote: > Abstract vma_merge_new_vma() to use vma_merge_struct and rename the > resultant function vma_merge_new_range() to be clear what the purpose of > this function is - a new VMA is desired in the specified range, and we wish > to see if it is possible to 'merge' surrounding VMAs into this range rather > than having to allocate a new VMA. This patch, which is in -next today with the fixup Lorenzo posted as commit 8c9d0f8b1e9a42586, seems to be causing problems with the mremap expand merge selftest. The test has been failing for a few days. It unfortunately doesn't log anything about why it's upset: # # ok 15 5MB mremap - Source 1MB-aligned, Dest 1MB-aligned with 40MB Preamble # # not ok 16 mremap expand merge # # ok 18 mremap mremap move within range I identified this commit using a bisect which appears to converge fairly smoothly, I didn't do any other analysis: git bisect start # status: waiting for both good and bad commits # bad: [b18bbfc14a38b5234e09c2adcf713e38063a7e6e] Add linux-next specific files for 20240829 git bisect bad b18bbfc14a38b5234e09c2adcf713e38063a7e6e # status: waiting for good commit(s), bad commit known # good: [559a93afece952cb129a236febe5d1b8f7c79367] Merge branch 'for-linux-next-fixes' of https://gitlab.freedesktop.org/drm/misc/kernel.git git bisect good 559a93afece952cb129a236febe5d1b8f7c79367 # bad: [47b9fb7c1f3efb63f2a5ed614385476856196527] Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/ath/ath.git git bisect bad 47b9fb7c1f3efb63f2a5ed614385476856196527 # bad: [3582529887df7b4d397a05584ceb9d9944b54328] Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git git bisect bad 3582529887df7b4d397a05584ceb9d9944b54328 # bad: [a97442baf3538d884696539023a068269c983182] Merge branch 'at91-next' of git://git.kernel.org/pub/scm/linux/kernel/git/at91/linux.git git bisect bad a97442baf3538d884696539023a068269c983182 # bad: [9287e4adbc6ab8fa04d25eb82e097fed877a4642] mm: optimization on page allocation when CMA enabled git bisect bad 9287e4adbc6ab8fa04d25eb82e097fed877a4642 # good: [becee36d72a57fd245033efdfd94cb54ac24472e] mm: swap: extend swap_shmem_alloc() to support batch SWAP_MAP_SHMEM flag setting git bisect good becee36d72a57fd245033efdfd94cb54ac24472e # good: [8939071cd2fdfd69f48631845613f5d841e0e97e] selftests-test_zswap-add-test-for-hierarchical-zswapwriteback-fix git bisect good 8939071cd2fdfd69f48631845613f5d841e0e97e # bad: [42c5d3ae23db3086624db99c52498d5843d3b88a] mm/damon/core-test: fix damon_test_ops_registration() for DAMON_VADDR unset case git bisect bad 42c5d3ae23db3086624db99c52498d5843d3b88a # good: [6abe8def9543d42a31fa6560410a1ab45b3e1917] mm/vma: drop incorrect comment from vms_gather_munmap_vmas() git bisect good 6abe8def9543d42a31fa6560410a1ab45b3e1917 # bad: [bdf4d125288d2ac24a49f7f52d882261bed6e1e1] mm: vmalloc: refactor vm_area_alloc_pages() function git bisect bad bdf4d125288d2ac24a49f7f52d882261bed6e1e1 # good: [5cc3d95b7d3a1cd7c09772d6b7aaa0371cc37236] mm: abstract vma_expand() to use vma_merge_struct git bisect good 5cc3d95b7d3a1cd7c09772d6b7aaa0371cc37236 # bad: [042a3d61fddaff155b6595d8e47323f1e85aefb3] mm: make vma_prepare() and friends static and internal to vma.c git bisect bad 042a3d61fddaff155b6595d8e47323f1e85aefb3 # bad: [b46446ab789bc2cfc3d18ddcc0e93fa533f6b479] mm: only advance iterator if prev exists git bisect bad b46446ab789bc2cfc3d18ddcc0e93fa533f6b479 # bad: [8c9d0f8b1e9a4258676714557c8d69fbb85578ab] mm: avoid using vma_merge() for new VMAs git bisect bad 8c9d0f8b1e9a4258676714557c8d69fbb85578ab # first bad commit: [8c9d0f8b1e9a4258676714557c8d69fbb85578ab] mm: avoid using vma_merge() for new VMAs --f5NSZ20PrPX2cu+u Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmbQ0BQACgkQJNaLcl1U h9CtGQf/d99BV4Jvx2lWkQIeHLGHZeB1aq79+UwWVBwQF2zvMKaRtFbHHH/BSr1s bQVVRfRQSzp4VzV03AdPCfWbCyU/GP3AxvHHwB3JB7/Dq0kswqkXYeYjKVWm7ny1 OZ7r9snTeLV3JKaPW7y/D2BeXCMq+SYSjbRgVfoNsKaPdlXBu2LWAaj0YsrOqSmd Jcmj2zVy477KyLM979Xnb2G9XISC3eZBs/M2U81S4NnLf+8aaaLKXwlpwDBBIpra 1JZnMPac9dJdgr0eu86WTWKgHczZFw7hnNavzlIy/l7wk5YRr5A9MduGJiiyCvld elTOllORi74CZd6Jwmbpjehhsbnv9g== =Z/Ps -----END PGP SIGNATURE----- --f5NSZ20PrPX2cu+u--