From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0861C433EF for ; Thu, 3 Mar 2022 21:53:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3549E8D0002; Thu, 3 Mar 2022 16:53:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 304408D0001; Thu, 3 Mar 2022 16:53:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A5DB8D0002; Thu, 3 Mar 2022 16:53:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0039.hostedemail.com [216.40.44.39]) by kanga.kvack.org (Postfix) with ESMTP id 06D3C8D0001 for ; Thu, 3 Mar 2022 16:53:18 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id A538E1821CC11 for ; Thu, 3 Mar 2022 21:53:17 +0000 (UTC) X-FDA: 79204426434.26.5628D44 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf27.hostedemail.com (Postfix) with ESMTP id A615F40005 for ; Thu, 3 Mar 2022 21:53:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description; bh=sct51wRdcOdh4/CUtiuhNhf7LaEDw3Kb0tD5nil9ssQ=; b=nQ2RXZ8gjdMPqZZFrcN2/kZvXn n2AmG25tiHr4++jCKRm2sE9EKoOyPaJtTco1260U63kPyifVNs1XrwE+71B+kK3aGTKWmxs/kkIpw TQS5oy3EGHrZ9jsdz6w7xEFPyImfGl9k8+Z55esk3IGjcHMa/H+W+WKJQtQv/ivyg0OaWkrE2Vux2 jMPabgJQA9VqX9qxQnqVN78uExie7OrDxuJj15gK8kOuOct3f7KG9GFaOzAuUeTmccXD8lrN+ohYB HBfNmGfOSExmZcUen/OyRCANVCPvOh/V4DWx5hZcNwOcaw4KDRkljKmgYdopoREE49Phzfp30prli L82857cA==; Received: from [2601:1c0:6280:3f0::aa0b] by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nPtNl-00C1KC-2x; Thu, 03 Mar 2022 21:53:09 +0000 Message-ID: <5130da56-0f22-8212-0ea3-6ddb8a8f5455@infradead.org> Date: Thu, 3 Mar 2022 13:53:03 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH 1/2] mm/memcontrol: return 1 from cgroup.memory __setup() handler Content-Language: en-US To: =?UTF-8?Q?Michal_Koutn=c3=bd?= Cc: linux-mm@kvack.org, Igor Zhbanov , Andrew Morton , Johannes Weiner , Michal Hocko , Vladimir Davydov , cgroups@vger.kernel.org References: <20220222005811.10672-1-rdunlap@infradead.org> <20220302185300.GA19699@blackbody.suse.cz> <9f8d4ddb-81ce-738a-d1f7-346ff9bf8ebd@infradead.org> <20220303101406.GE10867@blackbody.suse.cz> From: Randy Dunlap In-Reply-To: <20220303101406.GE10867@blackbody.suse.cz> Content-Type: text/plain; charset=UTF-8 X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: A615F40005 X-Stat-Signature: eryrpbpontc1uwnk8qbzmkmkc6rqshnc Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=nQ2RXZ8g; spf=none (imf27.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=rdunlap@infradead.org; dmarc=none X-HE-Tag: 1646344396-55941 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Michal, On 3/3/22 02:14, Michal Koutn=C3=BD wrote: > On Wed, Mar 02, 2022 at 04:53:19PM -0800, Randy Dunlap wrote: >> I don't think those strings (even with invalid option values) should b= e >> added to init's environment. >=20 > Isn't mere presence of the handler sufficient to filter those out? [1] What is [1] here? > (Counter-example would be 'foo=3D1 foo=3D2' where 1 is accepted value b= y the > handler, 2 is unrecognized and should be passed to init. Is this a real > use case?) I don't know of any case where "foo=3D2" should be passed to init if there is a setup function for "foo=3D" defined. >> I'm willing to add a pr_warn() or pr_notice() for any unrecognized >> option value, but it should still return 1 IMO. >=20 > Regardless of the handler existence check, I see returning 1 would be > consistent with the majority of other memcg handlers. >=20 > For the uniformity, > Reviewed-by: Michal Koutn=C3=BD >=20 > (Richer reporting or -EINVAL is by my understanding now a different > problem.) --=20 ~Randy