From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18FC0C02181 for ; Fri, 24 Jan 2025 12:31:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9CB80280067; Fri, 24 Jan 2025 07:31:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 97AE8280065; Fri, 24 Jan 2025 07:31:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 869A9280067; Fri, 24 Jan 2025 07:31:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 690EE280065 for ; Fri, 24 Jan 2025 07:31:20 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 0532E1A13FB for ; Fri, 24 Jan 2025 12:30:35 +0000 (UTC) X-FDA: 83042278914.02.B516183 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf25.hostedemail.com (Postfix) with ESMTP id 0E54EA0012 for ; Fri, 24 Jan 2025 12:30:33 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of kevin.brodsky@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=kevin.brodsky@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737721834; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hhCX6G8KWREof1qpzPaODGndFAGTMfSlCA9gSmQehTw=; b=MezsLZ2pSclso5FyitmsNoO49LBewAVIFCxWBs4QlqIRE7FU4nxi1ek7rOYFdfee/s8fE8 tuE/ZF4JRBm9JhipKvu5DlHnjgOTgFKTcchQuURDq3kqXp4uuEVr7DNuPkog5OpZHl1CEK 7jWjqEepwk4JR29dBRgFfsQflKD8qtw= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of kevin.brodsky@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=kevin.brodsky@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737721834; a=rsa-sha256; cv=none; b=vRR2k353dnYT4LCF0ndj0uvFsvyYjFMeob6HbdXlFODwYjUoXFFwEcaSOc+WMh6HZ+zE59 bW5pHxzH8XEWl1Xe2SnHhVvMc6WlgJswxQQd10pdEOBwSR8xdioP3H6j9N0nFLI1+zdQ+j 0mztrJSeENAN9d2AXWiYV/EEDmCG2Kw= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EA101497; Fri, 24 Jan 2025 04:31:00 -0800 (PST) Received: from [10.57.95.170] (unknown [10.57.95.170]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 39D8E3F5A1; Fri, 24 Jan 2025 04:30:30 -0800 (PST) Message-ID: <512914f2-1df7-4c24-ab4b-6a246060d537@arm.com> Date: Fri, 24 Jan 2025 13:30:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] s390/mm: Add missing ctor/dtor on page table upgrade To: Alexander Gordeev Cc: Qi Zheng , Gerald Schaefer , Heiko Carstens , linux-mm@kvack.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Morton References: <20250123160349.200154-1-agordeev@linux.ibm.com> Content-Language: en-GB From: Kevin Brodsky In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 0E54EA0012 X-Stat-Signature: atzt1thsrup9yfuy4incq4koyarb1s3r X-HE-Tag: 1737721833-766774 X-HE-Meta: U2FsdGVkX1/AG0+em3iF0N7cvmmzvzVaYaU6JgNXeRilkAZ9NBdNEF2Agy6lO4owYRPvCiYjk+aAFlmF4cBSe+F45n/0cioYNFN0petkmmncipYoml6JlvSGkVV8z9/6Mx/RHHO4szrBHkjlouGg74SHzt1lf7nymuAZXvN7za3W5iSLotpua9yTxneduFf3Zr/5gXBYrT1X0XjzT+Eiu3C/0amhp22Ixgcm5f9/q3oPegzT+J3CzjT/tjnbz6KuZYGieIDGTMDQorm8BVsoAwetCXhhxBVVwWyoyZgZ6j8KEG2rp19zn0cC9wHhaoasKPtdEY4rczuKEXFDzskQ1jBVwAYm3JTnBqcgyXUT5v8cEcqZvWcJoXMcJGNOqz/ETDtq9mTZZdTiteXkiwtSR78+MaYIM/75QlmrN8XNRQNwcPTwTIXeQ7O3b3ctyUwcCI7RSaxUlcCkEw+fs1m2By7CZ2SToW6+D/Eg0Fpww7uMaQGMCB4ZvF1babNq8SKP9+OuuPB1TiCgPQ5VJUuq+MPJBgJwKp++8GYfillkMnG7kfxGO/HDb7cuMC9EbSfh9wa8CFy0sqjA3ceyQgHrnhyaD/cZOFrItbJS5cbrKL2O9GftPYNFmnESTWjK0m3etUx3I6stQ/08uelqZTJnvllPTdw45o6iR+fx21j/5+mVpUxug8pS7hWKiUHya/1Fse9q3p3w6E+rav/rufmAYsoBpOC38XcD2On4aSm+H4CZTMfbAuAFDdTFt33P6GESrMQE7bTjEQyU6aOgQEPtGi2sM//2sSlRyfI9vJD6tF4jR9TbgigvsxDg6K5+SkxaHOkW//+16u/I4ooTt3zx+Bkmh53EUAw4iTaG+8tpkj1jEvt/zOdXMFIJWQ+BUo9dTD/pX7NYK9+of/JhtEMKNwsP7PD2c0UC3g12ehiR6F8LawaE5P1VIH5MvgXFvW0BUQpFCToDy9EU/aENAa1 30rTR4qD SG9InGTF8jxev3DlcTGtFBU7uWjIWdzZ7vHk/vOY4vvWTSSpxJxN7Y8QN4uSenl1Cc0TggSAmdgRLcdkcXUZy9XwbM0GZGcX/W5kDAo8Di1bKCBLvTuZ4kvi+tPf/HEzx4GGo1E8gQdk8jvW9/LM9EPK6Ia4AXHYIL2VuaCdtjSIo7ddDJzDReMnfNqG4XVCCYyfr7lpkbDVr+t0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 24/01/2025 09:24, Alexander Gordeev wrote: >>> } >>> if (end > _REGION1_SIZE) { >>> pgd = crst_table_alloc(mm); >>> if (unlikely(!pgd)) >>> goto err_pgd; >>> crst_table_init(pgd, _REGION1_ENTRY_EMPTY); >>> + pagetable_pgd_ctor(virt_to_ptdesc(pgd)); >> I was hoping this might be equivalent to pgd_alloc() but it does not >> include a call to crst_table_init(). Since adding it would be apparently >> undesirable (having read the other thread), it seems reasonable to add >> the explicit constructor call. > We were thinking about a follow-up cleanup that addresses it all, but this > patch is a targeted fix to catch up your and Qi Zheng series in the still > open merge window. Sure that's fair, this patch does fix the issue and the cleanup can wait until the next cycle. Reviewed-by: Kevin Brodsky - Kevin