From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx155.postini.com [74.125.245.155]) by kanga.kvack.org (Postfix) with SMTP id B2BEC6B0007 for ; Fri, 22 Feb 2013 10:44:49 -0500 (EST) Message-ID: <5127928A.20000@parallels.com> Date: Fri, 22 Feb 2013 19:45:14 +0400 From: Glauber Costa MIME-Version: 1.0 Subject: Re: [PATCH] slub: correctly bootstrap boot caches References: <1361529030-17462-1-git-send-email-glommer@parallels.com> <0000013d026b4e5f-1b3deecb-7e37-4476-a27b-3a7db8c1f0a8-000000@email.amazonses.com> <51278A12.4000504@parallels.com> <0000013d028eec8e-012456de-9b98-4bcb-9427-2fbee58ecc74-000000@email.amazonses.com> In-Reply-To: <0000013d028eec8e-012456de-9b98-4bcb-9427-2fbee58ecc74-000000@email.amazonses.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Christoph Lameter Cc: linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Morton , Tejun Heo , Pekka Enberg , Kamezawa Hiroyuki On 02/22/2013 07:39 PM, Christoph Lameter wrote: > On Fri, 22 Feb 2013, Glauber Costa wrote: > >> As I've mentioned in the description, the real bug is from partial slabs >> being temporarily in the cpu_slab during a recent allocation and >> therefore unreachable through the partial list. > > The bootstrap code does not use cpu slabs but goes directly to the slab > pages. See early_kmem_cache_node_alloc. > That differs from what I am seeing here. I can trace an early __slab_alloc allocation from the kmem_cache_node cache, very likely coming from the kmem_cache boot cache creation. It takes the page out of the partial list and moves it to the cpu_slab. After that, that particular page becomes unreachable for bootstrap. At this point, we are already slab_state == PARTIAL, while init_kmem_cache_nodes will only differentiate against slab_state == DOWN. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org