From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04C41C3DA4A for ; Sat, 27 Jul 2024 16:52:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 18F406B0089; Sat, 27 Jul 2024 12:52:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 13ECA6B008A; Sat, 27 Jul 2024 12:52:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F20C56B008C; Sat, 27 Jul 2024 12:52:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D456D6B0089 for ; Sat, 27 Jul 2024 12:52:38 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 80A731C066F for ; Sat, 27 Jul 2024 16:52:38 +0000 (UTC) X-FDA: 82386126396.01.A02FFA0 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by imf17.hostedemail.com (Postfix) with ESMTP id 75E9E4000A for ; Sat, 27 Jul 2024 16:52:36 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=EM6Q3qPg; spf=pass (imf17.hostedemail.com: domain of axboe@kernel.dk designates 209.85.210.178 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722099154; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Y+l0/OdLjwlbZbjOAHaRXF47Ppkm7Aru2T0CPbxCmUI=; b=5AcAqbwNY2OXLFO60TiumTJ1/t1seI0mU6AoMmatbZibcpMr9vaBcScQJpR0/bfu1J71Dp NjHgbbPwQnFp+p58IHuf6KarwicqnT6k+H7KoYsf8wsAstf5IuWYOl/iOh44zWlAihGXfI xu9xwpV1kDM+77Z/wW8H2pvPiNjue4g= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=EM6Q3qPg; spf=pass (imf17.hostedemail.com: domain of axboe@kernel.dk designates 209.85.210.178 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722099154; a=rsa-sha256; cv=none; b=qpFFIcl6QT8iqJVB0LGyCtKWMDoONPdrRfOsEmr50oKUXyKgpS39wyHdev6vleUXfIyuHb 48XIqOzXtAPtw8IuiibVF7ZVhjrOPSdCoaYGcreJgr0+6gFQRknSSxRlIswD5AcyGGaax/ 0eiQdyUf4D2rFpQxyJXx4xDP6bJDVr4= Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-70d1876e748so141266b3a.1 for ; Sat, 27 Jul 2024 09:52:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1722099155; x=1722703955; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Y+l0/OdLjwlbZbjOAHaRXF47Ppkm7Aru2T0CPbxCmUI=; b=EM6Q3qPgGXRmhM6n0UQLHlMm3jsFCNxIN9Epn4URrb9uKkjCdXQWjXc2czwqlZwkuo tV8QPVG2yY2F39DWNo03iTvZn6/IlAceroFiYTAhCmxgLmMFCcHwnTUXxUe9Fbv0C7Hx wo7uhO4qyTviZh0dp+6gr5fJLSpMSaFI3LsY08LHwQhILq6FCgBgpWPiSo9VGauP/Khc Jt8quSf38yGtU9aTfMpT2eXdZJvEaVFLX3y+1JIxQLxJt1Iq0r3bgkTQre2RWrGBUfVg y9Qwxe2ONqNhhshDGsSHddo2CxBmj2OJYfPBgqCj09WkJwNouKnDxqGVvvh5cpNlV9mW nAMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722099155; x=1722703955; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Y+l0/OdLjwlbZbjOAHaRXF47Ppkm7Aru2T0CPbxCmUI=; b=S5rk8/YTRTxFp8l+wMVoQdu1ziecqLi6SWWtg/JJOozgsZGYNk4IgMOHQ1p9qakflA cO2FN3kbWpA/gYy7mH0V1VncBDL4RyjE8PD1XMs41+jTXuQrsRAXtgBCAgLJlw0w9IDT WtrMgBcESAaZpshz2HKPr6QMSuNebiRKi/DXPROre848pgJ8XWOoi4py1AILXFpp82H6 E+AOOXZmNCsbh66TfN1D8PmvAeBTsB7XUq0Hw76QPpCrvbFsFyX9RLZzEsSWHpza4uL9 MDZG8oa2rBL7B0c/cMmQKCHlrVcZe6m9hyRt6a+kp6LfJdhk5/68QfG3yKHSxXh4nM3w BuFA== X-Forwarded-Encrypted: i=1; AJvYcCUwtc9/nYv4irYhN+sLK6IfX6KrXgBQM+VFQDfUmNNxcitm+vJ4WLfFNkF/UDSxgNWR6keMBl6z7Q==@kvack.org X-Gm-Message-State: AOJu0YxPxmR4FDH9919CI/CbR/ThC86UN9dV7d7Q+C2gsZkzis9L/DLz WBh6mnkPZUteTxkLwPzKu6HA2S5Wlv0l45a8BqJWRRHukxKRaNR5WZH4VsCfzok= X-Google-Smtp-Source: AGHT+IGzG9vccYdruxEPQe156F+hMaKocvXuBBCM6uN1wi2w3J+pmWUqjQW+K22cjHdnj02lP5dikA== X-Received: by 2002:a05:6a00:6f5e:b0:70d:148e:4bad with SMTP id d2e1a72fcca58-70eac9a1394mr6557894b3a.2.1722099155000; Sat, 27 Jul 2024 09:52:35 -0700 (PDT) Received: from [192.168.1.150] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70ead81234dsm4369944b3a.115.2024.07.27.09.52.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 27 Jul 2024 09:52:34 -0700 (PDT) Message-ID: <5124037f-03eb-4966-8b49-a6fac0fd3662@kernel.dk> Date: Sat, 27 Jul 2024 10:52:32 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/7] minmax: reduce compilation time To: Lorenzo Stoakes Cc: Linus Torvalds , David Laight , "linux-kernel@vger.kernel.org" , "Matthew Wilcox (Oracle)" , Christoph Hellwig , Andrew Morton , Andy Shevchenko , Dan Carpenter , Arnd Bergmann , "Jason@zx2c4.com" , "pedro.falcato@gmail.com" , Mateusz Guzik , "linux-mm@kvack.org" References: <137646a7-7017-490d-be78-5bd5627609c3@lucifer.local> <36aa2cad-1db1-4abf-8dd2-fb20484aabc3@lucifer.local> <93243310-22cf-4d44-810c-17629b46a33e@kernel.dk> <1d87456d-b565-410f-bf4b-91fe5704617c@lucifer.local> <0c5b8177-3602-4840-8956-6196a6175c04@kernel.dk> <969b864a-a27a-4bdc-ae1e-e6132dfbfca4@lucifer.local> Content-Language: en-US From: Jens Axboe In-Reply-To: <969b864a-a27a-4bdc-ae1e-e6132dfbfca4@lucifer.local> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: qdqb1qkio5irdbufmjqhhrrz56gbwtpk X-Rspamd-Queue-Id: 75E9E4000A X-Rspamd-Server: rspam11 X-HE-Tag: 1722099156-853211 X-HE-Meta: U2FsdGVkX19UTTnHItn+paBHp5JEl9v/FydzQPP+Yy5RQA+8N7wjW93Am3DRXLmqRb/XEwogDF7o5DAbZ+FTEHEcLXayT8HX9ueuceiOztA3fEPyLawQr1vQVNG5ZzivrzVgE46R71nlAaP7VnbmIZ+WF/720ZwThHeZOsP5Wrk8VvYts20r5Q7Bet/2OjAHU8/UmBacZRVqNv9l67IY4oJyMcMZrspnuJ6vsJTeHVaTwxou8Vm9HxZ0kKx6ypHHMylLt2rthl47dExdLYGCydF7g5PoMF0Vi7lG6QM8DNh32dog1MJnU23k7jaFdk8lfh0AzssV277FIEJc6eC3e2Gv1N58xsYCSm1siVig8ezBnH1HeeE03G7Cuy3fqVhu5JJCw2RNSom/pr/9SGhGwe3tQ6QRZ5zt2CFZQrqoCysqqwAP7bGGcyqhbLXY/Mr4lj/ZZlQLsWZU+Tl9z+3EvpGH0euTUW402P7yTT7nVqaARnXJ6izXRQDp8Zv338SYUVxUbOMH0GVTzZZZZS3YiOe2GSD4hy5wGMlQv9YGB23IquIH5pXPM+/85D+fU8PtR17K32SDc/Ex0BO1+uZxSj24bOBgb1mznyB8+euptLtYIfLIt2gKu0+HoyECLBTrZkGXpommVNZ1XlKjIp5F/UuYAlsowauf4RJXfmmv9ju9xej/bc9aZgubxoENfDGNK1F34UoBJschctmAEGqRz80yCXlqhNNIQe0buxTdPYCbO6kSvAZV2EvQN04YqYiIOFBiAoTpmZNtnq7GrIFiAJpWsE5Z6yKBsarC1UefGj6aiubeZiyitFIW4up3P5UN5RVFC4GwadaGwr4Uuj4BnUbYc8+WVEiwDkuZ6Z34B+wBbfp3VS0hm3vi/xJ9Fjax0n/Dmd0Z5jZ0gLeCVrUwPpdVaITPkRxK+/vfUsaB8i0FcokmYLkOr91xpPu8qs3nuflrVtPqjQfEi9kZUSJ zzPgs3TY NnZqpcOIc51zR5lbsaD8B5W+HnRdCeRTussDbwyvT5qRwmJYlukH3ZZLh3cCi4i6V8sFNrl1qN6fVnfjrK2U4hNFJnX8YsR/UQr3h8AqjgAyFwADuvt8xPmdFD7pPPVUITvZdYPb2t7/h6i8XTl2gsGBJzLT4fArYu9lsMlsk++h6JGQHcCLswzCHQBbMK/6yZWLloIe92UcSLLchtwr9/AbvCkzICOJTWWfvWLaW/hhUNW8LaUCs4s1DXhbBiF/QQ+QXVmo+r5IvCM2/Fkn73gdnOyIaEiuQ5ksZfMxurHgahpZ3lddq7Zdna6Z156p61UroVjjjMItjEF2sxCs7PlKYYOXppPDMEjWxK75p9I5y+hz5NgOxFsNADytVdhXwy9RO+2Kv4KHPAk8ObuomLuqyAFNq6HsVMhvgSiMbtjPhWVIrY6RXdBtv6ILCrAlRTjpe X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/27/24 10:41 AM, Lorenzo Stoakes wrote: >>> Patch attached including Jens's change + mine. >> >> bvec side matches what I have here, fwiw, except I also did >> mp_bvec_iter_len(). Didn't see big expansion there, but might as well >> keep them consistent. > > Makes sense, am happy to give R-b tag for this patch if you want to put it > forward? Not sure if Linus is minded to just pull something for this now? Here's what I built (allmodconfig, gcc-14 and clang-20) and did a basic boot of. Was just going to shove it into the 6.12 queue once posted, but can go either way with this. Or Linus can just grab it and run with it, not super particular ;-) > If we're whack-a-moleing may as well sort the drivers I found in my > allmodconfig too obviously as some hilariously low-hanging fruit there... Oh I'm not, I got plenty of other things to tend to. Just got sucked into the block side as that looked nuts, wanted to make that wasn't insane. diff --git a/include/linux/bvec.h b/include/linux/bvec.h index f41c7f0ef91e..1cb76a829b83 100644 --- a/include/linux/bvec.h +++ b/include/linux/bvec.h @@ -101,9 +101,14 @@ struct bvec_iter_all { #define mp_bvec_iter_page(bvec, iter) \ (__bvec_iter_bvec((bvec), (iter))->bv_page) -#define mp_bvec_iter_len(bvec, iter) \ - min((iter).bi_size, \ - __bvec_iter_bvec((bvec), (iter))->bv_len - (iter).bi_bvec_done) +static inline unsigned mp_bvec_iter_len(const struct bio_vec *bvec, + struct bvec_iter iter) +{ + unsigned remains = __bvec_iter_bvec(bvec, iter)->bv_len - + iter.bi_bvec_done; + + return remains < iter.bi_size ? remains : iter.bi_size; +} #define mp_bvec_iter_offset(bvec, iter) \ (__bvec_iter_bvec((bvec), (iter))->bv_offset + (iter).bi_bvec_done) @@ -111,12 +116,15 @@ struct bvec_iter_all { #define mp_bvec_iter_page_idx(bvec, iter) \ (mp_bvec_iter_offset((bvec), (iter)) / PAGE_SIZE) -#define mp_bvec_iter_bvec(bvec, iter) \ -((struct bio_vec) { \ - .bv_page = mp_bvec_iter_page((bvec), (iter)), \ - .bv_len = mp_bvec_iter_len((bvec), (iter)), \ - .bv_offset = mp_bvec_iter_offset((bvec), (iter)), \ -}) +static inline struct bio_vec mp_bvec_iter_bvec(const struct bio_vec *bv, + struct bvec_iter iter) +{ + return (struct bio_vec) { + .bv_page = mp_bvec_iter_page(bv, iter), + .bv_len = mp_bvec_iter_len(bv, iter), + .bv_offset = mp_bvec_iter_offset(bv, iter) + }; +} /* For building single-page bvec in flight */ #define bvec_iter_offset(bvec, iter) \ @@ -130,12 +138,15 @@ struct bvec_iter_all { (mp_bvec_iter_page((bvec), (iter)) + \ mp_bvec_iter_page_idx((bvec), (iter))) -#define bvec_iter_bvec(bvec, iter) \ -((struct bio_vec) { \ - .bv_page = bvec_iter_page((bvec), (iter)), \ - .bv_len = bvec_iter_len((bvec), (iter)), \ - .bv_offset = bvec_iter_offset((bvec), (iter)), \ -}) +static inline struct bio_vec bvec_iter_bvec(const struct bio_vec *bv, + struct bvec_iter iter) +{ + return (struct bio_vec) { + .bv_page = bvec_iter_page(bv, iter), + .bv_len = bvec_iter_len(bv, iter), + .bv_offset = bvec_iter_offset(bv, iter) + }; +} static inline bool bvec_iter_advance(const struct bio_vec *bv, struct bvec_iter *iter, unsigned bytes) -- Jens Axboe