From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49553C3DA4A for ; Sun, 11 Aug 2024 20:23:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C9C2C6B0092; Sun, 11 Aug 2024 16:23:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C4B126B0098; Sun, 11 Aug 2024 16:23:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B12546B009A; Sun, 11 Aug 2024 16:23:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 901986B0092 for ; Sun, 11 Aug 2024 16:23:55 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 04DF5C050A for ; Sun, 11 Aug 2024 20:23:54 +0000 (UTC) X-FDA: 82441090830.21.EEB0767 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by imf17.hostedemail.com (Postfix) with ESMTP id 2A4B54001B for ; Sun, 11 Aug 2024 20:23:52 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=PAPU0aey; spf=pass (imf17.hostedemail.com: domain of rientjes@google.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=rientjes@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723407822; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5bxH0HIvgBIX62IPBNWvzW2DcCvjALZOS7xYRmAPq4U=; b=iz9tApISzxMay2/ZS/AVKqQuH6OpBEi7bqyecEg6tE/FQvNxqjMg+D/QuCxuU/eCPOrz7f qVxKaxs/3p0S/rPRtNuy4WgfRakZZ8ECXwG6ezDbZ+xDz++W85o/7Ur9ayFB7QKerz32oG Bt22UHqITl6gFHQvEa1CFpA50i52yXg= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=PAPU0aey; spf=pass (imf17.hostedemail.com: domain of rientjes@google.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=rientjes@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723407822; a=rsa-sha256; cv=none; b=uv1/BTmMm9OblEVWEHZ/2e59cCZUGmlwZ8ZzUo6wcEbBUKJsHFjcDQcPJPohbglkspYEFy KDnKYJC+h1Zum1CUFQLZuqfV/ACwpRXkchB0lhlMbvvjffg2AIk/csqiVlvgoRd2oTJXT2 eGkpXrOh3HdLQinQTYWdbv9Ptr5t+1k= Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1fed726aefcso174925ad.1 for ; Sun, 11 Aug 2024 13:23:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1723407832; x=1724012632; darn=kvack.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=5bxH0HIvgBIX62IPBNWvzW2DcCvjALZOS7xYRmAPq4U=; b=PAPU0aeyVdPmjZ/rSDlBofB9ZsKSX1PQW+9P/q1c3hZJHVqlKf4PXEk9wVnY975arH XDnyl03uhUzQuzC2GsaT9yOzACWJcwl9V+SreqkRPiynCCjxd+IDBfOrDKo+PXSzK5Fd oibOxn78vw9x2UFKQcaHWEyJ635gfNSjXQXjl4MeQFV2CcRz6FhdZNjYbLzY/kW6AUGP iTeugGA0caCtkF1HkGUMQGlUG2cJZUFyKBQrb8YeItmcfPoCsQDSyc0/f+sJTkXvkEZu IOwYdgbPk/R5+yNlb73zihhhDy/JSo0FsLy1xdxTp9C0IFo8+JScEdOQ1fIrSvOmfgIy yYIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723407832; x=1724012632; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5bxH0HIvgBIX62IPBNWvzW2DcCvjALZOS7xYRmAPq4U=; b=tKsJFeYzlxZog0H9vPb6bnD5vPM/vxdHqeXiUcaJc2SghP00utwkUhKonh01KZRVrw m24iqVltzayaF9E6FmkEd268TJTwozXL2DMjx2nh8ugx7dYa1SQ8iSPMza+qf0uVsC7g L8SkkAs0Zy8vM/ELindaYkQbKLysolWp4H4Hl6u+iJqh3PpUAZXhVXXn3u+snh6Q06Mn OAr0Y+QwzZ0X5JRQrtqVFJn6mUzyIpyr6TJAYsDkV/zh4T1Y0x7Hxbbl3fb71cIElC9j XdkraC7yD63YL8XmTACgC4TA6gdMdwIyYgdl94pQZ/eJX5v/AdAEI85y5XJjJMsvF7vD 6SUQ== X-Forwarded-Encrypted: i=1; AJvYcCVpakXUVlCvv6RCbuSbl68++A7dAPEPRZcUWQsb7fhrFgmoX2YG+Mh+NUDalq7E/Zmd7DG+b8rcZgCBh4BjJhITgAI= X-Gm-Message-State: AOJu0Yx+m9ZBtyldctvALvdynm/mpNSEcS9CBoVHddvMF1rsEL2qbfi7 YyCcWU8rXE/Nx1a7Y1zr1BIfsnZ6TkZMBBHFWuNVDtUlDGG71wXbkBON60ofOQ== X-Google-Smtp-Source: AGHT+IFzt+R10qaB9GO91xPW9cFIB/jOO3ilfp+AfFpKq0UrmbSVV8L6fnyPExoeusMwzL1aescGhg== X-Received: by 2002:a17:902:e84d:b0:1fb:19fb:a1f0 with SMTP id d9443c01a7336-200bbb56b70mr3361845ad.4.1723407831541; Sun, 11 Aug 2024 13:23:51 -0700 (PDT) Received: from [2620:0:1008:15:49ba:9fa:21c6:8a73] ([2620:0:1008:15:49ba:9fa:21c6:8a73]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-200bb7eddedsm25974795ad.49.2024.08.11.13.23.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Aug 2024 13:23:50 -0700 (PDT) Date: Sun, 11 Aug 2024 13:23:49 -0700 (PDT) From: David Rientjes To: Pasha Tatashin cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-cxl@vger.kernel.org, cerasuolodomenico@gmail.com, hannes@cmpxchg.org, j.granados@samsung.com, lizhijian@fujitsu.com, muchun.song@linux.dev, nphamcs@gmail.com, rppt@kernel.org, souravpanda@google.com, vbabka@suse.cz, willy@infradead.org, dan.j.williams@intel.com, yi.zhang@redhat.com, alison.schofield@intel.com, david@redhat.com, yosryahmed@google.com Subject: Re: [PATCH v5 1/3] mm: don't account memmap on failure In-Reply-To: <20240809191020.1142142-2-pasha.tatashin@soleen.com> Message-ID: <511c4828-cee9-72a8-8e47-ccdf80011a44@google.com> References: <20240809191020.1142142-1-pasha.tatashin@soleen.com> <20240809191020.1142142-2-pasha.tatashin@soleen.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspam-User: X-Stat-Signature: jyoj6ycuqtsi8y6s8ja3thzt1331bacc X-Rspamd-Queue-Id: 2A4B54001B X-Rspamd-Server: rspam11 X-HE-Tag: 1723407832-782773 X-HE-Meta: U2FsdGVkX1+iUHf58TaBqgqEw7TSNernLN8JShn38qs5ttNFkqqaOS5rLY0H4prLCj7SXtH8DZr1wiaF2Z9jwtRe9hgkeMrXAlV/q532TPMtwxbnvpegcS/BAujrBGQQgi5uAFZHNOsTtpDFC713PMtJmn988Lji8l+5WcX2TNLF/fiwPIVUWk8JcmbI2ccWxapieh1hO2XIlf147Sjnhxuse7IK0fajEchB0MbHPQSdRP0u0ER6VP1UrFy+WFnJoiOOzK9Bhs6Sblrk4AdRHLt4YOXs21ZcsWQLzXeqlSIzMJQ+pJn+vBxXHthtCw0gmw/SPYwHd+0L5UA0f4CzQgEU7CgR0Y5m8FxPthvng91CoBUVpQM9qUkdWgRpomjtrXlWQD/K23gj8a1WcLzctF/S/mCws7m3xbyLLpVRijBCGA3FUnumVUeWBZiGTLXY3YZYlCaqaC0BPgZzKm7TEytYM1gw/Cj4kqxh6MitcUScGccghCQ9BVO6KfK60daxrNEKRMTmudbWsTURp1c1IYvfNNEPU98MMwyobNlOj+2BOC8YGP3LwJ92hSotWyYj77Bek6/abQ47MXq+7PSfnKS8riBk/HW8GP5qKLpTis/+KfT/kuJ9IoJIR8hkfEEVmt21wVkcqHkrIlHWw6eiQMv54ZkMdLLmXQcX/TuWUPaX5EYCBld1lxQQ0STInP+uJc8j1+ffsbKrA1nPLQICA7X/IP9CcyK+c5VUWN7nZSbutLkoRg/TMyvzzkQsuMBYvmFddarNOJGRueznNEbazeJ/UOfTV8u3G8i6GmOYV8W+NOz6WgIQXvr7RpI0zUs+qpEoJXrXKKJEyIjdsDy8w71A/IrY/vu8HF/TbPMncxnupUbGdNvLT0wxLUiqi7X+I6A/5kG2+wL19D1r94FlGd/8ZLh9pviQxPHC59Bw8n33t2H50X/KhVePc+YTyWzYs3faDvm50y662Zz510l hF30Q0pl AuDocNIgLYctIzAJ+F/0WdlJCBu8u34JnWWoYdioiwO7r/40cMteHliD4P4epEvbk3Zup9rrPmFd6cd9wSeSpb6DxlDV2u4/qMZAwOalgrXKr5vjqrtVIH+AljmTpu9icZTHq8aqanuQ6ETzdQDKtxnmdbbGhp25jboGF88fUhJoBRxlkew1GZUiKLgUKTQUMmublrkw3KWZ/K5rZuab40gNf7XRcu1fbWoHnJPLClcWz7XbJR2Jqx7fY8/YGih36KeB6rvEKnE7tb1HzfmF8sIbDnJSu7OXavJYfetuq4cceGRbxSqxgUqgXEJu9VGUrF6H3t3gwN179x/IgYSNwL1xRXX0koQDw/ln4XME+XBlE1eWBCmXPVKXfPSFYs1ux7hcOeqv3bVwv5Rw/M3ylaYBmQF1DM9b81oW0E5cieohyqAJZWpYijXM6mSDUVQ4HbY+r4L/TQP2ZhLPueXYvPIl4hQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000650, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 9 Aug 2024, Pasha Tatashin wrote: > When we fail to allocate the mmemmap in alloc_vmemmap_page_list(), do > not account any already-allocated pages: we're going to free all them > before we return from the function. > > Fixes: 15995a352474 ("mm: report per-page metadata information") > Signed-off-by: Pasha Tatashin > Reviewed-by: Fan Ni > Reviewed-by: Yosry Ahmed > Acked-by: David Hildenbrand Acked-by: David Rientjes