From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 255AEC02181 for ; Mon, 20 Jan 2025 10:38:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A273C6B0082; Mon, 20 Jan 2025 05:38:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D5E36B0083; Mon, 20 Jan 2025 05:38:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8013C6B0085; Mon, 20 Jan 2025 05:38:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 605026B0082 for ; Mon, 20 Jan 2025 05:38:39 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id F384DAF48C for ; Mon, 20 Jan 2025 10:38:38 +0000 (UTC) X-FDA: 83027481516.04.FFC4E47 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf05.hostedemail.com (Postfix) with ESMTP id 8815C100009 for ; Mon, 20 Jan 2025 10:38:35 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=JwAph2FJ; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=xsun1gTL; spf=pass (imf05.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737369515; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5e/7b+fNO4T1xKECC03Ke77HCBQKD5pR6t7eAnGHpqU=; b=4qhYW6r9I51XOxHXvS6a3pxs1lhXuA0GJ7Yf0Gwi7J7uJSKQKcuy3g28z4ecsE1nX46BYF olqtVuY/C60jpt+3Bhxufwk7qiyJS9nYfa6TrbS03L2ZpsECYn8YYluOskJt4eGYWlO/y9 pTGiPAwnRV35MSDqgKyjfo09iWXcdJM= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1737369515; a=rsa-sha256; cv=pass; b=zSixUq3mE5zMdXQnAbyTu30CpUn4hVT6iUS4FATrOfFshqmhm3bNn4wbhu4ChWFuSQVwBd ZeCVOAfIIfI5X7I9DgpGgrkKoW22lceD5jR7ib6STt/yYl+TJh6ZPa7t2AV3SeoZpSUVPv iBAx5qU9CKHvhUWjAqHmveRpLutYfGY= ARC-Authentication-Results: i=2; imf05.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=JwAph2FJ; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=xsun1gTL; spf=pass (imf05.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50K7fw0s023648; Mon, 20 Jan 2025 10:38:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=5e/7b+fNO4T1xKECC0 3Ke77HCBQKD5pR6t7eAnGHpqU=; b=JwAph2FJxKpYfCxJ8FJtgNfxMZgCKOxLUf RmTvcD07Vuzfiu80LvmgjlCECMLZ5svEcbWcuZVvLmHzearT747CINRqB4uCnE8N VWNkXHt/Bl8cH2GyQ7Q5sTbZjeo9g8MFfvMh7qIJXodRgMWTgrkSjfG3MCN9r1Gy FSWM6jSuQ8SH3GdeCz/ZZluldvyzneSRqEg5L+tp39Two7hffS86wyjipen2OwAq jLyZuRUHy8v0n/hoy9tRhCmcUgt1/EdmSVSXsM6sfkvgGHHHJrsajY218ADy40su j9G9nFIoYJm68C6NgW668iO7HnoNZcn7RCneqbXo7Rr1yMaHpEcQ== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 4485qakea2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 20 Jan 2025 10:38:25 +0000 (GMT) Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 50K9PAe9019499; Mon, 20 Jan 2025 10:38:24 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2171.outbound.protection.outlook.com [104.47.55.171]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 4491c0yjyf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 20 Jan 2025 10:38:24 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ZJR3v5k62ttzUPe3L96zTxws5bzHVAE+uJh1sssWA6mNrK0EQfO4mPRenifbKgGD2OTt9SkIAtyJuFN0l2eYMT9MzJhuW64Xtu1uLMeU6Ug7Z/pZw3wXUTeeC1K8qDEdFyLSk5RT22cy5P73+uILqLFWrgGthh72pA5tBH1LGfqqH/qO6VcjqcIK9i/JOl4KVCrVzMoztyjeuB4DQG6j1xBF9n02t9BKzwyVJ/MfeqnhqgrFr3YLU/zutcEYeusmKSpJgtha2zp6kJ+61g7Mf4dPWjmOJ8aHWGFQ7KIs31tBkMJ4PXRuIawKse/rAPN5PBSgz05LAmeK1vsoMRjJFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5e/7b+fNO4T1xKECC03Ke77HCBQKD5pR6t7eAnGHpqU=; b=GAgGet4W8DALiCvygMvVazlWnb6aqVzibd01XRPhArIjVEMuGxXFscIOCTFQcAOfYz4tAeIG7P9y1Be13liad2T8RmidXf8r5HNXNkLF82ewfxsdatyQf+dUGqLruAdWXuc+Kkl/kicLkR8t+tbwtkVDbkFFS9Alvjro91palK1c6PAX2CkoJ59uMCj0TIZn8IgcMVWWqQGfwHjwvG63fcWcPp5wXfGsyT5uzPHgtdJZbhH6GsJsfz6IRLtCYh4QkwgBeZJSylUmxStmbTeK6HkL11KdW329zR3eUbGUrTyzGaZtYBUMkwWfNUGjrUUTJnBCv/r5GoA9deldU/5pJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5e/7b+fNO4T1xKECC03Ke77HCBQKD5pR6t7eAnGHpqU=; b=xsun1gTL3w+wzq/yA67/MLoCKplP7xibwVinLlbyPmB1Giucvif6vKB8AFlAuOUBKIG+MGqBJ0rEDePE79qXqJpQEPPwSyEbzWtfU/COuviAU2EXk+7aZ9DNP5xgTmkRQIVaUotHztmq+ac4/KT0Ht/p8pg4TiwMh/BaWUMOSD8= Received: from BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) by PH7PR10MB6377.namprd10.prod.outlook.com (2603:10b6:510:1a7::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8356.21; Mon, 20 Jan 2025 10:38:21 +0000 Received: from BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9]) by BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9%4]) with mapi id 15.20.8356.017; Mon, 20 Jan 2025 10:38:21 +0000 Date: Mon, 20 Jan 2025 10:38:17 +0000 From: Lorenzo Stoakes To: David Hildenbrand Cc: Lance Yang , akpm@linux-foundation.org, 21cnbao@gmail.com, ryan.roberts@arm.com, dev.jain@arm.com, shy828301@gmail.com, ziy@nvidia.com, libang.li@antgroup.com, baolin.wang@linux.alibaba.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Liam.Howlett@oracle.com, vbabka@suse.cz, jannh@google.com, Jason@zx2c4.com, Mingzhe Yang Subject: Re: [PATCH 1/1] mm/mmap: allow MAP_DROPPABLE | MAP_PRIVATE in mmap() Message-ID: <5118f207-8982-421c-a995-23798355f020@lucifer.local> References: <20250120012607.4808-1-ioworker0@gmail.com> <52a45aa6-1554-4cb8-b8df-da601c4e18ca@redhat.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52a45aa6-1554-4cb8-b8df-da601c4e18ca@redhat.com> X-ClientProxiedBy: LO4P265CA0290.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:38f::17) To BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB3366:EE_|PH7PR10MB6377:EE_ X-MS-Office365-Filtering-Correlation-Id: 09d1abbd-cb56-48e3-81a8-08dd393e8f62 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|7416014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?5aw8aA8MKVoeerpILyrDoESuovEe1nZDWIUv6etg0fMTXzExNClhWBqzrkIa?= =?us-ascii?Q?6OiFq321eY6+zvudwpHeX0AYSz5DlIJ3tPiw2pBAhVRdIYuYomyQoroRvu0c?= =?us-ascii?Q?CMbVUvesL/V6Jw0xyXnyW2HHTg4gZXpm3/yNT5jm3nCzxS9lpmLYKRJkODdI?= =?us-ascii?Q?oKf0j5IXjc3W5dfTkEEP+woDZ+m8oM4/nr3h/AtFgR8N0HNZh4KWw5bngiNJ?= =?us-ascii?Q?/nGk8zFZOrOuwHHPYLT+4eW/RXdFEpJjsZSxecDGOWw6O8+q0Vsq9Ucy4pFV?= =?us-ascii?Q?ynu93zGp1nbMyVW0Y3Jv+Fuk9Uc/eCwXmbZBLgfiraI47oSw3zOjb1m4vmJc?= =?us-ascii?Q?ogWm4bG7NIe37T4XLixfZfzcaLwabF/F517cAzA2o0VN6NyLNnLt7kFoq337?= =?us-ascii?Q?wYhuYnxKn6GtQYbL/+sq/T9QEBH+idr9/wOUWKXqDMlyNpIizWnaaIHkCHKk?= =?us-ascii?Q?dai90j2sBZ7Ci1qc3QLKz7VStnIkf3SXrzUWNwx3IVzru/bEUlyjPj0RqdiP?= =?us-ascii?Q?iQU+BRWEc/6Kw1OoPxZsxyD5H59LXU/NEmbTuL9S135y1OAxy5R9bmcZ7AWb?= =?us-ascii?Q?1HL2TGpVVp3p26BQ5icZ6SU7XvBWVsia2CUK0a4qQ8ruAIRGeFqmKNTVhzrH?= =?us-ascii?Q?r/XFHL/76+/GWGPHijJhBl6rx+r7pOV/eKddp4ZOZ89iAxk+97cgYfiba595?= =?us-ascii?Q?S8rmsdw9tqElDue9N6cUCKQL28jnFS4cfsGxAiBY17qWyPkqZlZM7c2m4fPp?= =?us-ascii?Q?BKvmyCR9kfiRQTGPtoHwk+PWVZZIUqwBn1I+Cve3LgcFyfspffq+DWOeq1Yw?= =?us-ascii?Q?ZyBj8qGglRGA/Xneqf8R3GTV2XJ7B+P0nu3RU6ArFrtK3Jb12bF0eihoKh86?= =?us-ascii?Q?mxgPUlsZhpqUhgeIns837vpgAPU7FxvkS061MFTBVZWxWJp/hUD1miMBILqW?= =?us-ascii?Q?3jKvyUsiUCzn2loohd/maVeFC5jg/fnI8+J7eaPJEb0aTn4Vt+cMTKhx2UHg?= =?us-ascii?Q?sXuRkPju0PlooHz2uyh+yd4Y8aAjzENDF0kJ49b+9jAr7QnNw4/vqK/vEh5w?= =?us-ascii?Q?i+w3gjFDYC3Inrcdg5Ofeu5j+0A/jzbeSihZRVZ7qpLz3krZWjqXjb3ciMjq?= =?us-ascii?Q?/thL+T9o3yiIqv6PUhu9Gv+TQRjJsl21LEp3vNm5jc+stSHeK8J1dqEXZ4XE?= =?us-ascii?Q?qIYSeNFSOSgSFVML0haFU2zxS1uQTu8zf/2cYDOgDv73CsqNWVFivqBmOAz1?= =?us-ascii?Q?hzKO8EvA4vHWGXamlKJt4wL4skstkSu2qAH2+vUAKKyfLYu0MXd5iFRIocED?= =?us-ascii?Q?GetXBdFAJ6Qs/oiropN45zhtSyEbhT+meqUJDUthA9WjBQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3366.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(7416014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?uQMH2gr+15RDPyBzf/o9cOmf3FNbBf3cf2qi00aawvvgbwFw4fivEEsnMqRn?= =?us-ascii?Q?D1tg3TtO6tKCLGAWSqsuUtWIeb2EdWzS7dcoTwcnu41CHcrlcrG1dj+Abc/k?= =?us-ascii?Q?ac4wdwf0+jTd+z9a8tmgOpAS3apmkAOgNbc1QrxgzCcsd61QK1gC0Xgg7ECy?= =?us-ascii?Q?5IinvD0e+A4mgATso5FPuKyXmkNiKDqeWpRUmD8p/Jpq9gxpajIjwazOzbFm?= =?us-ascii?Q?CHmFwsSL5+4Q7tCl2RaZVtf5riArwCuygntBM/qnJsPLCwLDQJ6NUYWR1aXq?= =?us-ascii?Q?gXyQZKDteISc2AT8kkAOeFUmbEWgSIV2z5Nj08xe3r5WLKIU3pkcyXllUbAc?= =?us-ascii?Q?Si6cVIjM+wySPCDfyD7tuK0fhQjG+Re6hdm/Tyncx5oOx1lnstajlE+MXyf2?= =?us-ascii?Q?dyk7rSfsjVX3qAHOgoKxlKjv+cLUkjY0v4jbviEMiCRqMpcjgr1b3VT8l4RK?= =?us-ascii?Q?iXh7wZdFRJSh+s5ZU7ahPEUklqxK4XqSGQ3KDiM0tN8S+8SxsDc1s8dl1WN7?= =?us-ascii?Q?993tB5C66y0M439sbIBGzkW6t2TS0PXYFluUlZiFWElXRIZ03t0c32URZBnG?= =?us-ascii?Q?4ltVEr6OfdfCL5FCuYikcv+gv+iy5v0duQONPEsNN5ZlAXwGdH72gjcEnRHR?= =?us-ascii?Q?qG2x+gLtQg9vQomTgnLcofkDevB5AVdxnyRbRpO9yXCj4ldTmWM2EJ0LvvO7?= =?us-ascii?Q?SIXPIxOChqUPnjLLbu9CEr9BPme+XHbWw7lHcy8QyE0FfygGHHoAJKBSOCJ4?= =?us-ascii?Q?b425FEBuCRhtPkCiY7ZZsqsTzWbyNef6oxb5udT5r1ZKqL4fB7XAkiAXjBOc?= =?us-ascii?Q?vmHOXD6ktCSxkXDRq3hINXf6WqbrXvlh5DYcDtZ8t8vDjfr2bAWslma8nO8l?= =?us-ascii?Q?uW9QCbH8Id2iB5SiAa6+RNkjFSw37+KoqWVpzZoKn/cKHlJowGeOUALQMcQ4?= =?us-ascii?Q?CaqZ6bQXWRoc58sFD70RezuZUpOz8u7xMezOjvEa8ip7Bav56gxFhmcrd7hw?= =?us-ascii?Q?ui9Bkuqa5Regdpww6nhvKEubPbas86FwcQ5yWcRQjz0lbbIvCdaBYFidv5p6?= =?us-ascii?Q?RqgynwKcDqVpCSwxy56gY+H/obQqXMGnKgrIGHlH675EKQCxlrRiD18KWRE/?= =?us-ascii?Q?QRIK+QVjjLZ90Am/Q/ENC7syyQHU1gwdlV7vEowhA2BWt/fr8B0Iyew4qXtQ?= =?us-ascii?Q?mrpHiT7ppR08kfyrGkYG2xxyFlesPgmciRVPSiKSZvwrqaiYBjkUNCClF9k/?= =?us-ascii?Q?PWkMun9UBurkCKkItjABcnlo2arjeY7v8esZCK8ZX3WqMKg6vnty0R+nL1qf?= =?us-ascii?Q?sBsGDP6C41jQvtCgrGjSKFCi5j9Bs08WSiKmvBHvzLyJTGV1r09rqggOBICv?= =?us-ascii?Q?MjvhP7foulMfrYpdKquOz/HoX3847W25/Z75qhpkP134XryRf2INwqm7n2qo?= =?us-ascii?Q?X/Lx5LpZzAk9UuU3v5jiZxQN2iK4gPtKLxEjpabUVsN2gGzDC3wgAW1KldqZ?= =?us-ascii?Q?o61me4Cj0P4SZE7wQtoPLhdkiWyhsWUneY5k8WbhzSCQm2CE/uD/ED41ePEJ?= =?us-ascii?Q?A2TwXVMMLxDwWVTMuQ5/snxodml5+L6a97egUQgprLLo5Heywvst/M4G7VrV?= =?us-ascii?Q?mQ=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: q6l+E40LSgsGsnpP99jpRkClU6wyMCCJoVHrRNgKqHWjRF8br0fgZIalqvU1rKLPVEX5xOgRemSQ/i3zpkA7ASeKLGFuJidmOt9ETIu/+rXzkBMl6bvhw6xfUCW33Hfjm5GRkduxPPa43INI88GHx2NO7EjUSQQDfP86zhZ5lhwQasXrj1BkoLVqEXRr4dflXeJs66OfzU+YwYIVMd5E8Kh+t4f9PJ3l/TiwUcpKImqDaUe0s0157d+Vq3kRdm92e70+0Am3snYrnsXNXTafFi5F9ue0MHn3/7Q0ig6HMjPxn4UUSaxDIRC9k7XiEp+YZzPC4Qi7qv5Uli5g463SDi7V/EtTxNfhnlSUsRuLvIylpn4FO8yqhCCE9eMrba2NVn/KpfeogkQb6qiLSZbNERFW0DfphO6rEcn+RtXP8vd21slsuQHnZ4zqeblCu2tzT9v/xZdLCry9PXSwEods0JugFlOdskM6rPjifsHbz80wokD/gd+5XlD95UD8gILveA1jO9ugWpeRAX6N/cuBwdKf9D1rPTIf7642lfL0na8cXQuwGF6phnZR5plP+OL2fBRgV3mFdw8Wtz2zEJ65VK7GAtf4b/Lgn/9rjGwrXkI= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 09d1abbd-cb56-48e3-81a8-08dd393e8f62 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3366.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jan 2025 10:38:21.4560 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pwr61rdrL0ATMR+WDfi2uKfXIamQ7Uba+5eJ7Cx5uGlnmiJT57Zxjbg630g82n9uqSQdjnnkrOR1PLwHLkergn8aKLs1ypFLMykvVBrfOnY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB6377 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-01-20_02,2025-01-20_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 spamscore=0 phishscore=0 adultscore=0 bulkscore=0 mlxscore=0 mlxlogscore=782 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2411120000 definitions=main-2501200088 X-Proofpoint-GUID: tu0wr-adGD43SZl5qgDykj3-cyGMhqDA X-Proofpoint-ORIG-GUID: tu0wr-adGD43SZl5qgDykj3-cyGMhqDA X-Rspamd-Queue-Id: 8815C100009 X-Stat-Signature: tc3kjszqbjh5mmf8efmwut8sbykeznwz X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1737369515-181052 X-HE-Meta: U2FsdGVkX19AQbZw764I8pU+quNJ8r7/jDKB6vnTe6hBpR1M+7pbSWvYd0dt471TtHve7c/uHynGbwaOEWfZt9H7QX0142DXFpu73CbKzgzURV0o4pL3p8HgoMt+VlIaGoeuwCY7qe60II3Jf8jk+PpYc2td+5Xrvu/vEK0uDbAV6vIJ+T+IufTewjLxQ6/Jf3beI80Hl3TwwfIpC2EbzmMm8ik06V60hjlrbgy01+RryhJnznJy7DZQcnF6hClJ9sCSeZ+XB5C+EOezm4vog0dXu+EZmVF2XqZW4HeIuqWWy2FX1nfGunce3SoBCtM8eWxW8ZWlHAZQB1hoFi1EFlJJW+0/BOigmm1nad9OscRLd/KhSwX4oTG3WoNHilwvmSjMoFjIWIttGmcsqSzNM1j+bR0UqMiFmY9tT+jyaqbkiDnrz+OSyJJwRGbaes5jx9y1K7r4vGl1Bkx8CcJ0ZO9mOydpURcFtz9g/l2xDB0MGCEQ4pgVB85KW4iPJCYUbEbTgLxfRvs5rM0MIu3+q0eeLxXoUkAUrYBtxV101Ji+XmjsCjUxe3cOV6CDs55lTwlLysw900Gh3I03hUOWxhea/jOGCLlfR4N3dp88jNRI0oRdjy/xa/2rU+7v5OlzTxED5wTBhhVxeeKpnF0oECBW/b7bhUgUIojMgmYrgzsUz4NLSASGXIa0fIk0qb92q8xX9j8h9YrVYLa6trZinzGnQ0mr9h9r2W7R016s1Wtjtz52aE8vlbzzPpTwr44L8F/wa2d291IMNWDhW1DavnCpDqN7n5bL0NNfP8P4yKqvNEer3gf5geIXGEJy+tLbvmqrGL7/O0fihDpvvmgct8qcSYuMv03V6RYv8M+NmHikBQGWoKnH12/RVYuaxstrZwqJ2ZjxKNMtuE7GsruI5ebymKYBR4Zo1Wpbi9T1434QrIDEs5X7B1GiWHeXyGV1ZEunW5E8qALdE0SGPlW Xwy8R0ay pbkh6TFjog6e6KqRAffFDmHGios1KJjIBoEkFCHJuVvYfyi8RsVQUoa//jv5DtjdTJLEbA6Cr6KGXQO/my4Yk7uoFChKCHRJXp0ZwtiNGZ3sakitodNQOq8A22Szg9hK9H9UUD98E5wPxmvnAKNh7IzyvxbtkisMiincj9rKPkWZm8aTXivbm3zIQ8gILkFWl8voUbEB6Wkcm3GshdnstVHuIYEHrSRotATJUqh7mHWlrkno45g02YyDmOhRjfXbk2RjV5xIBtUA79SrJiazrdcjQC/sV4PNfpr1b8sXqZ3GRLqjz+w0R3M65t+DdS6ahpmaUAFblaTyxEN41FCpRxjxupLFrjfeOechE2EMkJZLtfQMHHpqk1A2NnEvL6xeAjbV3Bx+4AJ3mKqaDvT9u8dAP7T2k0K4YUX0TxjDJz9rTmjz+OfFaZUtfcFv4ms5eafDKC3HIq8i4nS+m5gFt+gCIPVEGDM8YdExu20UKKyL4r3x8i8rLnCQhsm0jlobyZN+Z3+9OUTtvoKke0vIWb3wECbkal3fDuVYENCqjdIe1VBflHpptJzBn2e5wF47ua3Yklv1f9mNZ3ZOXpyrd10NQErsq52gPbKtufz/xLVKebrDXXl9otlaM1fqgAbrsISRSG1SfnTmhX3Q= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000264, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Agree with David, NACK. On Mon, Jan 20, 2025 at 08:45:07AM +0100, David Hildenbrand wrote: > On 20.01.25 02:26, Lance Yang wrote: > > Currently, mmap() fails with `-EINVAL` when both MAP_DROPPABLE and > > MAP_PRIVATE are specified. This behavior might be inconsistent, as the > > implementation of MAP_DROPPABLE under the hood already includes the > > semantics of MAP_PRIVATE. So, IMO, whether MAP_PRIVATE is explicitly > > specified or not, it should work as expected. > > > > For example, when mmap() is called with `MAP_DROPPABLE | MAP_ANONYMOUS`, > > it creates a private anonymous mapping. Users can verify this behavior > > via `/proc/self/smaps`, where the resulting VMA is marked with the `dp` > > (MAP_DROPPABLE) flag, and the `Private_*` fields confirm private memory > > semantics. The output for a 2MiB mapping with these flags might look like: > > Note that "Private_" in the stats has *nothing* to do with MAP_PRIVATE. > > > > > ``` > > f433ace00000-f433ad000000 rw-p 00000000 00:00 0 > > Size: 2048 kB > > KernelPageSize: 4 kB > > MMUPageSize: 4 kB > > Rss: 2048 kB > > Pss: 2048 kB > > Pss_Dirty: 2048 kB > > Shared_Clean: 0 kB > > Shared_Dirty: 0 kB > > Private_Clean: 0 kB > > Private_Dirty: 2048 kB > > Referenced: 2048 kB > > Anonymous: 2048 kB > > ... > > VmFlags: rd wr mr mw me nr wf dd dp > > ``` > > > > This patch changes mmap() to allow the combination of `MAP_DROPPABLE | > > MAP_PRIVATE`. For mmap(), at least one of MAP_PRIVATE or MAP_SHARED could > > be explicitly specified, regardless of the combination with other `MAP_*` > > flags. > > > > Fixes: 9651fcedf7b9 ("mm: add MAP_DROPPABLE for designating always lazily freeable mappings") > > "How about we just say that VM_DROPPABLE really is something separate > from MAP_PRIVATE or MAP_SHARED.. Which is also how I view it. I -really- do not want to add a weird situation too where people wonder whether _not_ setting MAP_PRIVATE infers some different semantics. This mode is aggregate in behaviour by design and intended to be _specifically_ asked for, not in conjection with other map flags. > > And then we make the rule be that VM_DROPPABLE is never dumped and > always dropped on fork, just to make things simpler." [1] Yup. > > [1] https://lore.kernel.org/linux-mm/CAHk-=wi=XvCZ9r897LjEb4ZarLzLtKN1p+Fyig+F2fmQDF8GSA@mail.gmail.com/ > > So, nack from my side. Also, mine. > > -- > Cheers, > > David / dhildenb >