From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76829C77B7E for ; Sat, 27 May 2023 15:54:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C5EAF900002; Sat, 27 May 2023 11:54:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C0D416B0072; Sat, 27 May 2023 11:54:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD680900002; Sat, 27 May 2023 11:54:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 9DCD66B0071 for ; Sat, 27 May 2023 11:54:41 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 6B375ADA6A for ; Sat, 27 May 2023 15:54:41 +0000 (UTC) X-FDA: 80836482762.20.29D739E Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by imf10.hostedemail.com (Postfix) with ESMTP id 92F41C0017 for ; Sat, 27 May 2023 15:54:39 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=gQhLpA9Z; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf10.hostedemail.com: domain of alexander.duyck@gmail.com designates 209.85.210.174 as permitted sender) smtp.mailfrom=alexander.duyck@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685202879; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=l+G4puGLv1p8z/Hlge1/6NOCJbk0UrLfWek2Xulcb84=; b=7ljhNLt/VfO84vMUU+j5UyXxFx1LtVlllH1zHl2U5tbbOS0JpXq/OV1qU8RY95Um/pu7Ma aoNCG3bTpdah+BXzKD4HAM1CkS1Zf0EiqdmaS/jQUcYM/JYlYEhzUebFdvioo+wW8VJl3m ELPZVEsDPgodWGDvvmOqkuI9LifYpys= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=gQhLpA9Z; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf10.hostedemail.com: domain of alexander.duyck@gmail.com designates 209.85.210.174 as permitted sender) smtp.mailfrom=alexander.duyck@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685202879; a=rsa-sha256; cv=none; b=8RSiD8bxPnDKrKU8LFkoVnadpyi6qxxn6P4qU5xdqgz0EMMejjsw8A9vcKWjALKbpatRXk YjW1k5YEcgxw1rqdXgZ7PfcG0U6TIlE5tTziIk3f+NO5y6KysgissqOq88UFBIYr52A6wQ xZ0MiUnAzxiE/RqmkDu+GbHvQWmzXuo= Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-64d5b4c400fso2293203b3a.1 for ; Sat, 27 May 2023 08:54:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685202878; x=1687794878; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=l+G4puGLv1p8z/Hlge1/6NOCJbk0UrLfWek2Xulcb84=; b=gQhLpA9ZJ3MsbjBLRHKg/Bu7sQtUuFnFo0w9+0BYJ9KOLiAmaHm/m4Y4E06NNRB1dl 0q6K6DFbWeTb5Z/iyCZr4tT1ppDQtz7yJeeBl9m8r9FuOoRb1xD5m3BqBek2b4tbNxxa pA67T941mfHhp1dUVfT2Jr+DVuBy/2445xXa8FHpcG7rg9eZAqCVjK74O2s10v+F/6ug hMy8q4g8ddP/1iBz/DlNKwpEJann3ERIFh3Wn4PR1+/YgtOpHJkf01XWT69+1N+oMzVG cQNsioSb+HO7UB/dsiirhUAhze1c1ZFpySoti411TJ3f8G7crCWmFMZf6m+agVEApcpW vz+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685202878; x=1687794878; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=l+G4puGLv1p8z/Hlge1/6NOCJbk0UrLfWek2Xulcb84=; b=TUVrAMOTJVphYMaMTBKwsNtK+WNyG2E1cEr0R8hJ/G4rT8CRBndlNqjMg5tcdGeRbe EAB9gz7I0EaqEMU9IEmBMHBj0lgyVA9oYQ5D1NJBy+ax8TbZRiU4KVtysiNdKaRJK5U/ GOKnfUnt3I+AOezE+R2F+R3V8aJcqHBQa1w1cpbLvtsdCSZsnF0GDLJvyDxj/Lr8NlO2 941wqT7oXos0Vc+G5voqXhE3WPCYPYpphmipVlKDhC2SpS7pzGfZ8RZ2+750zg6KJkA7 XynxqurQg1+NilQEs7VbT/eXi8laoWvwPhDhWihW6/JRzXOxQi7knI4NktUVqNAl50kC rr0A== X-Gm-Message-State: AC+VfDwft2hAjBo/EdXsnRssiHRPN27tdg8cMGmUd/jZ5pAWGW54whVb qbi7VRvI04WDR/WU81gZhec= X-Google-Smtp-Source: ACHHUZ4eTm+gSTcfMJyzZbWF/OB3D5r515LcsPPvEz9Qas5w+qwp4srtHFosGb4KBrd58salPotjYw== X-Received: by 2002:a05:6a21:338b:b0:d5:73ad:87c2 with SMTP id yy11-20020a056a21338b00b000d573ad87c2mr3545769pzb.56.1685202878254; Sat, 27 May 2023 08:54:38 -0700 (PDT) Received: from ?IPv6:2605:59c8:448:b800:82ee:73ff:fe41:9a02? ([2605:59c8:448:b800:82ee:73ff:fe41:9a02]) by smtp.googlemail.com with ESMTPSA id v12-20020a62a50c000000b0063f1430dd57sm4201560pfm.49.2023.05.27.08.54.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 May 2023 08:54:37 -0700 (PDT) Message-ID: <51161740e832334594960ed43430b868a6f892c3.camel@gmail.com> Subject: Re: [PATCH net-next 03/12] mm: Make the page_frag_cache allocator alignment param a pow-of-2 From: Alexander H Duyck To: David Howells , netdev@vger.kernel.org Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Jens Axboe , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Jeroen de Borst , Catherine Sullivan , Shailend Chand , Felix Fietkau , John Crispin , Sean Wang , Mark Lee , Lorenzo Bianconi , Matthias Brugger , AngeloGioacchino Del Regno , Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni , Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-nvme@lists.infradead.org Date: Sat, 27 May 2023 08:54:34 -0700 In-Reply-To: <20230524153311.3625329-4-dhowells@redhat.com> References: <20230524153311.3625329-1-dhowells@redhat.com> <20230524153311.3625329-4-dhowells@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4 (3.44.4-3.fc36) MIME-Version: 1.0 X-Rspamd-Queue-Id: 92F41C0017 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 7f739e855r9hd8jz9nws6nxo4w5kgmj7 X-HE-Tag: 1685202879-337727 X-HE-Meta: U2FsdGVkX1/kJcAMRqZPkHDEL7W1gNHXN98LbGIr2xxE8mQ2Kw89gIDrY3clFUU3ITT3tcC/lsq2Q7RF/gLyjbyxRaMc4/hW4WA0lL4/InVPfHw3bBqOjwyO4Ie5N7wzZgPySdRzXcmD3rUk+Tx69kfbzvzxl5lP2VBzeWtbhy5GkuuRAfDLhJcyf6TyFLy3+wHhL4odGgbf15zNKh38XkfuPdaru1do5K80WYFRqAsnmVqLvyQAivYIbeVvhc7DPPoVz2mTrbFlorzcauNpkj2at0Dv1mikORTEVxUBhdbzwFlry5hBlvYjP7B/5QTnjZijAKPNcRpq5pyU0PjWWMnWjsxTHQKUb63TQqSl/0UIt9DyeGDq6810HDpXNeqjgw/OF+xNfplTqmc1IfvGAMOz0wUBIk2qK9WefFFV6v1N4/vzib4EpXMB/QqL1rBKOFvLb+nV/Mm9g1R+sANNMQBfNyw3WGvgZQ7w760oWytbcYlYzTXxQazmOooid4ypKD0viS4+myV4cMf+zVT8L//blFUPzhwMXbsPYEUbkqz1nE7A7eAXZRO9OE47z76o5P+4QocwAsCcmuxi25QaiF/edo/ZJAftSNQUB8CAPcGoJVDOZy4Wbuxk/cun7QGch5PzullRw78Ful/91tRSAD0BTMYtrtNHnGfxkdhfoebdFuf7SbUbbjyx6bwbmVMY0ghaR08DjEsIzoNJl0kf0F9kStNMG5K92aeatzYfYIIY8hdg0khW0f2vLVNNX3UkvaGQQePjIl1oyeg4eGSuMxa+WpYOwS1B0X3O3iz02bRsY+8mhD+kR18p8CiilQ1NotzeG/FQkHxgRJvTRuQLsZn44uhSEyflPfyLNiBCLMi+HxCR1hfpYUJYxpM9HDVF1oiqvYPlEfLpiRvo3j5JXHO2WYyqJHV0I5JX7cmW2uoY3M/fmXCNKfcdZGSKnkGoUrfsXMvGxqW7h668Ikq L8MkcLSM jj/RvMBUqPesApYSJ2tR+zz/dKsOyN66WVz1vSbgQ+/8XM+nHP61GUelM6ALJ+vbCmFxGViIBjx3KZSvqYRQSJrJWIM5rSR8VG6hR3bxWAoYoUxS33HU+rbfdSgXfOCzWBBWU/0op1X4CCmANUjB5ESVBn79qkv8RaMx91SrEiafzG9Toj2+T0sFOmjuN2nHrfIzPQi9IlMMVQH492sw6zrYg3McxmZkWp4WOeavMmam/c9KQP7XnYMQQV1PFOXSdJgk57CsHJSjlQGAA1g5ZZi1mpFshB0Xh7KuY9oMXLi0zeKZuK0BjrGnvM//t66jbmkrShxYtQ157C8axMlbM6tom0i4tL11BsdJEkjkZq5a/5fPr/yjZq5j/gxkP0/nsgHCVCftCdON2d0AKgto40mag/bmA9iM4YAH2t6P4I9QBJmfNBcRJeWP4EB4ZD4L9KabZAEP6NCik2vR1UbQd37zVS+Ciw+9M9eql3GaFjys8obaU2Wo/rywlEL4eYrYuL4K3yjbQQJVxUsleoQW8LhJSRpy5YHfcYQ01cBbFH85oIboc7P3xua4uyg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 2023-05-24 at 16:33 +0100, David Howells wrote: > Make the page_frag_cache allocator's alignment parameter a power of 2 > rather than a mask and give a warning if it isn't. >=20 > This means that it's consistent with {napi,netdec}_alloc_frag_align() and > allows __{napi,netdev}_alloc_frag_align() to be removed. >=20 This goes against the original intention of these functions. One of the reasons why this is being used is because when somebody enables something like 2K jumbo frames they don't necessarily want to have to allocate 4K SLABs. Instead they can just add a bit of overhead and get almost twice the utilization out of an order 3 page. The requirement should only be cache alignment, not power of 2 alignment. This isn't meant to be a slab allocator. We are just sectioning up pages to handle mixed workloads. In the case of networking we can end up getting everything from 60B packets, to 1514B in the standard cases. That was why we started sectioning up pages in the first place so putting a power of 2 requirement on it doens't fit our use case at all and is what we were trying to get away from with the SLAB allocators.