From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx146.postini.com [74.125.245.146]) by kanga.kvack.org (Postfix) with SMTP id 691516B0007 for ; Sun, 27 Jan 2013 21:07:55 -0500 (EST) Message-ID: <5105DD4B.9020901@cn.fujitsu.com> Date: Mon, 28 Jan 2013 10:07:07 +0800 From: Tang Chen MIME-Version: 1.0 Subject: Re: [PATCH 3/3] acpi, memory-hotplug: Support getting hotplug info from SRAT. References: <1359106929-3034-1-git-send-email-tangchen@cn.fujitsu.com> <1359106929-3034-4-git-send-email-tangchen@cn.fujitsu.com> <20130125171230.34c5a273.akpm@linux-foundation.org> <51033186.3000706@zytor.com> In-Reply-To: <51033186.3000706@zytor.com> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: owner-linux-mm@kvack.org List-ID: To: "H. Peter Anvin" Cc: Andrew Morton , jiang.liu@huawei.com, wujianguo@huawei.com, wency@cn.fujitsu.com, laijs@cn.fujitsu.com, linfeng@cn.fujitsu.com, yinghai@kernel.org, isimatu.yasuaki@jp.fujitsu.com, rob@landley.net, kosaki.motohiro@jp.fujitsu.com, minchan.kim@gmail.com, mgorman@suse.de, rientjes@google.com, guz.fnst@cn.fujitsu.com, rusty@rustcorp.com.au, lliubbo@gmail.com, jaegeuk.hanse@gmail.com, tony.luck@intel.com, glommer@parallels.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org On 01/26/2013 09:29 AM, H. Peter Anvin wrote: > On 01/25/2013 05:12 PM, Andrew Morton wrote: >> On Fri, 25 Jan 2013 17:42:09 +0800 >> Tang Chen wrote: >> >>> NOTE: Using this way will cause NUMA performance down because the whole node >>> will be set as ZONE_MOVABLE, and kernel cannot use memory on it. >>> If users don't want to lose NUMA performance, just don't use it. >> >> I agree with this, but it means that nobody will test any of your new code. >> >> To get improved testing coverage, can you think of any temporary >> testing-only patch which will cause testers to exercise the >> memory-hotplug changes? >> > > There is another problem: if ALL the nodes in the system support > hotpluggable memory, what happens? > Hi HPA, I think I missed this case. If all the memory is hotpluggable, and user specified movablemem_map=acpi, all the memory could be set as movable, and the kernel will fail to start. I will post a patch to fix it. How about always keep node0 unhotpluggable ? Thanks. :) -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org