From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACCE4E7718B for ; Mon, 30 Dec 2024 01:22:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 81BF56B0082; Sun, 29 Dec 2024 20:22:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7CC9F6B0083; Sun, 29 Dec 2024 20:22:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6BACB6B0085; Sun, 29 Dec 2024 20:22:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4D36C6B0082 for ; Sun, 29 Dec 2024 20:22:30 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id BECC2C0294 for ; Mon, 30 Dec 2024 01:22:29 +0000 (UTC) X-FDA: 82949873076.08.7C78CE4 Received: from invmail3.skhynix.com (exvmail3.hynix.com [166.125.252.90]) by imf11.hostedemail.com (Postfix) with ESMTP id C849040006 for ; Mon, 30 Dec 2024 01:21:44 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf11.hostedemail.com: domain of hyeonggon.yoo@sk.com designates 166.125.252.90 as permitted sender) smtp.mailfrom=hyeonggon.yoo@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735521727; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U5kTcV5IJaPrnZDlM2GIbVOU4rvUTVrtO4W8TjXsf0k=; b=NQXVPrkWptYSgQDat8w9bOuAV3yEi+fmrx4as2OQjev1yGmCVuNut1pyrr9+XVGji1yB8u U2KdjCWyIQ7ZJrx6ruXsi7eNWKZJJgBWgvAO1bID6OxhN0awRuq+FsG8FZ582fb4dij59e BjtDCM6vdoLBo1Q6clMSpCUI6rwH2M0= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf11.hostedemail.com: domain of hyeonggon.yoo@sk.com designates 166.125.252.90 as permitted sender) smtp.mailfrom=hyeonggon.yoo@sk.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735521727; a=rsa-sha256; cv=none; b=rzC71U4TzZRtxI7jAyuPS9eHLXhm/MfdPi/PlajkmkM216bQsidnUxuKESWFu7rXroEgii +kH6+CG0Uykrwn049NH/OSwggpz4q+tcZMiQCpDn3pHOzUH/zQm5ahX5tK6xyjfDUTCN8y 5DJeFLAnnNNx9x1YjsW6DmrCd8yFE+w= X-AuditID: a67dfc59-7a9ff700000194b3-d3-6771f5d0308a Message-ID: <50f2f968-df8f-4067-8e19-4d1e5b8cbbfb@sk.com> Date: Mon, 30 Dec 2024 10:22:24 +0900 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: kernel_team@skhynix.com, 42.hyeyoo@gmail.com, "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andi Kleen , Andrew Morton , Yunjeong Mun Subject: Re: [PATCH] mm/mempolicy: count MPOL_WEIGHTED_INTERLEAVE to "interleave_hit" To: Honggyu Kim , Gregory Price References: <20241227095737.645-1-honggyu.kim@sk.com> Content-Language: en-US From: Hyeonggon Yoo In-Reply-To: <20241227095737.645-1-honggyu.kim@sk.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrHLMWRmVeSWpSXmKPExsXC9ZZnke6Fr4XpBpO7dC0m9hhYHJ9gaTFn /Ro2i593j7NbXN41h83i3pr/rA5sHjtn3WX36G67zO6x6dMkdo8TM36zeMw7GejxeZNcAFsU l01Kak5mWWqRvl0CV0bjhNlsBbP4Kl7umcHYwPiIu4uRk0NCwERi+psDbDD2tGkzWLsYOTh4 BSwl1u8SAAmzCKhKbHh1lR3E5hUQlDg58wkLiC0qIC9x/9YMoDgXB7PAJCaJmUtXM4IkhAXC JW7O/gRmiwi4S1z495oZxBYSMJWY3bMObBezgLjErSfzmUB2sQloSezoTAUJcwqYSVz53MQK UWIm0bW1ixHClpfY/nYOM8guCYHLbBLNO58yQ9wsKXFwxQ2WCYyCs5DcNwvJillIZs1CMmsB I8sqRpHMvLLcxMwcY73i7IzKvMwKveT83E2MwFhYVvsncgfjtwvBhxgFOBiVeHgl2gvThVgT y4orcw8xSnAwK4nwnksqSBfiTUmsrEotyo8vKs1JLT7EKM3BoiTOa/StPEVIID2xJDU7NbUg tQgmy8TBKdXAmK7t+r+nSdQ2efG2H0GfPhRYv5vDsuHLN4Wzn31M0wQuBVuxfvM+M+WEpI+M VPrfCpea7qAHBnkFHLftAvTismXmXe23OBFYH1mWnNwa4ZYrtemExlOVVHvm5XbOi+wnn5ay X/wrfuPB1XfOsOpqFEsJizLcnr6ApzFEbYu575H7KRsZriQqsRRnJBpqMRcVJwIAbEtwzoEC AAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrILMWRmVeSWpSXmKPExsXCNUOnRPfC18J0gy0TVSwm9hhYHJ9gaTFn /Ro2i593j7NbfH72mtni8NyTrBaXd81hs7i35j+rxe9tK9gcOD12zrrL7tHddpndY9OnSewe J2b8ZvGYdzLQ49ttD4/FLz4weXzeJBfAEcVlk5Kak1mWWqRvl8CV0ThhNlvBLL6Kl3tmMDYw PuLuYuTkkBAwkZg2bQZrFyMHB6+ApcT6XQIgYRYBVYkNr66yg9i8AoISJ2c+YQGxRQXkJe7f mgEU5+JgFpjEJDFz6WpGkISwQLjEzdmfwGwRAXeJC/9eM4PYQgKmErN71rGB2MwC4hK3nsxn AtnFJqAlsaMzFSTMKWAmceVzEytEiZlE19YuRghbXmL72znMExj5ZiE5YxaSSbOQtMxC0rKA kWUVo0hmXlluYmaOmV5xdkZlXmaFXnJ+7iZGYMAvq/0zaQfjt8vuhxgFOBiVeHgl2gvThVgT y4orcw8xSnAwK4nwnksqSBfiTUmsrEotyo8vKs1JLT7EKM3BoiTO6xWemiAkkJ5YkpqdmlqQ WgSTZeLglGpgLJ+wLpHlwyq2laGnzuUYOzY8E85fYFty94kab82eqN/MkwsnaEia/Wq9cMu5 +usu5mkFlVcOhmi9udglr74mnTt3zVLm7ct2uXj4hKk8uXP4FpNrp8vSFYfXX316iomnPFOa SXFOiILQOvuWN+Ka3OwWtQ4Nk1m3pm1Zv9p4bbHfL372vx9fKbEUZyQaajEXFScCACLQjgh0 AgAA X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: C849040006 X-Stat-Signature: qug3iepowmycycxb944qyhwumc76tcb3 X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1735521704-640259 X-HE-Meta: U2FsdGVkX1+TYkl9rulBrPWD/8GsAuypuI3yJRV+h9aCtFnBL2KgfdMvg+mSksgBjNMGwObKDlp+e3BGqTFu/jXruk9ayxjeB1+skL+1IsFHByu6f7wjQeRrH4QHlPvMaSCJUr4Vx0Cr5X7kjmVljri02eSd9ZmUI+B5bRL9sx+LxyZ8B3kWBgEb/rI1Ch7ui0W35AcP+7hbRkB+3siww/5DpKC4kNwUvx05q+qYONmYr9gtcp3lGgHPG0HblknN6OjwpcDnKzdhyROTMOx/aG45DwG29awmov08P/+IhV1ED4r8ol66zHbrr51e16mpdxZQ6Kh6dgjr6ElmG6AbSd+OZ2nPAjj8XL6IIVcuawPoG5u49TcwakbzR1dnuDyn+kedRdsARBS6ymwr0nxiwzn5MTiiwVCj+rf7pthXkO7Dh1R1RxEtxOZ6ruKcDLWzVV5Zp9G7hGIyidEfWyPk6KTll7WnpHpbWE6582Z1Bybe3ONVaQRRSSl933XaM6AItYxzOCaej15nZtd8fHTHZDenBmYUZyUdcqV0ZwuC/wjx4mzFdEkmCtSPLBoei+zao5Gm7lMolPzYjYFhlHJf2mWsw+2W7QZWtBMRrmcRxosa+01KX6mFrb576ySo1fBRc9rBPge845hxX2bfC68uZpWNqzq5yBL1yAgzWf+SJ3eTzPa35bhhL57dWwIk3jyBo9pPar/VQf3Dy2QXjfq/fgQ+zX43r/zRMts75lKevDuLqH7FOnSZQ2QacSycpOlnzQcQJwoHPMtoxO7gk1hBlzR49dMnnV9eYLYcJeP/W7TA7/5Se9ENiLw0h2cP2O6eVOJHtmjohaXak2OEN58Jg/3tyLTZ+XrGRpd8VIMX48lqxTsoZzwrM15BMnf7fKMb8XIEzbybiEtMX7PVVSExvT4LYKCme+IUcJdN4Rs32O0rBC9t+7MKLtoK3IqRNsE9Rpdn4DU9mqJxgEm83iE S/w+f1Ge rEH3dx22xL9ErI+aTKRcy17g+5hDd6QF2pupcU6Ulk52aDhUWVUHJV44xFikpaOVx83zumtnIyofAiOzw9NoXVhjMcZeBUAzdpG38JZ72OxTqI0dpx1m5O3rRjbL6upFGTfPtytRbhNxSb+XPMnNVtAsA6zzgwvdr7LSWU2xgodU+fDc/5evcY8B1RDdAd3gzRKx1oTO/4B1Sv3Ieb9bOXuQmkIifx9oV7IpT5NVrLQu6VgJBjI/bLGpoY0aDazIuXZU5aUlh4fVOZfSh67ve9XAVig/4AvOJGzIgTe9uxSkwbqepuA1ohC1EmwTNdmIB88k6qt3bAD/1/PLtM81ZapRX9g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024-12-27 6:57 AM, Honggyu Kim wrote: > The fa3bea4e1f82 introduced MPOL_WEIGHTED_INTERLEAVE but it missed > adding its counter to "interleave_hit" of numastat, which is located at > /sys/devices/system/node/nodeN/ directory. > > It'd be better to add weighted interleving counter info to the existing > "interleave_hit" instead of introducing a new counter > "weighted_interleave_hit". > > Fixes: fa3bea4e1f82 ("mm/mempolicy: introduce MPOL_WEIGHTED_INTERLEAVE for weighted interleaving") > Cc: Gregory Price > Cc: Andi Kleen > Signed-off-by: Honggyu Kim > --- > mm/mempolicy.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > index 04f35659717a..162407fbf2bc 100644 > --- a/mm/mempolicy.c > +++ b/mm/mempolicy.c > @@ -2268,7 +2268,8 @@ struct page *alloc_pages_mpol_noprof(gfp_t gfp, unsigned int order, > > page = __alloc_pages_noprof(gfp, order, nid, nodemask); > > - if (unlikely(pol->mode == MPOL_INTERLEAVE) && page) { > + if (unlikely(pol->mode == MPOL_INTERLEAVE || > + pol->mode == MPOL_WEIGHTED_INTERLEAVE) && page) { > /* skip NUMA_INTERLEAVE_HIT update if numa stats is disabled */ > if (static_branch_likely(&vm_numa_stat_key) && > page_to_nid(page) == nid) { > > base-commit: 4bbf9020becbfd8fc2c3da790855b7042fad455b [+Cc Andrew] Looks good to me, Reviewed-by: Hyeonggon Yoo We discovered that interleave_hit is not correctly accounted while testing MPOL_WEIGHTED_INTERLEAVE on libnuma and this patch fixes the issue. Tested-by: Yunjeong Mun For reference: https://github.com/numactl/numactl/pull/238#issuecomment-2563532910 -- Hyeonggon