From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5FBDC5AD49 for ; Fri, 30 May 2025 20:09:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 30EC96B01F4; Fri, 30 May 2025 16:09:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 298376B01F5; Fri, 30 May 2025 16:09:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 160646B01F6; Fri, 30 May 2025 16:09:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E4B626B01F4 for ; Fri, 30 May 2025 16:09:09 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 864ECC1479 for ; Fri, 30 May 2025 20:09:09 +0000 (UTC) X-FDA: 83500663218.04.556F9D0 Received: from relay.hostedemail.com (unirelay10 [10.200.18.73]) by imf23.hostedemail.com (Postfix) with ESMTP id BBE7E140012 for ; Fri, 30 May 2025 20:09:06 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; arc=pass ("hostedemail.com:s=arc-20220608:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748635746; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UNgwVBGvhTf/t1as+uXbUDwJKi8ozSymY0URc8uI38I=; b=zi05o7USqKOfPGMopfDr5rJUP4Yd/0vd55THdETWEO5WHkRUFBwwyk+wrDCioMdvkvjLCk 4y88754mK5bntmUx4O4IWmzxc2HJ3iLBIpvCdhFOccFgXUrcIs4w93dR4oiyfvcSo0x4Lc YIJIH6IydmtgIyG+MCVa7Hb6mTI6GQM= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1748635746; a=rsa-sha256; cv=pass; b=7jdeIf0AJaeOkVgW4K5c9daG70N2Z6cDTdNHdJFoSd2hVySU4LHMK7vRwqATcpcYDBOvnP c2TFvWOEhOTwAV2qTyMDFtKpIMgJwxp+gRRzx9t/u3OF2tr8sp3T5jBQh3cwefM7ouGOgI uLA/HPLWfG09BMyW2AfZq1mDsqdFu18= ARC-Authentication-Results: i=2; imf23.hostedemail.com; arc=pass ("hostedemail.com:s=arc-20220608:i=1") Received: from relay.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 3EC29C1484 for ; Fri, 30 May 2025 20:09:06 +0000 (UTC) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 11A4D16155D for ; Fri, 30 May 2025 20:09:06 +0000 (UTC) X-FDA: 83500663092.09.0FD30B9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf11.hostedemail.com (Postfix) with ESMTP id A5E0D4000A for ; Fri, 30 May 2025 20:09:03 +0000 (UTC) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748635743; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UNgwVBGvhTf/t1as+uXbUDwJKi8ozSymY0URc8uI38I=; b=Ev1t7seHNFcFZ05idsvKIYQ/t4keKi6wlukxQ5ces5V+n3aMRv603TSx66Y5xyXN6PiCJ+ mzk0WmAJ0ph4pWrMT8CzUw3Qd5YkOnR21Vxw6+cyd5AA/yKn9919rbneOz+vquWiRFKP5m f+pey7UpSRdzwTODr2Hx9hDj5EAi0gM= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="C/gODcob"; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748635743; a=rsa-sha256; cv=none; b=g4SCoQBnVQpaMnGV3l4viNvSy7EIgJucZahkcI0KwGm6WgC0qjXa4XeynjaljKmucUyMl5 agV0iSNWg11cK6fr7KZ+FAY3w+mOlqMuccytgdiF8Aa839K5INm8ZPPD6twqGytv07Pn5a 5wfptrBgNHDn/NmBTJkAkBaW+qYo66A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748635743; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=UNgwVBGvhTf/t1as+uXbUDwJKi8ozSymY0URc8uI38I=; b=C/gODcob2+8uE9Ix/WCpRgqedzrYJRqIlJ8G8uwUUQoPMj2o0HFDJq7vg8JKDGejo407BL Gc+RiJ/F1rUbgkNUzmtjpqr6+ibhQQDWLG2WPCGoRXBzh4C4rKyUfCxPagjAsyp68e4ni5 fv3oUU8qz9t49+bTp4iQtV17K3GUlHg= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-513-Pm0yal6xMbyR5jFVzkxcnQ-1; Fri, 30 May 2025 16:09:01 -0400 X-MC-Unique: Pm0yal6xMbyR5jFVzkxcnQ-1 X-Mimecast-MFC-AGG-ID: Pm0yal6xMbyR5jFVzkxcnQ_1748635741 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43d5ca7c86aso14275875e9.0 for ; Fri, 30 May 2025 13:09:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748635741; x=1749240541; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=UNgwVBGvhTf/t1as+uXbUDwJKi8ozSymY0URc8uI38I=; b=qDqCmdrXYrkKAUcNx0sdJD3Ti5e5xCGXTuSAaFB/6IB9BXszCAFvW8A0k3o9Owario vRsPxvTnmdwn8wnHW9x+JT2CR1wgatcpsgTD7DsJb4s73jJiJDmyrW+K6e8cd2h28KJa g0bYDSDmF3FcreEEr+RRHmJ7R7CEXJTiwKShC2b7q9xL/HgcFEM/+H8mT00RD5LW/9mj YBMGOpmde51PjUP0/hf8k1bcGVzxrFdWQSqSpivWU/BSHyH1g6RRnlS6eVbE1gnpAzZ1 l5ckYElI9XRzBuH2Rsz8s69+EKwwauStqqYWko+YX6/tXDk4moumlkDlj92YPr4ti14i wZGA== X-Forwarded-Encrypted: i=1; AJvYcCXwyzOtNBphXSIZ8DKrQWtYRBCIy4MNWOBk0tT4fS3hg1j9O+JdaWgsrrZN6S4uh0J0w6qzXNJIow==@kvack.org X-Gm-Message-State: AOJu0YyrTlYCeNhOjwShd923EK9pfhKGSdcBoJgBSCINOmHp0yf0zgKK PvFROpmEJM9/jsISeF+e3QSg6VDCR+rVLd4+Mdw2i6IjyXHQj+qoF1gppQiaR7RelTM1j60zov2 9627iJh4K/ANINqp5sqRBM+lDfN0ASuiY8m2yKY79BMJDKw34kz4f X-Gm-Gg: ASbGncvtlfoNtBtmVwViH1Vj3K8kmIXGtMJ26H/BJ30n6LCYvCAboT7P+7PrfeeHKjS Q/mjmaSFfX/V9hJD3FFrbZyuXJxaivVLVQMF1vmHjbO3o/H7EWwn0Nx589kURGafL2OlxFrEZuS MaiwWmMAhik9fiVTo/TrqkYpIP44BANkdeH2I0EYKy/0fgJ6FRDbJydWtpMB+VxP2po9haLZ+ux CR6VJmwG2ZN3jbNoKYdDD7MaeY0SoV60F2qx0uvV+mNCehTayLj9Ei3pWg6ng3PwhZEhfFNQlX9 S5m4z6ca395WmjBaoQSYgoiqBvmgKv8NyoBpOT6O7NNXvbmzccJ/pttU5CogLhkRwHUTz+Br696 +qsLJEjVHQMrL16bhCqKerr6NUZSQF8nBOX0k5ho= X-Received: by 2002:a05:600c:1e21:b0:442:e0f9:394d with SMTP id 5b1f17b1804b1-450d65465efmr43396885e9.24.1748635740616; Fri, 30 May 2025 13:09:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFPIC56+epAhH3sOsNaWeTsssy3WgoSm87TSamFxQnmWRsIdoYSkQaQ2GhGbwps+BDqxzKhzQ== X-Received: by 2002:a05:600c:1e21:b0:442:e0f9:394d with SMTP id 5b1f17b1804b1-450d65465efmr43396675e9.24.1748635740113; Fri, 30 May 2025 13:09:00 -0700 (PDT) Received: from ?IPV6:2003:d8:2f03:5b00:f549:a879:b2d3:73ee? (p200300d82f035b00f549a879b2d373ee.dip0.t-ipconnect.de. [2003:d8:2f03:5b00:f549:a879:b2d3:73ee]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-450d7fb0997sm26479175e9.23.2025.05.30.13.08.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 May 2025 13:08:59 -0700 (PDT) Message-ID: <50da1626-5894-42ef-b3fd-935a331f14c4@redhat.com> Date: Fri, 30 May 2025 22:08:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 6/6] mm/page_isolation: remove migratetype parameter from more functions. To: Zi Yan Cc: Johannes Weiner , Vlastimil Babka , linux-mm@kvack.org, Andrew Morton , Oscar Salvador , Baolin Wang , "Kirill A . Shutemov" , Mel Gorman , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Richard Chang , linux-kernel@vger.kernel.org References: <20250530162227.715551-1-ziy@nvidia.com> <20250530162227.715551-7-ziy@nvidia.com> <8C1EFB3C-0F1C-46DE-878A-3546A86A141F@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <8C1EFB3C-0F1C-46DE-878A-3546A86A141F@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: vgsvOBShY5QBydYAtypNjZ7ZP9f-BK4HdmoZjkpqS_8_1748635741 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-HE-Meta: U2FsdGVkX1/vzIQxJfgJLxJtJefLWp1MP3zy4Ltnf9vOgcz2Z/1/d8FDmxpNYjHagmON1f8GA/KG6Pe2amf4WpH9ZVXJUVph7NJVCAQXOzQEthB3i8XlVZXEGJkV/YKvsuQ6GKQkctSzam+CvPm9gGn5wCHP1zC8FTas9TVbZDwRNiQ57/xs0PCWRECzjdlfz/wPdtx2Qc93/9OUAasJ6dO/sPzMwGy5AHzNqcesodN/daEYvE00QZJFJV13XnfUfQfSvQ0/Z9V8k/pvklCEhEvraWVUSssRbljF06ZsJGxk8OfptSWgzpVoxOTeP5V/+Y7Yd1wdNYvKzn9APHITrQ/C2QXQ9RNAXnfX4Wz4iAzASDAolb2/QZQLyOgU0fGwMUgtEZtLexN2opLSEvwi6MJe7jDlL/EmR3o32Zr6XiMHw5MJQWedB72bMZNTVX9L6Pv6ozEksGRJ71fCfXM/oTLjPSpnuy3yFGShvIpLD6Cmy1n0KOtpAKXNfleHvEnFxUiR1/67/nu+9lEJCfWUZZYaLOHHhh2ITd2RxPpTrpuyvrYDWadsm/BVFkUuYCgJIxgZAUUJP9hq8m1wLjaYQzBvqxhbgJOKJAlZbh0CuzBkjV+3oxYgjLyDX5N7dbqU/+/Wbi5/psd+a8WfXw+n21FK21zzphmZnhX15/3NULSr7GelIHlRUomWr5J2Oz8Yz7s4ItB2ygDiY2bTKggDYhe+7i1c/TjcMpF3Cn1erPOERlwXFfhDE8Wn18fdDdWx1gzV/jbG2iwHtTW6U6psp3wUrYIP95cCLQ0iwX8bd3YPVCzDo2qCO+phQ9X+qgpUYS120BVXKBirjyhXBqym/P6HO+QWNLD6q0XQWdZcOi9C+I1z61Wl8SzvPixRfeO9If6i83R7bDemplLXc0ScIIastJM/mdqLogu664PLBWU9H9AsXOGAlPUfKFBvwgNscTPhXhES9PheHj0YQL2 CZ6hYfHx gbBpskNeHu5UKg5XGoOtP+6Wst3YKQuImi9PZ2GGkcW5Rv7IJit2WEhQt3vw/DvV8ajglxJx4IlPoXQFpMI2XLu6+cqxSuVxXkrVGOdC3PzpIK+9uWyMOCVLvX7pTIkzEB3Y/6N/SYZ3dJ9xkHfBiUqvPRO7zJNOu93zvHqC63plybDF/s8k8CmNygyvqmXVswb8dFe/Rc3PS4qvmInq7oRwwLaOv2YpQ/WH/UQUJbOf3qoCuQnR3Zvqycdm6W3ZJBTA9O+O8H8wNMYwKava2C4qY5FROLuYUjh2BH7qOK674nOd5cR46g2GPkfDewMp2RLITHHH6DW+X+s/lmVYPULJxCi40vrGL3/dFhL13Qvl5YeI93pMDMLaj5qJvVEidX9+ulBByydgS1im0bAwEvvJsoZ/kqY0sPC9IfZ3QohsThiUXOf7p9vsQi4S/YMtvTDLVh5HS6LMbTuCSopyCiO6oPBPBkadApDgA X-HE-Tag-Orig: 1748635743-791785 X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: BBE7E140012 X-Stat-Signature: ud68s74pkuy7gz6kgcyku8rrmejtb9as X-Rspam-User: X-HE-Tag: 1748635746-69884 X-HE-Meta: U2FsdGVkX1+lU/QeSCwI+qzk5Jtxxtj5SAoBkLrTpGqWQEyL23Mu2GUIpm70AZwit1DTdjAhzzCjzqFiBhO1TktOspPDxRe2l/V1KaGsuUNV3C7FhNmuDw3GIUrX1tZmeg62Nt/9E6rwMzRzM28I9W76DUxI8T5n7QLFHs6+hzVxgTtZryGuFRj4GOMx9ARz4pCQjo4T3f1/FfAlwwWJQo5IVj/jiXgZWeuXd7wBU2a1MdKVVRdZnSpTZADLVsTCa6EE0/obNUvDf1u6j+Sf5QafrEpeLZYGKHlclqehGAthQbHrgz9ueXf6hLuIVVDXXHPjkkHgSQERivZwte2ujekQO1+psktiRITFDVCWezbQOwctkMnExLac2jOeKb0xrIvse19mCPsI/VIDmhqzMXZd0YGgpIIu5EACg/BbJlLrWe66mWkG3HVIQvosJTboJTVakvgWRHt6hgIDOdqO9VtOAJcIPnM+4kzIc6xKr332D2zYuOjKFuiBD6T2hJk2Vn6hTBd1qzWlZWb2QL39qpx1ou0naMG73E+9vSVQrk822Inyjpam+B0LzMiu8iriTabE90BsJ9gEXsYXR/F5MeBbCwCm1K/LDFB/Z8knKn1ht5mybU03hnYDv2Onz2fW/pdWVbbO2kMATiQXetXL/9p3mmWIACsoeXVfGZ5573FdgUGP4nOxvv8vvaY/menQUGUuHhRjEeuao1DqpYyVrO01meqWr/tunHLFJgwdrx7bA9AiSJj7F0kOuCJ6o8GtcZXxiI9O1qeDi/cbkv0YIO4AoF7FOMpjwUBmJSxFIKRVbxf3C1kyy2/bRnO4ma9XcOSBRL9TydRtGDFXc1lqvbvwIsD5d+qPtZOz6CwEEcSfHYAaKblOfpKu+6XMokQS4GlgQ5+VDRg/sNjupeQrrP0IZJm7VQE+i4p1dLpHoL8zuI4QFv7AdSUVnDqwe9VmVTO/Uo+2qenJzCBRuP+ 5L5WOre9 D74su76IQMy7EgZMvTFAn+6KwTfO9myuXzPD8evTSUJEJSJSEGYncKgM33jKyfywR+VYeja+ZYujpZXFMi3y9NzLuCpi/3CDT/GzoaXIjruqFoGdWJinNFvO9hzPRBlro2TDl3e1HhMme6vKXKTwfqntugRjJTYGuw2lvlfTOIiamhNb+YUXLiAmsYXFU7ZjXhynxsP5l9+Xm7cS+5BZGtLpxTVdevWSKPPZKxkPxI8Rb3h9aAW8vMQsNTcM4+xHkvC3sd+z0Z7GhzsYcdiZzoJYXmPKHIJQHzyVoFikcnwH0DaKVPL83nHTQtO51+FaVvbloRs4psbFQYjk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 30.05.25 21:58, Zi Yan wrote: > On 30 May 2025, at 15:56, David Hildenbrand wrote: > >> On 30.05.25 18:22, Zi Yan wrote: >>> migratetype is no longer overwritten during pageblock isolation, >>> start_isolate_page_range(), has_unmovable_pages(), and >>> set_migratetype_isolate() no longer need which migratetype to restore >>> during isolation failure. >>> >>> For has_unmoable_pages(), it needs to know if the isolation is for CMA >>> allocation, so adding CMA_ALLOCATION to provide the information. At the >>> same time change isolation flags to enum pb_isolate_mode >>> (PB_ISOLATE_MODE_MEM_OFFLINE, PB_ISOLATE_MODE_CMA_ALLOC, >>> PB_ISOLATE_MODE_OTHER). Remove REPORT_FAILURE and check >>> MEMORY_OFFLINE instead, since only PB_ISOLATE_MODE_MEM_OFFLINE reports >>> isolation failures. >>> >>> alloc_contig_range() no longer needs migratetype. Replace it with >>> enum acr_flags_t to tell if an allocation is for CMA. So does >>> __alloc_contig_migrate_range(). >>> >>> Signed-off-by: Zi Yan >>> --- >>> drivers/virtio/virtio_mem.c | 2 +- >>> include/linux/gfp.h | 9 ++++- >>> include/linux/page-isolation.h | 20 ++++++++-- >>> include/trace/events/kmem.h | 14 ++++--- >>> mm/cma.c | 2 +- >>> mm/memory_hotplug.c | 6 +-- >>> mm/page_alloc.c | 27 ++++++------- >>> mm/page_isolation.c | 70 +++++++++++++++------------------- >>> 8 files changed, 82 insertions(+), 68 deletions(-) >>> >>> diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c >>> index 56d0dbe62163..6bce70b139b2 100644 >>> --- a/drivers/virtio/virtio_mem.c >>> +++ b/drivers/virtio/virtio_mem.c >>> @@ -1243,7 +1243,7 @@ static int virtio_mem_fake_offline(struct virtio_mem *vm, unsigned long pfn, >>> if (atomic_read(&vm->config_changed)) >>> return -EAGAIN; >>> - rc = alloc_contig_range(pfn, pfn + nr_pages, MIGRATE_MOVABLE, >>> + rc = alloc_contig_range(pfn, pfn + nr_pages, ACR_OTHER, >>> GFP_KERNEL); >>> if (rc == -ENOMEM) >>> /* whoops, out of memory */ >>> diff --git a/include/linux/gfp.h b/include/linux/gfp.h >>> index be160e8d8bcb..51990d571e3e 100644 >>> --- a/include/linux/gfp.h >>> +++ b/include/linux/gfp.h >>> @@ -423,9 +423,16 @@ static inline bool gfp_compaction_allowed(gfp_t gfp_mask) >>> extern gfp_t vma_thp_gfp_mask(struct vm_area_struct *vma); >>> #ifdef CONFIG_CONTIG_ALLOC >>> + >>> +enum acr_flags_t { >>> + ACR_CMA, // CMA allocation >>> + ACR_OTHER, // other allocation >>> +}; >> >> Hm, enum != flags. >> >> If you want to use flags, then just have ACR_CMA. ACR_OTHER is implied if not set. >> >> And ACR_CMA would then have to be "1" etc. > > I have a fixup to change acr_flags_t to acr_mode. > >> >>> + >>> /* The below functions must be run on a range from a single zone. */ >>> extern int alloc_contig_range_noprof(unsigned long start, unsigned long end, >>> - unsigned migratetype, gfp_t gfp_mask); >>> + enum acr_flags_t alloc_flags, >>> + gfp_t gfp_mask); >>> #define alloc_contig_range(...) alloc_hooks(alloc_contig_range_noprof(__VA_ARGS__)) >>> extern struct page *alloc_contig_pages_noprof(unsigned long nr_pages, gfp_t gfp_mask, >>> diff --git a/include/linux/page-isolation.h b/include/linux/page-isolation.h >>> index 7a681a49e73c..3e2f960e166c 100644 >>> --- a/include/linux/page-isolation.h >>> +++ b/include/linux/page-isolation.h >>> @@ -38,8 +38,20 @@ static inline void set_pageblock_isolate(struct page *page) >>> } >>> #endif >>> -#define MEMORY_OFFLINE 0x1 >>> -#define REPORT_FAILURE 0x2 >>> +/* >>> + * Pageblock isolation modes: >>> + * PB_ISOLATE_MODE_MEM_OFFLINE - isolate to offline (!allocate) memory >>> + * e.g., skip over PageHWPoison() pages and >>> + * PageOffline() pages. Unmovable pages will be >>> + * reported in this mode. >>> + * PB_ISOLATE_MODE_CMA_ALLOC - isolate for CMA allocations >>> + * PB_ISOLATE_MODE_OTHER - isolate for other purposes >>> + */ >>> +enum pb_isolate_mode { >>> + PB_ISOLATE_MODE_MEM_OFFLINE, >>> + PB_ISOLATE_MODE_CMA_ALLOC, >>> + PB_ISOLATE_MODE_OTHER, >>> +}; >> >> It's late on friady, but it looks like we are duplicating things here. >> >> Let me think about that once my brain is recharged :) > > Sure. Take your time. Could we abstract both settings and use a single one? Then, we could simply reject if MEM_OFFLINE is passed into alloc_contig_range(). alloc_contig_pages and page isolation, hmmmm, MEM_OFFLINE is kind-of an allocation. CMA is an allocation. Just an idea, not sure ... -- Cheers, David / dhildenb