From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E662EC77B7C for ; Tue, 24 Jun 2025 16:41:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8244A8D0001; Tue, 24 Jun 2025 12:41:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7D5136B00AF; Tue, 24 Jun 2025 12:41:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6EA988D0001; Tue, 24 Jun 2025 12:41:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 525066B00AE for ; Tue, 24 Jun 2025 12:41:34 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id EADEF5D210 for ; Tue, 24 Jun 2025 16:41:33 +0000 (UTC) X-FDA: 83590860066.08.D089236 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf30.hostedemail.com (Postfix) with ESMTP id 900F680010 for ; Tue, 24 Jun 2025 16:41:31 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="XY0sX/Lq"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=0zvWTsG9; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="XY0sX/Lq"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=0zvWTsG9; spf=pass (imf30.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750783291; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rOxFyGGxyrhLelMzeWJRkz/5Ww35ZM+RSq38op+klpY=; b=iHvbbmjYzxA9ryJoPF/Zuyxgibgs81KYtVmbK9bDJjBhnPiHedJdVkk0VXbHa2c9jF/192 bMVCzQUro1igKPZVnzHbqdpUeOiLZ+dMw04e862QjvQUT00ReOjX0iFz7Sao1yJOwnIoyF D7ipSNkHl9+q+5NvuwkBNg4RP99u1k8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750783291; a=rsa-sha256; cv=none; b=wGrbq+zMGx4USb7KEH94jVe+jChE0gsxP7xNoIPUUY9zv3b/FDFM01n2TCuDRzw7Fqwxrr mdYUIsVHyCpuaC7NSUhtbNVqo4IPruySiUhi8YMy9UboO6F6AjmxBIOS58HFS935tNSfON XiUbu8jCpmUTP8HU8xr/em+L0TzLOkE= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="XY0sX/Lq"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=0zvWTsG9; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="XY0sX/Lq"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=0zvWTsG9; spf=pass (imf30.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 429562127A; Tue, 24 Jun 2025 16:41:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1750783290; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=rOxFyGGxyrhLelMzeWJRkz/5Ww35ZM+RSq38op+klpY=; b=XY0sX/LqI9ZkXl19Binw6YkEJNWmGhhwoCp8Mcd/KVJFyHBV8RVS3nEXGF1Uu9d9BE7hVR NbFbCUsfHn9645Om+IubEpOwUmNKJA83gpLCQaWEQH+T5fl2KfUIYEAb/Dv/4pZaq63wTn nrQ8yPhcUFWqEBEUvcaIGwsTL2gwUo8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1750783290; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=rOxFyGGxyrhLelMzeWJRkz/5Ww35ZM+RSq38op+klpY=; b=0zvWTsG9S3jCf+E2LkAoQDxr5bgVYVu/p34EOMRiLFBufLQBiSSbIj0D6zzW6YjhXGs4EF P2Cw2fFmlUHx5sAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1750783290; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=rOxFyGGxyrhLelMzeWJRkz/5Ww35ZM+RSq38op+klpY=; b=XY0sX/LqI9ZkXl19Binw6YkEJNWmGhhwoCp8Mcd/KVJFyHBV8RVS3nEXGF1Uu9d9BE7hVR NbFbCUsfHn9645Om+IubEpOwUmNKJA83gpLCQaWEQH+T5fl2KfUIYEAb/Dv/4pZaq63wTn nrQ8yPhcUFWqEBEUvcaIGwsTL2gwUo8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1750783290; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=rOxFyGGxyrhLelMzeWJRkz/5Ww35ZM+RSq38op+klpY=; b=0zvWTsG9S3jCf+E2LkAoQDxr5bgVYVu/p34EOMRiLFBufLQBiSSbIj0D6zzW6YjhXGs4EF P2Cw2fFmlUHx5sAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 2A1D513A24; Tue, 24 Jun 2025 16:41:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id gz13CTrVWmjxIgAAD6G6ig (envelope-from ); Tue, 24 Jun 2025 16:41:30 +0000 Message-ID: <50d38e67-8246-41c6-82f2-c5e3892d8767@suse.cz> Date: Tue, 24 Jun 2025 18:41:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/4] mm, madvise: simplify anon_name handling Content-Language: en-US To: Suren Baghdasaryan , David Hildenbrand Cc: Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Jann Horn , Mike Rapoport , Michal Hocko , Colin Cross , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250624-anon_name_cleanup-v2-0-600075462a11@suse.cz> <20250624-anon_name_cleanup-v2-1-600075462a11@suse.cz> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJnyBr8BQka0IFQAAoJECJPp+fMgqZkqmMQ AIbGN95ptUMUvo6aAdhxaOCHXp1DfIBuIOK/zpx8ylY4pOwu3GRe4dQ8u4XS9gaZ96Gj4bC+ jwWcSmn+TjtKW3rH1dRKopvC07tSJIGGVyw7ieV/5cbFffA8NL0ILowzVg8w1ipnz1VTkWDr 2zcfslxJsJ6vhXw5/npcY0ldeC1E8f6UUoa4eyoskd70vO0wOAoGd02ZkJoox3F5ODM0kjHu Y97VLOa3GG66lh+ZEelVZEujHfKceCw9G3PMvEzyLFbXvSOigZQMdKzQ8D/OChwqig8wFBmV QCPS4yDdmZP3oeDHRjJ9jvMUKoYODiNKsl2F+xXwyRM2qoKRqFlhCn4usVd1+wmv9iLV8nPs 2Db1ZIa49fJet3Sk3PN4bV1rAPuWvtbuTBN39Q/6MgkLTYHb84HyFKw14Rqe5YorrBLbF3rl M51Dpf6Egu1yTJDHCTEwePWug4XI11FT8lK0LNnHNpbhTCYRjX73iWOnFraJNcURld1jL1nV r/LRD+/e2gNtSTPK0Qkon6HcOBZnxRoqtazTU6YQRmGlT0v+rukj/cn5sToYibWLn+RoV1CE Qj6tApOiHBkpEsCzHGu+iDQ1WT0Idtdynst738f/uCeCMkdRu4WMZjteQaqvARFwCy3P/jpK uvzMtves5HvZw33ZwOtMCgbpce00DaET4y/UzsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZ8gcVAUJFhTonwAKCRAiT6fnzIKmZLY8D/9uo3Ut9yi2YCuASWxr7QQZ lJCViArjymbxYB5NdOeC50/0gnhK4pgdHlE2MdwF6o34x7TPFGpjNFvycZqccSQPJ/gibwNA zx3q9vJT4Vw+YbiyS53iSBLXMweeVV1Jd9IjAoL+EqB0cbxoFXvnjkvP1foiiF5r73jCd4PR rD+GoX5BZ7AZmFYmuJYBm28STM2NA6LhT0X+2su16f/HtummENKcMwom0hNu3MBNPUOrujtW khQrWcJNAAsy4yMoJ2Lw51T/5X5Hc7jQ9da9fyqu+phqlVtn70qpPvgWy4HRhr25fCAEXZDp xG4RNmTm+pqorHOqhBkI7wA7P/nyPo7ZEc3L+ZkQ37u0nlOyrjbNUniPGxPxv1imVq8IyycG AN5FaFxtiELK22gvudghLJaDiRBhn8/AhXc642/Z/yIpizE2xG4KU4AXzb6C+o7LX/WmmsWP Ly6jamSg6tvrdo4/e87lUedEqCtrp2o1xpn5zongf6cQkaLZKQcBQnPmgHO5OG8+50u88D9I rywqgzTUhHFKKF6/9L/lYtrNcHU8Z6Y4Ju/MLUiNYkmtrGIMnkjKCiRqlRrZE/v5YFHbayRD dJKXobXTtCBYpLJM4ZYRpGZXne/FAtWNe4KbNJJqxMvrTOrnIatPj8NhBVI0RSJRsbilh6TE m6M14QORSWTLRg== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 900F680010 X-Stat-Signature: ek4zjnto1g88yta8txpfpqj76uxdtema X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1750783291-11514 X-HE-Meta: U2FsdGVkX19wffB9ytDeymmc152F58lspjnvbnEAMbU6cBOQkVtOAQvcKd6ri45i29yvLJZldnRpzIBYFurQ/wXzuKcU3JwAqsXb9ZgxwM7xusNBHWM84D32Xwl7dGDD3KS0IjVD5DTgL6pW50ah7+ad42DHxdymCPvuzUOh8NBmqq+P2rQaIevX+Q4/A0D3OIEC1VvHCzx5GZF5hiDk2dVJvuH2/W+lgzULqQIvwiM7vs3prgRfNFzp3owEncRwpg+86Vg9EJppk6tYgzgyxlvJmS3b6Ap5aboTs4d+0mhQ7L/zEkKFcatEBAK6/aV6OOU7946u+FRmvfW80GyYtMlkg+EV89gdLiUmUZLfHQu1eJNSFgx7yBoe9r5Q8F13U6t+eQxqbnxXXSH7pPHg71TAwTesIzuUwP0GjThUQ8vdPj8dIcFqmCE312gRsbJwndqjkOPSNDagCMD2LU5QIVjEDtg4fGcNbdfzf92GE+zLp3CwWd8GE9vmjST+F13bqL9cxzJwgSM03/weMFLyHJIuV2+S0ipg2VG1ivb+lbKuSIiaYvlqrrma3vgo5CuPGCoaGJ4aYlXA8CA60GlkW3JwzQUgexZTo0kHlkiBfLPxtURHbfLwJ621KfjGucflU1kSmTbBuM2F/iS5ALtcMAdB63rwoUJfXpiZQ/sUhrR+EGK95r0WhrI8tB8kRZQreP1vbL+//04XxMovP/9wryBT2X6pqmp695F74/SjsmXnx+7CYp3OAQZklFRvTRtqOyeoUB+BrT9HUGbNOih8jjUJNAsKh1x1dGH4ZnbvzP32GfCjK76FyjIWX1wt3TPn2VvRVKV7qKuEPVUIfLvg1GXSzXzFjo9Gw7fnQoN8oZi7DCvlr9nnp8bvirspAvxY4nqn6UgAYnGm1HbxupLzuKKCnEGegOR0g0ZD0zcad4Oqu3DAbkCWNGjIXJZ9Vu7kVuRiVIeoBPzAYShgaeZ 4tRYlNYi mfaid3MyAibpLeezCnMfq+u1rbBUXZG+YImt++EnKFKqUIs/sjxNmUcxm5Y6FF+7BtZKTjy0si3zp2Zy2sIr0eDXo+/6IiEvXkenRWOqaKsFQ0AfZqDocIN0drWC+tKC5n8rPf+5RxSAFb7OYZYAmCXaKBus9CtwPrTibzO01Qq7uYBCNS21UCuS9O6NiJhT2tVw4/+eCnvsB58Huc428gkJkXCjwx+GPzAMhXAjxlks/gaGrmzHwx3Ch0PEJSNl+4JssDrb7Cp247jWW9PEF5b2PlCkI1QwgwDvlt2Wrotkb2SfOv2Ib/QHJRGU+br7FdE9GWr0fX4IAl6YQ4r4JYCytYV2xyTEmZMeKaxttr3ZUNEiMgaoi1f/HQA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/24/25 16:28, Suren Baghdasaryan wrote: > On Tue, Jun 24, 2025 at 6:58 AM David Hildenbrand wrote: >> >> On 24.06.25 15:03, Vlastimil Babka wrote: >> > Since the introduction in 9a10064f5625 ("mm: add a field to store names >> > for private anonymous memory") the code to set anon_name on a vma has >> > been using madvise_update_vma() to call replace_anon_vma_name(). Since >> > the former is called also by a number of other madvise behaviours that >> > do not set a new anon_name, they have been passing the existing >> > anon_name of the vma to make replace_vma_anon_name() a no-op. > > s/replace_vma_anon_name/replace_anon_vma_name Hm right, thanks. The problem is that it was indeed originally called replace_vma_anon_name() (later renamed) and I was copy/pasting while looking at commit 9a10064f5625... will send a fixed up changelog in a reply to patch 1/4. >> >> Acked-by: David Hildenbrand > > Reviewed-by: Suren Baghdasaryan Thanks! >> >> -- >> Cheers, >> >> David / dhildenb >>