From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 152C0C19F32 for ; Thu, 27 Feb 2025 14:39:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7BA3C280002; Thu, 27 Feb 2025 09:39:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 74382280001; Thu, 27 Feb 2025 09:39:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 596D9280002; Thu, 27 Feb 2025 09:39:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 32B6B280001 for ; Thu, 27 Feb 2025 09:39:03 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D25A3AF1BF for ; Thu, 27 Feb 2025 14:39:02 +0000 (UTC) X-FDA: 83165981724.02.44243C1 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf25.hostedemail.com (Postfix) with ESMTP id 68E9AA0013 for ; Thu, 27 Feb 2025 14:39:00 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=u523WwmH; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=bjOhYbh9; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=u523WwmH; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=bjOhYbh9; spf=pass (imf25.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740667140; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5x4jy6t17hcLvzjI8SgZJDgjCK5nQB09GOUL3aUeAjI=; b=A2o8rekh/f6FjkeNphEFr0CB07XiLKAU3afrbfXXOpLWRxPkGyFaQXBt6HdJmGNJxj7HRO gdGtWt1zTcAXy0MvTc0bF3uK2hxNuAKWWlJB66gWi3DG0z1SZG5/OjKRjfkN8VavApnFxt w4Qh8AmsRWZDADjHHQRetk/0Uk5Yc2c= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=u523WwmH; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=bjOhYbh9; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=u523WwmH; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=bjOhYbh9; spf=pass (imf25.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740667140; a=rsa-sha256; cv=none; b=IeqzAfpF63iPyBvJZLvq7Z4rs3gAsvvBZcQ0JRU8m/np12GEU4xzneqcuJAbepGshXc+wq UjFgw0z8zf8jYuMJIpxjfVn5fH/IOUiixeQmZR9rd4DNIevam3tc+/KTg1nB9hGllRAru9 3n23vwvbKHCLf35EsfJoQrJiviROii0= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 681022118B; Thu, 27 Feb 2025 14:38:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1740667128; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=5x4jy6t17hcLvzjI8SgZJDgjCK5nQB09GOUL3aUeAjI=; b=u523WwmHMZ6kKdnsm1VUSMMNF8qmHp9oQH+/uDjRpSPqvL36Q0NZxfwQTfGyTXI6Ey4qMW RGux5NivHT3wq0Rr5kLJRpCRn6ayW6Jbb22sJauKK72iuZl5lD7lqUj7oIXnD+3SpwEUTi 8TaUKR24w0Ji59Ven+4OjK2UKANX3uc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1740667128; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=5x4jy6t17hcLvzjI8SgZJDgjCK5nQB09GOUL3aUeAjI=; b=bjOhYbh92IKRXZ4V38mC90ymS7JIdiu8CkZut6SOtxLWksL3G4SC7VE7cDaQrVDykgZMlN jfezwuEj+YtQZOBQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1740667128; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=5x4jy6t17hcLvzjI8SgZJDgjCK5nQB09GOUL3aUeAjI=; b=u523WwmHMZ6kKdnsm1VUSMMNF8qmHp9oQH+/uDjRpSPqvL36Q0NZxfwQTfGyTXI6Ey4qMW RGux5NivHT3wq0Rr5kLJRpCRn6ayW6Jbb22sJauKK72iuZl5lD7lqUj7oIXnD+3SpwEUTi 8TaUKR24w0Ji59Ven+4OjK2UKANX3uc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1740667128; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=5x4jy6t17hcLvzjI8SgZJDgjCK5nQB09GOUL3aUeAjI=; b=bjOhYbh92IKRXZ4V38mC90ymS7JIdiu8CkZut6SOtxLWksL3G4SC7VE7cDaQrVDykgZMlN jfezwuEj+YtQZOBQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4C15A13888; Thu, 27 Feb 2025 14:38:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id UMeQEfh4wGcleQAAD6G6ig (envelope-from ); Thu, 27 Feb 2025 14:38:48 +0000 Message-ID: <50cb2f6c-f1cd-4aac-9336-e2c88f6314bf@suse.cz> Date: Thu, 27 Feb 2025 15:38:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/2] mm: slub: call WARN() when the slab detect an error Content-Language: en-US To: Hyesoo Yu Cc: janghyuck.kim@samsung.com, harry.yoo@oracle.com, Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250226081206.680495-1-hyesoo.yu@samsung.com> <20250226081206.680495-3-hyesoo.yu@samsung.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20250226081206.680495-3-hyesoo.yu@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspam-User: X-Stat-Signature: w3bch77cqykzbpsa9iytt8eonskh54mc X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 68E9AA0013 X-HE-Tag: 1740667140-351516 X-HE-Meta: U2FsdGVkX19J9q7oVpAa+RN5xc0rnsOgr4eHPYhgY32fJ0EHgwl1QtgO9FFY6383g/UmRZRvVyNlSPaSOQ7KpX9dTOqA/ESsyTzyuAELaxN8F3jSpa+fjL4A8aJdHjHrS/zi4g0ed6rDrNb9IshDKVMe069dtCCK9d6PNi9MTgLVRlDrUBFLsAuAIRuvY7+t8MfJ+D7f07Rd0AgHowwXIZ9Xc0HJMLyrGjVzqxRdnf5jNLc2gLeU5LvTVNYZiKYSmr0ERu5K/0N0zi+oRCr3keZeDnuP542BVt8KXsBcIPElbd5hT6km+IhUqwCbJON/oo3wNtkKSrXqbKQgRGZhzTxt3wfc8/90qvG3Xl6snGGll8+PZ5djegaJskFW87clLQuiUhRwqSISl5vHNYixbSkb5GBQjn+syzBqVo9rBPQT7UxIVC5umXDd4W00qoKS5BaUrQIR1PWh4TcfkEuzkjqAkYS3nTfjxXR7O8c3w2WRVSyEepZLTRlxztOYAD9ibWocHUzjLfzKCqiMkprKN3JCsDmxEngphjGT0q+25tyLDSIceVUpNEJIh2Rnrhla57Xp08cLfonzc1UyN4GgBxtKGUo2XF+8m6obo2tz/GA5h7hBChd8gSBarazUupHzq9xHcArLtzL0WIW6JsbRAcPKyJW7/eMAT9LFdvGbvTJroCoXOPUenanN1KSxjUku1mitnpGcNEc/hIZQLDU2tLGyzHAtxTLlxO/lraAXMQYDASUrgjId64/CMm6ERAry8tN12ipE7CLEncH7xb+34VJE/84DYW3HjrVE1rXtK7kkKRA6Awx6R8xs7FO/DaNxiw/Ng2EtprEv7I9pDgDyYNMPOxJpl1xaRTiTIKLW3ZvILupoj/Fspda0x6Q0j2j17vEc6NL+71FWLZXtEs7hpz4NNoKGx6NR2SbJjl1AGkTs3h6jCuttPSdmiYOEU2IanqTuHhsmf3cTm+HX0Tl FumqnOiM potc0GzmYTXmhpoF+st6DhFRgoPCM0TLwpDzHz1FhMCv3NWdEIqJG/pdz4pWNP942irkDY6zgRRcgTMEXzKVQDyymjzVErXG9RL/v2OBSVFkpMAheVBpZ7L/wLzVElLzPvr7cuI/Eri3h+cmiMsr8gFkqjNXYG0Hv6HEtHfrjgFsxrBE20omc/60mQ33MMEvNj5Lmi/hQjKsNQsClDiyv5HSAEKxKR/OLDYwVFBOxrRzJTr2q32Q/DRw6fQ8tJdfxfuB5aDEvzpUp1LuVZw/7pX+QTcappf8iMr22oguZi3T8QopK1SDcF9+edwh7ElszEsmM7DXE1bg9jgCJaDDzLRUZLqSvEbITvsJR5EfqQJw3uUYVdtg59E7g4yq/YshFJqL/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/26/25 09:12, Hyesoo Yu wrote: > If a slab object is corrupted or an error occurs in its internal > value, continuing after restoration may cause other side effects. > At this point, it is difficult to debug because the problem occurred > in the past. It is useful to use WARN() to catch errors at the point > of issue because WARN() could trigger panic for system debugging when > panic_on_warn is enabled. WARN() is added where to detect the error > on slab_err and object_err. > > It makes sense to only do the WARN() after printing the logs. slab_err > is splited to __slab_err that calls the WARN() and it is called after > printing logs. > > Changes in v4: > - Remove WARN() in kmem_cache_destroy to remove redundant warning. > > Changes in v3: > - move the WARN from slab_fix to slab_err, object_err and check_obj to > use WARN on all error reporting paths. > > Changes in v2: > - Replace direct calling with BUG_ON with the use of WARN in slab_fix. > > Signed-off-by: Hyesoo Yu As Harry said. I'll remove that locally. > --- > mm/slab_common.c | 3 --- > mm/slub.c | 31 +++++++++++++++++++------------ > 2 files changed, 19 insertions(+), 15 deletions(-) > > diff --git a/mm/slab_common.c b/mm/slab_common.c > index 477fa471da18..d13f4ffe252b 100644 > --- a/mm/slab_common.c > +++ b/mm/slab_common.c > @@ -517,9 +517,6 @@ void kmem_cache_destroy(struct kmem_cache *s) > kasan_cache_shutdown(s); > > err = __kmem_cache_shutdown(s); > - if (!slab_in_kunit_test()) > - WARN(err, "%s %s: Slab cache still has objects when called from %pS", > - __func__, s->name, (void *)_RET_IP_); I think I'll keep this one, because the more detailed warning via list_slab_objects() is only enabled with CONFIG_SLUB_DEBUG. If it's not enabled, the kmem_cache_destroy() failure rather should not be silent. So slab_in_kunit_test() would also stay. > } else { > - list_slab_objects(s, slab, > - "Objects remaining in %s on __kmem_cache_shutdown()"); > + list_slab_objects(s, slab); I tried to extract slab_bug() and __slab_err() from list_slab_objects() but they were also only available with CONFIG_SLUB_DEBUG. Perhaps we can improve that, but as a follow-up cleanup so we don't hold this up further. > } > } > spin_unlock_irq(&n->list_lock);