From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 778F8C433EF for ; Mon, 20 Sep 2021 22:13:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E85C460F56 for ; Mon, 20 Sep 2021 22:13:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E85C460F56 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=acm.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 7B9B3900002; Mon, 20 Sep 2021 18:13:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 742916B0074; Mon, 20 Sep 2021 18:13:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 60A31900002; Mon, 20 Sep 2021 18:13:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0074.hostedemail.com [216.40.44.74]) by kanga.kvack.org (Postfix) with ESMTP id 4A8296B0073 for ; Mon, 20 Sep 2021 18:13:20 -0400 (EDT) Received: from smtpin34.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id F261D2D007 for ; Mon, 20 Sep 2021 22:13:19 +0000 (UTC) X-FDA: 78609353718.34.F8ADCFD Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by imf22.hostedemail.com (Postfix) with ESMTP id B5DEB190D for ; Mon, 20 Sep 2021 22:13:19 +0000 (UTC) Received: by mail-pj1-f41.google.com with SMTP id mv7-20020a17090b198700b0019c843e7233so1030919pjb.4 for ; Mon, 20 Sep 2021 15:13:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=GNcH9n1n6985jmTpRW3zCpGYBALobjv8f2quy1A5vSE=; b=VzjUes5ykHq2ZOMEkzpaoe7lWbwDkg8z6QGveaWb3lJRqMKRNSQhYQ4u4aJoe2+0DT rm8K6/pgLy/bM9Zwj0KlFJyWpqMYKVgB4fP9K+tPdGA8mytTM7O8n6hryiqmFRh38AQ0 8S4HK5dF0KolRyvXrW6c84Xa811vsqJFFFWWORgg+S2ZB6yVbwuZ9lhkRFPfqQYML8MD 0WWKHGOTU7ym+Ts0ZQE/i9A5ZsctMYY7LEMe7NdbmFAhD2qSDhbuwsTiVQ3KoeVmLDHa dvx1xaSH9IIR9+FlcjmGk5z/cbGNEbbxeVQvk8OV3njkdlmYmwMNaVp7g80aC3diC6f4 TgIA== X-Gm-Message-State: AOAM5336H0VbjgjVDTk7eAQSrMO76ra6B+/TfAJeW8YhD0daiQfJrQH/ 81LfOv+RsddW62VzUOcuPLS6RDFNuVLchg== X-Google-Smtp-Source: ABdhPJyBCSHvnuuMXNRi79UlwIKwDOKjiVEtUvRASHqIyGImGgZFQd9QJ9f/FzQ//pT+lnADw0tqsA== X-Received: by 2002:a17:90a:428e:: with SMTP id p14mr1365262pjg.229.1632175998091; Mon, 20 Sep 2021 15:13:18 -0700 (PDT) Received: from bvanassche-linux.mtv.corp.google.com ([2620:15c:211:201:6e2a:d64:7d9d:bd4a]) by smtp.gmail.com with ESMTPSA id q18sm2278262pfh.170.2021.09.20.15.13.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Sep 2021 15:13:17 -0700 (PDT) Subject: Re: [PATCH 01/17] mm: don't include in To: Christoph Hellwig , axboe@kernel.dk Cc: linux-block@vger.kernel.org, linux-mm@kvack.org References: <20210920123328.1399408-1-hch@lst.de> <20210920123328.1399408-2-hch@lst.de> From: Bart Van Assche Message-ID: <50b75915-b61f-d3aa-b8ab-bd790adc04af@acm.org> Date: Mon, 20 Sep 2021 15:13:15 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210920123328.1399408-2-hch@lst.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: B5DEB190D X-Stat-Signature: 3oiyx4fbi7yy6hogwodnnoiya6syqjnz Authentication-Results: imf22.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf22.hostedemail.com: domain of bart.vanassche@gmail.com designates 209.85.216.41 as permitted sender) smtp.mailfrom=bart.vanassche@gmail.com X-HE-Tag: 1632175999-144336 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/20/21 5:33 AM, Christoph Hellwig wrote: > -static inline struct cgroup_subsys_state * > -wbc_blkcg_css(struct writeback_control *wbc) > -{ > #ifdef CONFIG_CGROUP_WRITEBACK > - if (wbc->wb) > - return wbc->wb->blkcg_css; > -#endif > - return blkcg_root_css; > -} > +#define wbc_blkcg_css(wbc) \ > + ((wbc)->wb ? (wbc)->wb->blkcg_css : blkcg_root_css) > +#else > +#define wbc_blkcg_css(wbc) (blkcg_root_css) > +#endif /* CONFIG_CGROUP_WRITEBACK */ This change may introduce annoying set-but-not-used warnings with CONFIG_CGROUP_WRITEBACK=n. How about changing (blkcg_root_css) into ((wbc), blkcg_root_css) to prevent this? Thanks, Bart.