From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64875C3DA4A for ; Wed, 14 Aug 2024 14:53:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B52C46B0085; Wed, 14 Aug 2024 10:53:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B03766B0088; Wed, 14 Aug 2024 10:53:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 907A46B0089; Wed, 14 Aug 2024 10:53:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 67E826B0085 for ; Wed, 14 Aug 2024 10:53:30 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 34DA8A833D for ; Wed, 14 Aug 2024 14:53:30 +0000 (UTC) X-FDA: 82451144580.13.0234C12 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2075.outbound.protection.outlook.com [40.107.220.75]) by imf23.hostedemail.com (Postfix) with ESMTP id 4CCF714000B for ; Wed, 14 Aug 2024 14:53:27 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b="a9yDS/MZ"; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf23.hostedemail.com: domain of ziy@nvidia.com designates 40.107.220.75 as permitted sender) smtp.mailfrom=ziy@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723647135; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KDUrEUEI+m4wroW5TDUeRH5qgH9WJs8Q7cazAEddcnU=; b=SfTmyZh++wmIDjLs5E3cwQ9kzlX2P2VOa1vxg5k8wV4ZVEmoGxWqyGN/uMCn35g34B3WHB A/r6Uot/jRlJ/XRX1Bb+N8PL7VCwfGHgROuU/9Z4q20SrgVnj4FNJWbmZPQ8+RFDuXHHIZ c9yS1JtJQAgnTGlbppQz837GD2BaoQ8= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1723647135; a=rsa-sha256; cv=pass; b=k8CRjDDX+xpsbSoBf8aLVjz1YXUpe9SPQNGydgXfSyw4MyjpQ+kK3inpBbeS1+Kia2Mwtc pYMPODnRuQdXfC3bOH2HUsyHuFZjtjMVMqX5jqUC7Ql0EY3/iXC32LJKwGM+3I/d/JZ6+4 sVNnW32IxOlIpfY2IwGSWKeJUrrgHIQ= ARC-Authentication-Results: i=2; imf23.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b="a9yDS/MZ"; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf23.hostedemail.com: domain of ziy@nvidia.com designates 40.107.220.75 as permitted sender) smtp.mailfrom=ziy@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=o30RCHMX1eIGtWZEWpeWLNLVsQix8a7kJ/05HWMqnO63VAjtLz7UoEeYlfSvcxbmBx+GirPrS4gZKFsgV9QUDlBcJwSVrlaiWj71Kwg172K6voEZrFWQaKhjb2dAB5qwCTo/THH6sAvzW0ZNkDhCTQvd/si45kmvJ3gWIyThUY+X8JOo+snWS7P8KkrBZnXFtCv72zZZNiLmRO2tyo8Mud5qdWm6S7PCHYsA2GGTvaRLlNscPRZycbJ8nATmvlDJHuNeQZRp7erMkhfUxRKaQ1V+RWKk4cssKtHkSvXCpd9Cwq7yTfrALGQ18ST3BUeZ6M7msWvb24T5wYWv40Aybw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KDUrEUEI+m4wroW5TDUeRH5qgH9WJs8Q7cazAEddcnU=; b=KBTScVc5URRGy5LZw/UplyKXwmJtNsA3Wl4leiLo4R7P5UyTgRisfCjRPbAopJEo35zfg1wRy0OOjcj9UeF1Q9+D+EdcNAPvj7aqCF4K1QL4BUthYMZhzhTvlc9bbQ5o97L11TWRydPqrNAqQTBl+WfJBrfw9rnCZus7Q7srdM1r8jqKqWgHmVVp3bDm7XI++XESC1+mQJnZw0rHAULrgFuMZER+CT/Ktr5GuW8olIxce2GKkzYOQTa1ODHMle/tMk5B4E526Cr8nUj7dJTShP2voNrBFnK8I032y3nCOjomyD6Ul4n4hvbEZMRuG/u9SuThTiNrAFeFjMZyzoBE/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KDUrEUEI+m4wroW5TDUeRH5qgH9WJs8Q7cazAEddcnU=; b=a9yDS/MZM+QwnKm1lS/ZaT/+k6AhS6Lwy6/A0NKeKaU9vSaRq9OqVjKEIj0P5ENtL7/jsrafDjiWuxBj9f5EUCdm5GNGk1hWkm1zfQei/s4kmBPKg0HD6zokQKGCaPDaUR4/tJXxyHdYIlrhFKuyZ1mz9no5PLDpa8ILEJ+tllsUtCRskVXthkRiTUBZ9LKxWNzF7j1GcFM9rfj0ixHAU/VzJaG/E1x+P/qBcshn1gk1GPoH5wQ5MNZZvop+ekh6ecPGRhYxpuxmngoW2F8vwuQ6iflTOiPqet4flXjAJRhWFx1Tzxp3ZhNuo4d3ZnW9/F6+ayEZlyXwjjfjr7qPDg== Received: from LV8PR12MB9336.namprd12.prod.outlook.com (2603:10b6:408:208::12) by DS0PR12MB8813.namprd12.prod.outlook.com (2603:10b6:8:14e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.22; Wed, 14 Aug 2024 14:53:22 +0000 Received: from LV8PR12MB9336.namprd12.prod.outlook.com ([fe80::3745:4e1b:61c8:6c33]) by LV8PR12MB9336.namprd12.prod.outlook.com ([fe80::3745:4e1b:61c8:6c33%3]) with mapi id 15.20.7849.023; Wed, 14 Aug 2024 14:53:22 +0000 From: Zi Yan To: Kefeng Wang Cc: Matthew Wilcox , Andrew Morton , David Hildenbrand , Oscar Salvador , linux-mm@kvack.org Subject: Re: [PATCH RFC] mm: skip gigantic pages in isolate_single_pageblock() when mem offline Date: Wed, 14 Aug 2024 10:53:20 -0400 X-Mailer: MailMate (1.14r6052) Message-ID: <50FEEE33-49CA-48B5-B4C5-964F1BE25D43@nvidia.com> In-Reply-To: References: <20240813125226.1478800-1-wangkefeng.wang@huawei.com> <92fedec5-62c9-4ec0-9d4c-a722b30aa63c@huawei.com> <905740F8-58C6-4333-8EA1-4A53C95CC1FE@nvidia.com> Content-Type: multipart/signed; boundary="=_MailMate_9225D5B9-5858-4C07-93B7-FD0E563B89F3_="; micalg=pgp-sha512; protocol="application/pgp-signature" X-ClientProxiedBy: BN6PR17CA0046.namprd17.prod.outlook.com (2603:10b6:405:75::35) To LV8PR12MB9336.namprd12.prod.outlook.com (2603:10b6:408:208::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV8PR12MB9336:EE_|DS0PR12MB8813:EE_ X-MS-Office365-Filtering-Correlation-Id: 90113910-7959-4334-7b82-08dcbc70d801 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?B0lARIivzBOegkT1gvSYbz0icav4ezxReaihbT89wNXBidE1pJA9z8UC/1R7?= =?us-ascii?Q?6gIX7NZYt0NnlQUoR4mhAQIgbbW0RrkQJWorOn9mtn1u+wdFf76i8JIJ9PCv?= =?us-ascii?Q?XNfOcdpHdWB12QR2EE73Uf0lo9Q07ehRmfJ6G83k9WoyczIJDSYLzJY4wgod?= =?us-ascii?Q?5a6QlJLcunaBt5EGgZ8mCvDzihk9h6zsqbI622qtLXgIGL/W31VxGdjx1i1i?= =?us-ascii?Q?cSj3OW10OmGA3qvvCMCDt9pUqih4C9CzUAY2JMfnMTTV5upeJvKovgh7Rzbm?= =?us-ascii?Q?IQ2swEzgngU86gSELmf7w2sMSGatnyo8zxrQf/IlWFSAN22VeOLrziYD/6Yw?= =?us-ascii?Q?w6wqtcB9NDeVcdmjF1ofv7IiNU8L1NSQRD+MRub2cguQJZn0YkQWGBvd5Bup?= =?us-ascii?Q?rmo/ZYVXgtEfj4jWVfiKjFWenL8nm4+tnsyP2kFLwEHq2Q9cQh+c9N9ap7KV?= =?us-ascii?Q?6K2yR6rsOrnc8OCfKvYxJuaqo5ge99K8AuGSNXU75GCa1fmLCflFN9ZQPCQe?= =?us-ascii?Q?DD6pDKXJLcYXuwvAqBjWLjAbzjWzCrneIzGWxZ9LZor0D8n8Axyx1NcCkaI8?= =?us-ascii?Q?Ss4DV5Ct4Qh1ytOgacL89Wua8mfC2s3BxHIZIsyW0b6/4uhVxOBIYPhsp/vf?= =?us-ascii?Q?+GV1fHV5hhVVhmOXWVN58eZFTAwSMMM0ffrAQXV2xbV1jWaf8dWNHoF4uwEf?= =?us-ascii?Q?OZUPcNrVb82A+mleeYaqEVUgexTlFVPsPFS8XrCPeFet8DJ23Vpr1PquqYbr?= =?us-ascii?Q?5mblN4DVDTgwggXKV/GHAm5wv6QmzeScihgRsa5YVi0YqnooyK4zywGxKKae?= =?us-ascii?Q?j8XrhnGkgBzS5d4NBgyzD59pLy2DniKgT7lxPIG6Qr+zd35rg/xQsN3I6egQ?= =?us-ascii?Q?XfVUIhGpdAve5kIVhqkxqvrE9p1mSc6teX5mYghiK/A51lh8P5Gp+8+qIOsk?= =?us-ascii?Q?iCHcvexxhRID00EcnGZvukUjUR8cRbIN2gv6q2lt5aCmQU/TsxrysTlohDbR?= =?us-ascii?Q?NHVXjXWkwF1n81e3IqFGoOCpcaIBF5Ur67BZM0gYhdAmD9u0TNOUHTeMDVZr?= =?us-ascii?Q?3zPulz0tDxLnvYBL0p0dXR0PfqPmSbn4kAnwDU5vQUCd7MR2GyAvzuX5cBEv?= =?us-ascii?Q?gW7hwQyzlgxfBAHWbMchKa7+wRBfaU9ThvySbGFr29ZR1Twuiy/CrIAT2RGV?= =?us-ascii?Q?xWYbkV/3kyACkDVEOSCsTbmBh6BzCMDFuC6zbSMlFzHzOsg0W0Ujc+/RQj30?= =?us-ascii?Q?cuPlanqg1B1eiJ82FlYVhMwqBaPQK46xcTqdvQTfIJoNpqTxomp9Bl0lLmNy?= =?us-ascii?Q?dEX82HwFO5fA4UeHeehEJuzK+1rXqxVvWXkXCWfi6xoOYQ9VF11MFxqR7AZ2?= =?us-ascii?Q?EZ5Z57I=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV8PR12MB9336.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yFysCn9TfgxTo/Veb9jby0WRRj3+CAeFZTaHIwtNRbsf8tQikgnb/opnRV7A?= =?us-ascii?Q?/fk5HIQV2UHDqjCfrgMoffp/G3f2F6NCrI7GBlg2EASY9GrYaf/LHRZYKq2y?= =?us-ascii?Q?IBdAbWYHhUXEJoCE8/WwplTOHANvtdvbEJdPvz+3bLjy3uZ9qbaQxgtt4mwk?= =?us-ascii?Q?k+9dsL9UTIepiaJwdB2Pqma452ZHawkYj5WUyXoWAj8ywgEchogWOeJHspye?= =?us-ascii?Q?nfUCUze3jKhfxIxlgmpBw9DxslgUbWqyJThGGWieC8z7vQHoMmGwdIjUI1g8?= =?us-ascii?Q?Q2I3RjJTLbBkLO5XJJYDy4cMjw7bNVODSudGgl5yhlmy1I/Cjbql/b8CvUDj?= =?us-ascii?Q?j5plFNUnPRkfrJAgqOY4XH9KjXmBkmy7aC8KBEf15SPN7veHO/ghAZOVrrMJ?= =?us-ascii?Q?duMSUWJ5bqdeUTEZXfqswH8CfdDDTNgWscBAJ9MsI1xBx1bN+4j+gCrKYiXj?= =?us-ascii?Q?HfeRFCc/gbD+4d5vVXK9LJi7EplsDp1YRZe4jad9MzFbP0iYUD7Tr/iUgpjg?= =?us-ascii?Q?/mfu9VdrG1uWyfciOwUyX4OAsrBL61O4IWW5h3liZOVTMeVbxw9ahaK8SCWi?= =?us-ascii?Q?SGvXK+jHtZkmrb9dxxMcG9fNo9FR53x+t5foOdk+3HGn02/hP7ZKdDl9jN3l?= =?us-ascii?Q?WibPYhO170ovJdc8uX5enwM9lxw9B+AXrw70MXgv5ITG/I9/KMiEPdqPM34T?= =?us-ascii?Q?G/TDGJmi02CQ3Iskq4w2Kmohr1zEmHR63agvLPiXpXrRwqHzm1k/cqiG2Mk9?= =?us-ascii?Q?65G4WvqzKN08+vk/VjfJkZukzYGs4QDGissK23X+VIdRPqOGaNNrbJLoog4+?= =?us-ascii?Q?+fHtInDeBOfA/DMrzh4DTaPw6BDde4MGrNQCtsc04vNknegttox98ytExRdY?= =?us-ascii?Q?9IobZD/qUq8fdXJVp6aVzwzxXKtytbSzeobVZfXU4kjvU88LW+wlNIhgOC4w?= =?us-ascii?Q?uCRLKY8ooxg09YDk1GI6DcO7X7Tf8YZoE/ZelPpqXZV6sIHfluat4wIMrTK1?= =?us-ascii?Q?+NfJcFk0VlX5qPNR6+hI43gOMRVzWb6yPazm6TT6wrhfZAVmaJUul7oS/LR+?= =?us-ascii?Q?SYeIqMmgQAfJIM03bVs1nOMiPIFR3Eyght47SlYLohT/oucdnyP2ZU8+pWw5?= =?us-ascii?Q?yJ8JxKbUDf6kRMQAu1tKu3xTMqvogpS5xbuLsYYVGBeyVVLJv8P4akFArZgH?= =?us-ascii?Q?JTF5wC7cqjRwNtvGrIugdMQaNzgV5gp4vQoMuAAxrk9QFZZPCX+TO6b4Hwmp?= =?us-ascii?Q?kgXHifrHps7ED9F+ZK8+bb8Nq//LIkQOixvxZTMNOzppR/EPcNjMDbbojG+x?= =?us-ascii?Q?rCcK4kCMxHNaVKPMduHeaNdDZalx4OuK+FqPtGI7NMTpcyI/cEy8qveylS/S?= =?us-ascii?Q?tvvQeXC8gyy7Hyp42zYaxdna1GuLR6l1+A1TZ+gbr2FzEy+0+lG0TtLiYXm+?= =?us-ascii?Q?l964GVuJiviecqjWHswU3Nw+tNWJCFVbPkO/sDgMjW8AwsZ2Hihm8Z0er2ld?= =?us-ascii?Q?Mu+m1/6MZsM6jyJZXCphKA/nqBpSIjlXljSeTdNUXWqcLSDihF8tphpK5cir?= =?us-ascii?Q?bZB1uZ14EtPvUGySS1w=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 90113910-7959-4334-7b82-08dcbc70d801 X-MS-Exchange-CrossTenant-AuthSource: LV8PR12MB9336.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2024 14:53:22.7836 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: U0XlCCvpUmq1nQt56LDGS8sojEseTiCxESCREIMRm+p/AO0Qeq4VVxowgEcswPU/ X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8813 X-Stat-Signature: fo7jmhnmcbimccg64bmrnpsb5genpau7 X-Rspamd-Queue-Id: 4CCF714000B X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1723647207-513506 X-HE-Meta: U2FsdGVkX1/aXmtrRJCYGqePqQWFCHgT6wSZneg8z5a037CASROvaBj6PDuiJQgYfCeA32qdjdOSKbux+amESC0+KW5xrkV8aZuFRjwcBBlKvz+HIf6P1HKWsXE3E9hOKtZD71Hq5lUM2yFZaa/ig/EzfH7WhXNbIvp5VVDI6Rhz7wG5KaAJmoUC79+w5kpdrH3ZXlxMlDnTEbuUoCAhEaQOfWr51FYExvDOGenR8Rz8cBFTNJaf0HF0RhvlkkZpiRrf6nq7AlO8dO+hKx6aZt8BtrOpwLVSO0DBCAyCFY7DGD+Jhry9cKA2cxVqZNtmJf1SJa8T8EPlYKXYab39r6w1hfmQLmHjfRZc7f5jd6NALxNb9IYzwUCZqoJkRj4x8Lp6kjk/uXILNgo8pvXLpbJiNwcOP5IKQoUxtFqOvbSuAc2bUmEYTHtd1bQI9BaVqViCM69jdbRlcfxHFmMcRWXTz/vOuqOL+ZaOCugvUqpcs2sXfWNjFE1pXLuwd1ueZM3MVgl+zOnR7/fWCdMS6cTUE50Yq0RMjMEFPrO9kRqLwspu/0u5G6GjfVgGkMNjZrN4vY0tpATPrqQTYyPZw3TwvPv6tJb2WtE1kJm8aPFAvvUmbsGASO3KbNc46nQ+GiJxKZ+nRvW1AT6ZHQ6oAfLsNun0CAamNi6NSe81P9mxdRWkMLfJddJEISuImbGHYo4TuwaJjL9z7E3fZiFihfe1Qz5ap/Bb7MzgIQAW034XVmjhz3MD8bvh5mVefSkSsY8VYIYVibzhDQZJI+LY+aL7PU3OlOpmyiAlTdmUdglAnsNkWmiIYYqwfdi+fbqN6uuAq/bWhD3w92VvmFN9hPfbPaQq5BDndP0EGkwFO63hLNvS/w0sXByzMa/8WgKqGs5Koy3RYEI1rX4U5dHcQoQDxmLsZsMe/ZnglENv2fhbuvp8GZVrPIyMCBlmslg7/kIhga/HGQMKnK7cO8A P/CTDuVu bplZiROBjX8PaXOp32aQ/6h2GFRcPEV+CjDn1lcs6xh71eKuoxF0im4VWUg3Bzrjc2pzV2F69+qVCnCu/g9jUi4JbqE+MnEnL2CBeZucNS9RL57wmZ7AuEeP/Z2engI7VXEO5oCKciCARUnJtZTe4koy4AndSormGEKnTj+clfAgK4lu2ZHOxVaAgBAisSD6DaTtTILXoSd+kC5yb708zFk94NngSGb6DmrefY5C/aiNBxK61cznjKhJV4BdvryjdPdsAHrBPua5Rf/lWQJ3jFek377UQZk8PPTsm3KDDKAc+T1sUSO0PLr05sK1Mpc1xZQUUZ9txtyZ6US4O/meErQePBvP8uYo7El2j+vqtLSzgjhc/xLm2sfbotg8u7gBAZKvtNRYDbaW5Wu4V4QNRxbes4QQrlJiiG4S55AuHxIy5QJh6dn01Wg/+/VmlE35ZAnWynzFN6Bb+jzpbA9Ym2nOdZY1jXsQnNIXK012aIBHKDgv+oypAC4nIN47ZqM0OKB68sDLHDBWhXiTcfGUmvZsFifwZ7GFEfASo X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --=_MailMate_9225D5B9-5858-4C07-93B7-FD0E563B89F3_= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On 13 Aug 2024, at 22:01, Kefeng Wang wrote: > On 2024/8/13 22:59, Zi Yan wrote: >> On 13 Aug 2024, at 10:46, Kefeng Wang wrote: >> >>> On 2024/8/13 22:03, Matthew Wilcox wrote: >>>> On Tue, Aug 13, 2024 at 08:52:26PM +0800, Kefeng Wang wrote: >>>>> The gigantic page size may larger than memory block size, so memory= >>>>> offline always fails in this case after commit b2c9e2fbba32 ("mm: m= ake >>>>> alloc_contig_range work at pageblock granularity"), >>>>> >>>>> offline_pages >>>>> start_isolate_page_range >>>>> start_isolate_page_range(isolate_before=3Dtrue) >>>>> isolate [isolate_start, isolate_start + pageblock_nr_pages)= >>>>> start_isolate_page_range(isolate_before=3Dfalse) >>>>> isolate [isolate_end - pageblock_nr_pages, isolate_end) pag= eblock >>>>> __alloc_contig_migrate_range >>>>> isolate_migratepages_range >>>>> isolate_migratepages_block >>>>> isolate_or_dissolve_huge_page >>>>> if (hstate_is_gigantic(h)) >>>>> return -ENOMEM; >>>>> >>>>> [ 15.815756] memory offlining [mem 0x3c0000000-0x3c7ffffff] faile= d due to failure to isolate range >>>>> >>>>> Fix it by skipping the __alloc_contig_migrate_range() if met gigant= ic >>>>> pages when memory offline, which return back to the original logic = to >>>>> handle the gigantic pages. >>>> >>>> This seems like the wrong way to fix this. The logic in the next >>>> PageHuge() section seems like it's specifically supposed to handle >>>> gigantic pages. So you've just made that dead code, but instead of >>>> removing it, you've left it there to confuse everyone? >>> >>> isolate_single_pageblock() in start_isolate_page_range() will be call= ed >>> from memory offline and contig allocation (alloc_contig_pages()), thi= s >>> changes only restore the behavior from memory offline code, but we st= ill >>> fail in contig allocation. >>> >>> From memory offline, we has own path to isolate/migrate page or diss= olve >>> free hugetlb folios, so I think we don't depends on the __alloc_conti= g_migrate_range(). >>>> >>>> I admit to not understanding this code terribly well. >>>> >>> A quick search from [1], the isolate_single_pageblock() is added for >>> contig allocation, but it has negative effects on memory hotplug, >>> Zi Yan, could you give some comments? >>> >>> [1] https://lore.kernel.org/linux-mm/20220425143118.2850746-1-zi.yan@= sent.com/ >> >> Probably we can isolate the hugetlb page and use migrate_page() instea= d of >> __alloc_contig_migrate_range() in the section below, since we are targ= eting >> only hugetlb pages here. It should solve the issue. > > For contig allocation, I think we must isolate/migrate page in > __alloc_contig_migrate_range(), but for memory offline,(especially for > gigantic hugepage)as mentioned above, we already have own path to > isolate/migrate used page and dissolve the free pages,the > start_isolate_page_range() only need to mark page range MIGRATE_ISOLATE= , > that is what we did before b2c9e2fbba32, > > start_isolate_page_range > scan_movable_pages > do_migrate_range > dissolve_free_hugetlb_folios > > Do we really need isolate/migrate the hugetlb page and for memory > offline path? For memory offline path, there is do_migrate_range() to move the pages. For contig allocation, there is __alloc_contig_migrate_range() after isolation to migrate the pages. The migration code in isolate_single_pageblock() is not needed. Something like this would be OK, just skip the page and let either do_migrate_range() or __alloc_contig_migrate_range() to handle it: diff --git a/mm/page_isolation.c b/mm/page_isolation.c index 042937d5abe4..587d723711c5 100644 --- a/mm/page_isolation.c +++ b/mm/page_isolation.c @@ -402,23 +402,6 @@ static int isolate_single_pageblock(unsigned long bo= undary_pfn, int flags, #if defined CONFIG_COMPACTION || defined CONFIG_CMA if (PageHuge(page)) { - int page_mt =3D get_pageblock_migratetype= (page); - struct compact_control cc =3D { - .nr_migratepages =3D 0, - .order =3D -1, - .zone =3D page_zone(pfn_to_page(h= ead_pfn)), - .mode =3D MIGRATE_SYNC, - .ignore_skip_hint =3D true, - .no_set_skip_hint =3D true, - .gfp_mask =3D gfp_flags, - .alloc_contig =3D true, - }; - INIT_LIST_HEAD(&cc.migratepages); - - ret =3D __alloc_contig_migrate_range(&cc,= head_pfn, - head_pfn + nr_pag= es, page_mt); - if (ret) - goto failed; pfn =3D head_pfn + nr_pages; continue; } > > >> >> When I sent the original patchset, I over-thought about the situation = and >> included PageLRU and __PageMovable, so used __alloc_contig_migrate_ran= ge(). >> That was probably not the right approach. >> >> I am aware of that the current page isolation code is very complicated= and >> planning to clean it up. My current plan is: >> 1. turn MIGRATE_ISOLATE a standalone bit instead of a migratetype (I h= ave >> a local patch) >> 2. refactor page isolation code, since after 1, migratetype is preserv= ed >> across isolations >> 3. clean up alloc_contig_range(). >> > > OK, this is another issue not related about memory hotplug, but we > should fix the current memory offline issue. > > Thanks. >> >> Best Regards, >> Yan, Zi -- Best Regards, Yan, Zi --=_MailMate_9225D5B9-5858-4C07-93B7-FD0E563B89F3_= Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAma8xOEPHHppeUBudmlk aWEuY29tAAoJEOJ/noEUByhU+GMP/17z0smzTZ1JDTgIjLcvi/xTDEPVXT81zpg8 QeiKD6WggPdiA8Pi21D0G6vv0okUV9GSm4RbBwj5OGc/RK2xOgjX1R/Mq6Wmlnj5 /Y1SA1UCW4jgahBzMr53ELrnHvs7ExPSaGsMGDP7jX89WMGcJ4sWzGjtprIWkId+ Qg+1wA5PLfjuokMFHZWyIx/FhVaLCg8anqtXW1Dd7VyKjq6JV7PQHgOd1b4AFkfG KLFz0iIyUty7e6fSubziCaONPnf32PLTwWhYK2foQGse7411svaiC7AT/XB0G7kb aXoZLnV3IVl+BBjHfu0Le2yaguTTDz5FMOoHfq6uE4kpiEqAXgr3yJHA3ztbcHgx bdcKBECOnV/pESJ1iCds3mxiccfHUH7y33fLNZfMspwyLSvGsdkcgpsJ3BVDloPF gTZ7muMYmh++6tvHYDNVg3dvu6Chgb3TOoLdF/DsZAAYKTTD1LuicjThQTkIqSLd MZjWDfiqBrwuVikr8ePSEMzVpYhfz/tIX/MvKifOYB5/DEUwNkQg/SKjivjLJx5y HuBNpBpxnumDjSqkS9Z4GRL16gb3Ov8sLgaw46ZhV7oy1Q5zWnuL/2+Rfa9Ue0TX 5WQGYe9o8TXD27RJ8DQQMyEkKl7Qk7dt26M8p1Krp1ZY4WBd48GFJZZfDxVX5XnS La8i49WN =C00f -----END PGP SIGNATURE----- --=_MailMate_9225D5B9-5858-4C07-93B7-FD0E563B89F3_=--