From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: hpa@zytor.com
Cc: kosaki.motohiro@jp.fujitsu.com, akpm@linux-foundation.org,
isimatu.yasuaki@jp.fujitsu.com, tony.luck@intel.com,
tangchen@cn.fujitsu.com, jiang.liu@huawei.com,
wujianguo@huawei.com, wency@cn.fujitsu.com, laijs@cn.fujitsu.com,
linfeng@cn.fujitsu.com, yinghai@kernel.org, rob@landley.net,
minchan.kim@gmail.com, mgorman@suse.de, rientjes@google.com,
guz.fnst@cn.fujitsu.com, rusty@rustcorp.com.au,
lliubbo@gmail.com, jaegeuk.hanse@gmail.com,
glommer@parallels.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH v5 0/5] Add movablecore_map boot option
Date: Thu, 17 Jan 2013 15:27:26 -0500 [thread overview]
Message-ID: <50F85EAE.20206@jp.fujitsu.com> (raw)
In-Reply-To: <50F73111.40009@zytor.com>
On 1/16/2013 6:00 PM, H. Peter Anvin wrote:
> On 01/16/2013 02:01 PM, KOSAKI Motohiro wrote:
>>>>>
>>>>> Things I'm wondering:
>>>>>
>>>>> - is there *really* a case for retaining the boot option if/when
>>>>> SRAT support is available?
>>>>
>>>> Yes. If SRAT support is available, all memory which enabled hotpluggable
>>>> bit are managed by ZONEMOVABLE. But performance degradation may
>>>> occur by NUMA because we can only allocate anonymous page and page-cache
>>>> from these memory.
>>>>
>>>> In this case, if user cannot change SRAT information, user needs a way to
>>>> select/set removable memory manually.
>>>
>>> If I understand this correctly you mean that once SRAT parsing is
>>> implemented, the user can use movablecore_map to override that SRAT
>>> parsing, yes? That movablecore_map will take precedence over SRAT?
>>
>> I think movablecore_map (I prefer movablemem than it, btw) should behave so.
>> because of, for past three years, almost all memory hotplug bug was handled
>> only I and kamezawa-san and, afaik, both don't have hotremove aware specific
>> hardware.
>>
>> So, if the new feature require specific hardware, we can't maintain this area
>> any more.
>>
>
> It is more so than that: the design principle should always be that
> lower-level directives, if present, take precedence over higher-level
> directives. The reason for that should be pretty obvious: one of the
> main uses of the low-level directives is to override the high-level
> directives due to bugs or debugging needs.
My opinion is close to Kani-san@HP. automatic configuration (i.e. reading
firmware infomation) is best for regular user and low level tunable parameter
is best for developer and workaround of firmware bugs.
Perhaps higher level interface may help some corner case but perhaps not. I mean
I don't put any objection to create higher level interface. I only said I myself
haven't observed such use case. so then i have no opinion about that. So, I wouldn't
join interface discussion even though I don't dislike it.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-01-17 20:27 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-14 9:15 Tang Chen
2013-01-14 9:15 ` [PATCH v5 1/5] x86: get pg_data_t's memory from other node Tang Chen
2013-01-14 9:15 ` [PATCH v5 2/5] page_alloc: add movable_memmap kernel parameter Tang Chen
2013-01-14 22:35 ` Andrew Morton
2013-01-14 9:15 ` [PATCH v5 3/5] page_alloc: Introduce zone_movable_limit[] to keep movable limit for nodes Tang Chen
2013-01-14 9:15 ` [PATCH v5 4/5] page_alloc: Make movablecore_map has higher priority Tang Chen
2013-01-14 9:15 ` [PATCH v5 5/5] page_alloc: Bootmem limit with movablecore_map Tang Chen
2013-01-14 17:31 ` [PATCH v5 0/5] Add movablecore_map boot option H. Peter Anvin
2013-01-14 22:34 ` Andrew Morton
2013-01-14 22:41 ` Luck, Tony
2013-01-14 22:46 ` Andrew Morton
2013-01-16 6:25 ` Yasuaki Ishimatsu
2013-01-16 21:29 ` Andrew Morton
2013-01-16 22:01 ` KOSAKI Motohiro
2013-01-16 23:00 ` H. Peter Anvin
2013-01-17 20:27 ` KOSAKI Motohiro [this message]
2013-01-16 22:52 ` H. Peter Anvin
2013-01-17 1:49 ` Tang Chen
2013-01-17 20:20 ` KOSAKI Motohiro
2013-01-17 5:08 ` Yasuaki Ishimatsu
2013-01-17 6:03 ` H. Peter Anvin
2013-01-17 16:30 ` Luck, Tony
2013-01-17 20:28 ` KOSAKI Motohiro
2013-01-18 6:05 ` Yasuaki Ishimatsu
2013-01-18 6:25 ` H. Peter Anvin
2013-01-18 7:38 ` Yasuaki Ishimatsu
2013-01-18 8:08 ` Tang Chen
2013-01-18 9:23 ` li guang
2013-01-18 18:29 ` Luck, Tony
2013-01-19 1:06 ` Jiang Liu
2013-01-19 7:52 ` Chen Gong
2013-01-21 7:36 ` Yasuaki Ishimatsu
2013-01-15 1:23 ` Yasuaki Ishimatsu
2013-01-15 3:44 ` H. Peter Anvin
2013-01-15 4:04 ` Luck, Tony
2013-01-15 0:05 ` Toshi Kani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F85EAE.20206@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=glommer@parallels.com \
--cc=guz.fnst@cn.fujitsu.com \
--cc=hpa@zytor.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=jaegeuk.hanse@gmail.com \
--cc=jiang.liu@huawei.com \
--cc=laijs@cn.fujitsu.com \
--cc=linfeng@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lliubbo@gmail.com \
--cc=mgorman@suse.de \
--cc=minchan.kim@gmail.com \
--cc=rientjes@google.com \
--cc=rob@landley.net \
--cc=rusty@rustcorp.com.au \
--cc=tangchen@cn.fujitsu.com \
--cc=tony.luck@intel.com \
--cc=wency@cn.fujitsu.com \
--cc=wujianguo@huawei.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox