From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7B05C83F2B for ; Thu, 31 Aug 2023 07:17:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2AD488E000B; Thu, 31 Aug 2023 03:17:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 25DEB8D0001; Thu, 31 Aug 2023 03:17:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 126818E000B; Thu, 31 Aug 2023 03:17:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id F06028D0001 for ; Thu, 31 Aug 2023 03:17:47 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id BDC69120162 for ; Thu, 31 Aug 2023 07:17:47 +0000 (UTC) X-FDA: 81183544974.17.8F09287 Received: from out-249.mta0.migadu.com (out-249.mta0.migadu.com [91.218.175.249]) by imf30.hostedemail.com (Postfix) with ESMTP id EB7118000E for ; Thu, 31 Aug 2023 07:17:45 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=TmoDr3ge; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf30.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.249 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693466266; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DFazo8t+x34pBbM7FhZAQZ14ar3Xb4GsuBZugiC8qbg=; b=T9s2rgjxs43Z6GoRy/4vGevVx09KokaXDwFUsYFkSWFsIvU8mUp8eiLjd4mI9JD6cp0NMl ZUVxCgx+Z5vHJQwgavl8X7kGR/h5LiGmBPGyZnDGr1vIRj7HKDg2pHWoGIMBzWYLUiw7Bs GScSAhSqllpTkLHlBdcfMDOO22BQ07A= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=TmoDr3ge; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf30.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.249 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693466266; a=rsa-sha256; cv=none; b=jOAbD3sxRUJvGVbVbZIOvo/I+oi6r9NWZHywjIqXrhPpGkJ4WwoX/QJh3/WRVrw2vBc9+S rstVJg/WGTcc08Hy7HTlNlOunCaNgvsWyUWtx5F69jyzkMy8jXax09dJGsPClkKLFrPYyJ X22Eh8hpdf87wZA7Vl1dR8IlW6xGYEw= Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1693466264; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DFazo8t+x34pBbM7FhZAQZ14ar3Xb4GsuBZugiC8qbg=; b=TmoDr3ge1UyYX8ugRY7XZkb1xippW67sMxQbI3dFiX3Dbs/J/HBs2sO7VWfWEzPmxOfLQe irrOtXTt8xSQ97Xkijkm0FIC9OgQEr/Td6ezNmKG3h7hR9QGia9r5MoB5IEtbw4+D4m6uq CfCbsYqz98UwThxz+SvZ0LkR7PL5hUE= Mime-Version: 1.0 Subject: Re: [PATCH 2/3] use nth_page() in place of direct struct page manipulation. X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20230830182753.55367-3-zi.yan@sent.com> Date: Thu, 31 Aug 2023 15:17:15 +0800 Cc: Linux-MM , LKML , linux-mips@vger.kernel.org, Andrew Morton , Thomas Bogendoerfer , "Matthew Wilcox (Oracle)" , David Hildenbrand , Mike Kravetz , "Mike Rapoport (IBM)" Content-Transfer-Encoding: 7bit Message-Id: <50EF53C6-0CE2-4256-B8AB-AE9BF290419D@linux.dev> References: <20230830182753.55367-1-zi.yan@sent.com> <20230830182753.55367-3-zi.yan@sent.com> To: Zi Yan X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: EB7118000E X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: gwxpyr6s3chbg3u5jzmp4anxhstjcb8p X-HE-Tag: 1693466265-584066 X-HE-Meta: U2FsdGVkX1/hqyQDOdiMqVt2qHN77sI7VIAiKkMxGX6XcTNcwf9CbThewSD4Iz4N5Ag1+8PxS9JPXxysIn3Nz+UoKAZDrv+Kk8/HQiroet0ekSMof4EwSMlvamFcj898v3zzfchMLK0u2xImKBlnoQgOvgcjy4RK0w5pYhkygGcaA8Qu8evpdBP0vt4Bs5LaNCuzWSkkdn5jvHBQkhHcBlLuKTK0cacVTZf3WL4lVG7tyVVu5D2c8u0ShnIUBS7ad3NqPHl41rGbF0HvdpHrRlcMYc2VZNfyojDu2xdC934KK3idfn0U4mbShBFOTn3JyVZUe3Kcyl74dkpwvDSIHOxkedhrE5LNpkcDLaSPAOP06e40Zj8mnLOZzNHh/r4WtmvVS1u/19sO8thcCiU1VdQLwxnscz2A3SbgONV4EtQZjcoIQBd/WxPuhZZaeBJu4o4e1X7QV9xwEYu71sed8mxSVAxf1SOu7IplYWR3eMNWFbxbIYJquZ+/Pm6xANwdIMNa23ZX5ccDyvmWRv+aTMwf+2nv0gWSSbHo+ssWPTe+um/SxjhlbLjfu2/QQAhlB15HT+6vGxZhC+/PWGdIv1G/P1eZ32/hWNEOSrhmUZWuC8RCVrAt1nunO9yHXMHjZk9A/MVvaCTjfO8i3hR5zWzsykM+UJaJEyjwdmhz45mk1cJob5MkSYHppolj+FXDhXBa4/eJyl2SY16NxT4QTqxYdojQ5SQcyDx7X/a/xsSXf2tLRbL/mcf+hw1d11Qg1JyOAjr66mjLsmjLUp3RNfBXaZYYlMwNWDd0SZpQ57TMJEeh4YpqncQb6+YkUGsRPKxJ4xZFfHgMbQoOqjA76SHtOFbR2o4FRUMA4cyfjMbXNVgh4Aij1APu5Vjf2WaMmRGx7XGVs90KugN6hjjJbDWEuA1YjQm7yqq0NJiJWXby/xRM7ilDki6lbslZXE80QKFD3iAUlbXEZWxDDTu 5RTAO9iJ 7pPukrkGzWgVutAaAaOfrOS6T0RH3nl1M4AlPiHzlUtmezV9Oygj5mvCnimTYvvXvzeHqmzYum7BS7JjYJm5q3Hx0wCCTOgBDuvE3hQAJKpbVGeaZvosFV3OlDVZU6UNZQcliV5edpR4EWxWjJfagcuJs4jZaZP1NRlRjuKqCzbldRwzOyRzzrPNJSZO3kkV9UIoQ78T2/HsvAfs72J2Cvk3GUTjGunQ09ORAlcwMd8WWs0OwbnsCYFkK6p7zCJHgP2/ysP2vcF3o9GDmeArdznHFyOEXBuViTI8k7mmiFAYinM/cHOm5JA+uWQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Aug 31, 2023, at 02:27, Zi Yan wrote: > > From: Zi Yan > > When dealing with hugetlb pages, struct page is not guaranteed to be > contiguous on SPARSEMEM without VMEMMAP. Use nth_page() to handle it > properly. > > Signed-off-by: Zi Yan > Reviewed-by: Muchun Song It's better to add a Fixes tag to the commit 38c1ddbde6. Thanks.