From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx131.postini.com [74.125.245.131]) by kanga.kvack.org (Postfix) with SMTP id 06C416B005D for ; Thu, 10 Jan 2013 01:08:30 -0500 (EST) Message-ID: <50EE5AA9.3090401@cn.fujitsu.com> Date: Thu, 10 Jan 2013 14:07:37 +0800 From: Tang Chen MIME-Version: 1.0 Subject: Re: [PATCH v6 04/15] memory-hotplug: remove /sys/firmware/memmap/X sysfs References: <1357723959-5416-1-git-send-email-tangchen@cn.fujitsu.com> <1357723959-5416-5-git-send-email-tangchen@cn.fujitsu.com> <20130109144905.8993886a.akpm@linux-foundation.org> In-Reply-To: <20130109144905.8993886a.akpm@linux-foundation.org> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: rientjes@google.com, len.brown@intel.com, benh@kernel.crashing.org, paulus@samba.org, cl@linux.com, minchan.kim@gmail.com, kosaki.motohiro@jp.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, wujianguo@huawei.com, wency@cn.fujitsu.com, hpa@zytor.com, linfeng@cn.fujitsu.com, laijs@cn.fujitsu.com, mgorman@suse.de, yinghai@kernel.org, glommer@parallels.com, x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-acpi@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-ia64@vger.kernel.org, cmetcalf@tilera.com, sparclinux@vger.kernel.org Hi Andrew, On 01/10/2013 06:49 AM, Andrew Morton wrote: > On Wed, 9 Jan 2013 17:32:28 +0800 > Tang Chen wrote: > >> When (hot)adding memory into system, /sys/firmware/memmap/X/{end, start, type} >> sysfs files are created. But there is no code to remove these files. The patch >> implements the function to remove them. >> >> Note: The code does not free firmware_map_entry which is allocated by bootmem. >> So the patch makes memory leak. But I think the memory leak size is >> very samll. And it does not affect the system. > > Well that's bad. Can we remember the address of that memory and then > reuse the storage if/when the memory is re-added? That at least puts an upper > bound on the leak. I think we can do this. I'll post a new patch to do so. Thanks. :) > > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org