From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx103.postini.com [74.125.245.103]) by kanga.kvack.org (Postfix) with SMTP id E09F56B00AD for ; Thu, 15 Nov 2012 04:57:40 -0500 (EST) Received: from m1.gw.fujitsu.co.jp (unknown [10.0.50.71]) by fgwmail5.fujitsu.co.jp (Postfix) with ESMTP id 870BB3EE0C8 for ; Thu, 15 Nov 2012 18:57:39 +0900 (JST) Received: from smail (m1 [127.0.0.1]) by outgoing.m1.gw.fujitsu.co.jp (Postfix) with ESMTP id 6E07C45DE3E for ; Thu, 15 Nov 2012 18:57:39 +0900 (JST) Received: from s1.gw.fujitsu.co.jp (s1.gw.fujitsu.co.jp [10.0.50.91]) by m1.gw.fujitsu.co.jp (Postfix) with ESMTP id 469C545DE59 for ; Thu, 15 Nov 2012 18:57:39 +0900 (JST) Received: from s1.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s1.gw.fujitsu.co.jp (Postfix) with ESMTP id 394131DB804B for ; Thu, 15 Nov 2012 18:57:39 +0900 (JST) Received: from g01jpexchkw07.g01.fujitsu.local (g01jpexchkw07.g01.fujitsu.local [10.0.194.46]) by s1.gw.fujitsu.co.jp (Postfix) with ESMTP id E59541DB803F for ; Thu, 15 Nov 2012 18:57:38 +0900 (JST) Message-ID: <50A4BC72.4060305@jp.fujitsu.com> Date: Thu, 15 Nov 2012 18:57:06 +0900 From: Yasuaki Ishimatsu MIME-Version: 1.0 Subject: Re: [Patch v5 7/7] acpi_memhotplug.c: auto bind the memory device which is hotplugged before the driver is loaded References: <1352962777-24407-1-git-send-email-wency@cn.fujitsu.com> <1352962777-24407-8-git-send-email-wency@cn.fujitsu.com> In-Reply-To: <1352962777-24407-8-git-send-email-wency@cn.fujitsu.com> Content-Type: text/plain; charset="ISO-2022-JP" Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Wen Congyang Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-acpi@vger.kernel.org, Len Brown , "Rafael J. Wysocki" , Andrew Morton , Lai Jiangshan , Jiang Liu , KOSAKI Motohiro , Minchan Kim , Mel Gorman , David Rientjes , Konrad Rzeszutek Wilk , Toshi Kani , Jiang Liu , Benjamin Herrenschmidt , Paul Mackerras , Christoph Lameter 2012/11/15 15:59, Wen Congyang wrote: > If the memory device is hotplugged before the driver is loaded, the user > cannot see this device under the directory /sys/bus/acpi/devices/, and the > user cannot bind it by hand after the driver is loaded. This patch > introduces a new feature to bind such device when the driver is being > loaded. > > CC: David Rientjes > CC: Jiang Liu > CC: Len Brown > CC: Benjamin Herrenschmidt > CC: Paul Mackerras > CC: Christoph Lameter > Cc: Minchan Kim > CC: Andrew Morton > CC: KOSAKI Motohiro > CC: Yasuaki Ishimatsu > CC: Rafael J. Wysocki > CC: Konrad Rzeszutek Wilk > Signed-off-by: Wen Congyang > --- Reviewed-by: Yasuaki Ishimatsu Thanks, Yasuaki Ishimatsu > drivers/acpi/acpi_memhotplug.c | 37 ++++++++++++++++++++++++++++++++++++- > 1 file changed, 36 insertions(+), 1 deletion(-) > > diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c > index e0f7425..9f1d107 100644 > --- a/drivers/acpi/acpi_memhotplug.c > +++ b/drivers/acpi/acpi_memhotplug.c > @@ -52,6 +52,9 @@ MODULE_LICENSE("GPL"); > #define MEMORY_POWER_ON_STATE 1 > #define MEMORY_POWER_OFF_STATE 2 > > +static bool auto_probe; > +module_param(auto_probe, bool, S_IRUGO | S_IWUSR); > + > static int acpi_memory_device_add(struct acpi_device *device); > static int acpi_memory_device_remove(struct acpi_device *device, int type); > > @@ -494,12 +497,44 @@ acpi_memory_register_notify_handler(acpi_handle handle, > u32 level, void *ctxt, void **retv) > { > acpi_status status; > - > + struct acpi_memory_device *mem_device = NULL; > + unsigned long long current_status; > > status = is_memory_device(handle); > if (ACPI_FAILURE(status)) > return AE_OK; /* continue */ > > + if (auto_probe) { > + /* Get device present/absent information from the _STA */ > + status = acpi_evaluate_integer(handle, "_STA", NULL, > + ¤t_status); > + if (ACPI_FAILURE(status)) > + goto install; > + > + /* > + * Check for device status. Device should be > + * present/enabled/functioning. > + */ > + if (!(current_status & > + (ACPI_STA_DEVICE_PRESENT | ACPI_STA_DEVICE_ENABLED | > + ACPI_STA_DEVICE_FUNCTIONING))) > + goto install; > + > + if (acpi_memory_get_device(handle, &mem_device)) > + goto install; > + > + /* We have bound this device while we register the driver */ > + if (mem_device->state == MEMORY_POWER_ON_STATE) > + goto install; > + > + ACPI_DEBUG_PRINT((ACPI_DB_INFO, > + "\nauto probe memory device\n")); > + > + if (acpi_memory_enable_device(mem_device)) > + pr_err(PREFIX "Cannot enable memory device\n"); > + } > + > +install: > status = acpi_install_notify_handler(handle, ACPI_SYSTEM_NOTIFY, > acpi_memory_device_notify, NULL); > /* continue */ > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org