From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E07FC47073 for ; Thu, 4 Jan 2024 10:46:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9C1348D0070; Thu, 4 Jan 2024 05:46:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 972488D006C; Thu, 4 Jan 2024 05:46:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 812678D0070; Thu, 4 Jan 2024 05:46:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 70ABE8D006C for ; Thu, 4 Jan 2024 05:46:19 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4196314036C for ; Thu, 4 Jan 2024 10:46:19 +0000 (UTC) X-FDA: 81641299278.03.C8B3215 Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by imf17.hostedemail.com (Postfix) with ESMTP id 72C2240018 for ; Thu, 4 Jan 2024 10:46:17 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=none; spf=pass (imf17.hostedemail.com: domain of alex@ghiti.fr designates 217.70.183.198 as permitted sender) smtp.mailfrom=alex@ghiti.fr; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704365177; a=rsa-sha256; cv=none; b=MeUVmoFqt8E/83HUV9l971Wg3Wz4s+yW2yFqnYPX176Q+5sTkcaSv3EqjqXEWR05GkoPlx Sbys1w/iwlpP9TOKHj497QUZRVunIe6LxZE1NzJNr2puHFYXlZfdEERp9Tg6zsCMsSagMz kHrhYVV+uxgKTXjfl4ZRchQ1Z5EzHd8= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; spf=pass (imf17.hostedemail.com: domain of alex@ghiti.fr designates 217.70.183.198 as permitted sender) smtp.mailfrom=alex@ghiti.fr; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704365177; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tOk+lz6pRgxQuAqK8zLJas5GXEM9ORg8NhOP03qnMUo=; b=lwKIr2N9vr0JW1HdncFD0zzLjNWynX3eN11spXy4MI+MehQwbkUcNJjTvBYtoIQBqW9fR2 /O4tRIrODjwMzPQbFom0LYP96yHVQuAEpI0Y36BaMZCBOhDMcHNmjBwwsTqgQYKBnEz1D2 SQaSfACX/Ypb9BeZX9RPxdi41ha1DCY= Received: by mail.gandi.net (Postfix) with ESMTPSA id 8D55FC0006; Thu, 4 Jan 2024 10:46:14 +0000 (UTC) Message-ID: <509f3dd7-1c38-4b98-b21b-28d50399a344@ghiti.fr> Date: Thu, 4 Jan 2024 11:46:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] riscv: enable HAVE_FAST_GUP if MMU Content-Language: en-US To: Jisheng Zhang Cc: Paul Walmsley , Palmer Dabbelt , Albert Ou , Will Deacon , "Aneesh Kumar K . V" , Andrew Morton , Nick Piggin , Peter Zijlstra , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org References: <20231219175046.2496-1-jszhang@kernel.org> <20231219175046.2496-5-jszhang@kernel.org> <3d36ca3c-9a91-41a7-9e68-288982c2c8a8@ghiti.fr> From: Alexandre Ghiti In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-GND-Sasl: alex@ghiti.fr X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 72C2240018 X-Stat-Signature: fw9cqkmy6oghwe3kxtrpd16ta8dkxgfc X-HE-Tag: 1704365177-371295 X-HE-Meta: U2FsdGVkX1+XD5mRzDcONi3R1ymmkvCTRJRlabAS2f8zTJE2yEI8jodkVKk1Ijy01FpIbNTbyiaa8jeVE8jIAnNftAtF+ASvWZ9A8CdkFECoIfZq753bBu6/TJGqiWCD9rlI1IuX8b3t7O/EZNMLghZjiYKMqgRExzABLHQjoEndbXWTSzVOpugdnZhEzwC+mxGHcBWgoz2/puNO2/OETdsmnwT3iBj43F71BU3i2IN3vAJn18ZnQ83cHSMDk2rZVVaiOGSXIG0tSyTu6uXN+leobQl3+ePjLqPlQ1dOoLLNS+QFx1qD1e0fjTzfEkbSZgWUVCDHQfzsgqNWDt4YNDSMzw+HR6jnF09RPrGSqsScpP908etvvT24ziqhq1p8tN0a7BhVkAnc78I+9DMzY+O6f79+vRf9KrPncsosxoBBbD/sG9JlUTtDnOX0cuOR33hKqstYk0U2HkCWrv1brKs9yLbByCQEfK+Rz3HInFDMvtpN3D809FNftGjPy5lfGKn8GSa5w0OB9S22flHQ3xx9m7VllU0RpMFZI9eBcC/OfLSnU41J63ID4gmsfwsMu79nJbtegk9TkNTDjZZD4lvAfPLpti+i0DAqShkigqf3gwWi04VZdw95ncKJvTGTE9x0iF4/fVPls8m0onl/oZvN/OR9zGzAzR+PHFG6XxHe80lwEwzOC4EL2myBRxvjeKK0SL31Wnda5/Q8VSTjMjzPtF2VjiLRph6PNtl9IYjraBIs32j0ruiGcHbyx8l5RePogjXsNEXArWbbttfl5dYFfZJyCHsbkOj11vWrLgWNSwyJfnc4VQmGQFE8Ll0FJAiM4AeIAB0ZJV+jorU6gOcwzxaUOc/6HeoVJSeGxOFE9wpx6e6EMGlSqrS2kov6Fz5aC1JcPoPtUUnfj6n2bHOjE0NP64+4WLPjWMmXEMx6rRAgtSTtI/ekJgSz1kg66hUaYY7L2FIK10ZJw4g ROFGuPiY GW0OwRDSxSZFovCNA2ZIN0gfj+VLIqYrKh5F7iw2rfwcQc4NbrTmV5yF/L372arDI8N9YxoGnUftC9kLIPesm55gLBIUBYyIyxEeuoO4zNLEQGRaZi3/v4oX5z7bNkcR0DosQqH6JmwjTsyTLj3OnhLAt2IT3AGQh1MxgV2nRoQMmHZAO/BrOHUwnEhrTw2f7S4QXMqkZq5DpVrmLgVJn2RGCyQnUNvrYkZDk1+eVW1jMaL14NKKLH6tdWin1xVSoAtyQniEd+oJJBBGGS4iWZJ6yHj3zKNwHIPrvddu/bcK5ExOjfuL4m/jpsA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02/01/2024 04:25, Jisheng Zhang wrote: > On Sun, Dec 31, 2023 at 07:37:33AM +0100, Alexandre Ghiti wrote: >> On 19/12/2023 18:50, Jisheng Zhang wrote: >>> Activate the fast gup for riscv mmu platforms. Here are some >>> GUP_FAST_BENCHMARK performance numbers: >>> >>> Before the patch: >>> GUP_FAST_BENCHMARK: Time: get:53203 put:5085 us >>> >>> After the patch: >>> GUP_FAST_BENCHMARK: Time: get:17711 put:5060 us >> >> On which platform did you run this benchmark? > T-HEAD th1520(cpufreq isn't enabled since the clk/pll isn't upstreamed, > so cpu is running at the default freq set by u-boot) >> >>> The get time is reduced by 66.7%! IOW, 3x get speed! >> >> Well done! >> >> Thanks, >> >> Alex >> >> >>> Signed-off-by: Jisheng Zhang >>> --- >>> arch/riscv/Kconfig | 1 + >>> arch/riscv/include/asm/pgtable.h | 6 ++++++ >>> 2 files changed, 7 insertions(+) >>> >>> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig >>> index d3555173d9f4..04df9920282d 100644 >>> --- a/arch/riscv/Kconfig >>> +++ b/arch/riscv/Kconfig >>> @@ -119,6 +119,7 @@ config RISCV >>> select HAVE_FUNCTION_GRAPH_RETVAL if HAVE_FUNCTION_GRAPH_TRACER >>> select HAVE_FUNCTION_TRACER if !XIP_KERNEL && !PREEMPTION >>> select HAVE_EBPF_JIT if MMU >>> + select HAVE_FAST_GUP if MMU >>> select HAVE_FUNCTION_ARG_ACCESS_API >>> select HAVE_FUNCTION_ERROR_INJECTION >>> select HAVE_GCC_PLUGINS >>> diff --git a/arch/riscv/include/asm/pgtable.h b/arch/riscv/include/asm/pgtable.h >>> index ab00235b018f..c6eb214139e6 100644 >>> --- a/arch/riscv/include/asm/pgtable.h >>> +++ b/arch/riscv/include/asm/pgtable.h >>> @@ -673,6 +673,12 @@ static inline int pmd_write(pmd_t pmd) >>> return pte_write(pmd_pte(pmd)); >>> } >>> +#define pud_write pud_write >>> +static inline int pud_write(pud_t pud) >>> +{ >>> + return pte_write(pud_pte(pud)); >>> +} >>> + >>> static inline int pmd_dirty(pmd_t pmd) >>> { >>> return pte_dirty(pmd_pte(pmd)); Thanks, you can add: Reviewed-by: Alexandre Ghiti Thanks, Alex > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv