From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06A95C6FD18 for ; Tue, 18 Apr 2023 20:43:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6F0498E0002; Tue, 18 Apr 2023 16:43:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 679F98E0001; Tue, 18 Apr 2023 16:43:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 519D58E0002; Tue, 18 Apr 2023 16:43:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3DBD28E0001 for ; Tue, 18 Apr 2023 16:43:07 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id CF42A40425 for ; Tue, 18 Apr 2023 20:43:06 +0000 (UTC) X-FDA: 80695686372.05.90496FB Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf16.hostedemail.com (Postfix) with ESMTP id 1DF2618002C for ; Tue, 18 Apr 2023 20:43:04 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=QcgMoLBn; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf16.hostedemail.com: domain of dsahern@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dsahern@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681850585; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dLQRl7MrLU6H5THvjhH77//uz7v1DOiYZjIQP1yG1sk=; b=0Xr5qRWIpq8zp+EO6WlIynld2zgVLXElOh9IilqBylicp576F/Pmur1NnpJ2ImWpKFQhAv VHMqftO65MJ99epJLjgDvYeJ416g4QjSumsQ414cx3rOmJRbCvH4JvzSnvFe9gOPQgQGwe B2TfxyJjhTjzejllXZh1tYHhzrkoIs8= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=QcgMoLBn; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf16.hostedemail.com: domain of dsahern@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dsahern@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681850585; a=rsa-sha256; cv=none; b=rY0zOmW+KgetEyISUHFOeMju7BwKiUSvhgQpnOv/r3qMQvbnejLeq/jjmDmyMZXZvaREg4 Fmpde+AZD9+4mdzfSP2rGjN4WQ/2+96UIVcWX7uSphoV4gBPv/eucwMe16jQzanIXu/fbI j/VGqrDFsEQWeQT4IWSmJH+hlVRrAn4= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1545260B2B; Tue, 18 Apr 2023 20:43:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 15CDAC433D2; Tue, 18 Apr 2023 20:43:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681850583; bh=AhHTiolfz5eUi5cvQVyc8oJMl78RO/8qvco/Ki2ZAnw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=QcgMoLBn0xT12+BAGcVMWbDxOklEc5Tk/pY7TJkv0VvFFPm4HBYqR9JM4IQrB/Ej2 EncmRqSFI9Sm2sYSD5f+5qNKRp1NnFeWXtOA2833EFAcHfhyRm9Gx8VFC11c4HXTT0 n9U+Xc6oDg9kNrDjvyCZtXprYZ/decQpvSvJbU7ZekjspEfzA1fPCfBNqjId1mLuIx PHTYPE5xPXaP4P89acGr5W8JdWqM2e5QfD6FydFXc8VwSxlXckLtYf0PVkn/u7+clt 6aiazaIh5GXNUbocoK3xWyKI4jqD16hulJhGJYBDetK5vqcUZb5Zz0Cc+4N+RRw5fK rPJ9mMT7Cg8vA== Message-ID: <509b08bd-d2bf-eaa8-6c49-c0860d1adbe0@kernel.org> Date: Tue, 18 Apr 2023 14:43:02 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [linux-next:master] [net] d288a162dd: canonical_address#:#[##] Content-Language: en-US To: Leon Romanovsky , kernel test robot , Wangyang Guo , Jakub Kicinski Cc: oe-lkp@lists.linux.dev, lkp@intel.com, Linux Memory Management List , Arjan van de Ven , Thomas Gleixner , Eric Dumazet , netdev@vger.kernel.org References: <202304162125.18b7bcdd-oliver.sang@intel.com> <20230418164133.GA44666@unreal> From: David Ahern In-Reply-To: <20230418164133.GA44666@unreal> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 1DF2618002C X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: tc3qp8m1i9jxs777mu4ak6qkam1x788z X-HE-Tag: 1681850584-856411 X-HE-Meta: U2FsdGVkX1+G2xNH/McybHczjNbbJfntdzHAWOTyJVuWHKlH4LQmrl7EqmQSbZX5G1+xng4iQA07HnFQqyhMI8MB+rTnmo+gsgYuHaU/XovSpQE0AA/MfKAaI3EUXwlg0EXSoI5ZIKc26/mLV0EksCci+gTOI5qOa/RRi2OODMTMnr2pbwvAImTOnnThiDhgqJALd6nZMQsHN+g9erizNTBx96jqu/6Qc9v8k+yh8xk13G024zuJi+Mpg6mdeAyhw7fSaNSraLdnTpgZRBXzl1Vu8FPb1sRvrm9BT0ublR5ZdTRfk0LM37qPDG/c3UNSBrnIPUL5ZC/iKln86hcRB6a86FMEoqMnZf9f014ubkcnoUUWf4FZY/z+I6Vxl5SWlGhe/HDf7wTD54UL/C5sfYs8FCSmo3zXrstY1nZ2AzGKU3bRfqUKPtXGj4po2AegoqBStZTqMfhjHJeIG/gtP4Wwg/ICX310DtoaxUeIOrwX8E2s5koJXKql2OGHm8EOjB4teOUDY6QWaCI6VTi7BJKFVK/tSVhOQnUhz008ReUpYdMUYTFWYqROxNHJiQ5hZj14BXbKAzV6EKD23BJrijh6bz32yHEfz0aHzshTy9nf7Y88+EAucemSFjyKRibH7g1ik5ExM217uH3sJ6WR7ZQyZHWiSZWywf8o6krP25fODU5bNrNA2GknoJyJjjLAApPAZQ+z9dWmBY08aGlKlIyVlhKeQYR5UkzxwfCoX76y/SVaFmVX0tC8qCQqRRr1hTuWtONVC9FmRzOLAOSDE2IZ0lMizGAbHbFgb9ON9PBilZ846o84RuId5o/0RUek7Qd1rDuVbeJNbPfU6XfC4qvR3DcyjZxXibFULnUSJCOW0bgo6zWam8oaqKsy1c+p+cZ7sRWfnCIu3mOBPS9Irumm+jYF+lJ+lb08FwWprfMrQGyMsqRYXwBpR/NDI7KRZVk88RZ9d8dOx4d7IBF q5tXxAdI bbMfX8oOfKZzhik13BgXB4P/+TxctTVmtfPRX15o10OyIZAkUsesA9rbzRb8G50DcnMUbhBVmWJ9X30vRrwpp7l7Y1cXzCm8gNQJ7MyPmXCW8+snNVxMJv9fSTM6oznPf2+YnTjXWp8wX/1NciQBas74T4QfzlUaJKksLmVdU5jUIj+eBL0UG7jtvd+X50ose2uERRRz1vzPDsRMHnBeF27lloqJFRbA/vSaSRzFapJIq9S36XkqluNOUnrnG5AcOTYLFcU3zAsx6lZyS8hUFAznLKbkrOxzwvcleUyI7FukS6z8+KRXwOB8Rc7YQjI/ssi10/C1YlU1NpLDjXTvNl2yKJr4zR/wAeGlY X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/18/23 10:41 AM, Leon Romanovsky wrote: > Hi, > > I came to the following diff which eliminates the kernel panics, > unfortunately I can explain only second hunk, but first is required > too. > > diff --git a/net/core/dst.c b/net/core/dst.c > index 3247e84045ca..750c8edfe29a 100644 > --- a/net/core/dst.c > +++ b/net/core/dst.c > @@ -72,6 +72,8 @@ void dst_init(struct dst_entry *dst, struct dst_ops *ops, > dst->flags = flags; > if (!(flags & DST_NOCOUNT)) > dst_entries_add(ops, 1); > + > + INIT_LIST_HEAD(&dst->rt_uncached); d288a162dd1c73507da582966f17dd226e34a0c0 moved rt_uncached from rt6_info and rtable to dst_entry. Only ipv4 and ipv6 usages initialize it. Since it is now in dst_entry, dst_init is the better place so it can be removed from rt_dst_alloc and rt6_info_init.