From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66CD5E95A91 for ; Mon, 9 Oct 2023 08:14:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C503C8D001B; Mon, 9 Oct 2023 04:14:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C001F8D0001; Mon, 9 Oct 2023 04:14:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AEEA88D001B; Mon, 9 Oct 2023 04:14:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9F3BC8D0001 for ; Mon, 9 Oct 2023 04:14:10 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 5401F1A017F for ; Mon, 9 Oct 2023 08:14:10 +0000 (UTC) X-FDA: 81325210260.08.F8067D5 Received: from out-194.mta0.migadu.com (out-194.mta0.migadu.com [91.218.175.194]) by imf08.hostedemail.com (Postfix) with ESMTP id 60866160015 for ; Mon, 9 Oct 2023 08:14:08 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=reALlG5T; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf08.hostedemail.com: domain of yajun.deng@linux.dev designates 91.218.175.194 as permitted sender) smtp.mailfrom=yajun.deng@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696839248; a=rsa-sha256; cv=none; b=dNHVC/Xof55MUaPrvD94c8z8XBI3t31X+45LT9wA7hG9062AtSZcPDHbQ078fcLQ8Ibb8U qvDau90VENSx4cLxF/w7ZTFEBPs1CSfWsIQb7v8SzShuIPo3FutKL/93Jx/h9K571wO5EH sIV6VKS0VJHsdPxE1ImlSjwF3Ayho/M= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=reALlG5T; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf08.hostedemail.com: domain of yajun.deng@linux.dev designates 91.218.175.194 as permitted sender) smtp.mailfrom=yajun.deng@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696839248; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=k+Qv4mm4LfFHvIi8wP7qIt9+6u91CDBoXpMXVpFXU9E=; b=QnvywyBbYLhWijVUQKZ6ej8jEB3sOYsZcDMGsDH+EY31QL1ipA1YE2rpak3hjFUzxrhS8W Jh6qGwB3k3u+DKD1PClske0l4uTWWqNL3KeUMoV5hauj9BRzjwDK2pd8/c2g656V/CFhS6 fj/4JspqDUkxQZxPfws2/LRtFPLXNeM= Message-ID: <508b33f7-3dc0-4536-21f6-4a5e7ade2b5c@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1696839245; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k+Qv4mm4LfFHvIi8wP7qIt9+6u91CDBoXpMXVpFXU9E=; b=reALlG5TnFKsumjcpqldLudAXAQgvY+Wrj9WQqyM/WC5hwXbSczKE0OnKNCpzd7x9qltXi XuhawL1h2RzrmHgPEFeArKJUMFD8DeJnj8qCDpEeialpgVCmY8GIVI7yYTDGbf6JpuJsjB R42q6s1hVFZ2uQMxL2EwAdno4501v6Y= Date: Mon, 9 Oct 2023 16:13:54 +0800 MIME-Version: 1.0 Subject: Re: [PATCH net-next v7] net/core: Introduce netdev_core_stats_inc() Content-Language: en-US To: Eric Dumazet Cc: rostedt@goodmis.org, mhiramat@kernel.org, dennis@kernel.org, tj@kernel.org, cl@linux.com, mark.rutland@arm.com, davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Alexander Lobakin , linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org References: <20231007050621.1706331-1-yajun.deng@linux.dev> <917708b5-cb86-f233-e878-9233c4e6c707@linux.dev> <9f4fb613-d63f-9b86-fe92-11bf4dfb7275@linux.dev> <4a747fda-2bb9-4231-66d6-31306184eec2@linux.dev> <814b5598-5284-9558-8f56-12a6f7a67187@linux.dev> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yajun Deng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 60866160015 X-Stat-Signature: 4ckz4dajzthj8g1sjo6xn94ranmbidbg X-HE-Tag: 1696839248-651752 X-HE-Meta: U2FsdGVkX1+BcCMSifAczKOEa7+Dv0q1erWNIPDqC1vZbFFuGm943cqekqPv+D6ZQ4nTRV7f+tSnRJdyrn6+0X69Yloq4RPiJDS2cxyFytICClMdIDRwYOiYMwwLXRDpGL5kpdqHHs5xmxXeM2Fk9AwbzCy2TiUskAg34frNzrk1HyrnC2+DNLE84VzYZCwlgDnrsNI2P3EuiOI3BsAzSImpU5/oI0xkWH83RkEeQaw4mzRQ6OwfriTWT4D1a193GdgoTGnGyyS01mnElbquQEVge3Q0T5GImC1qRgHO2MEYONUjFfMx4dzELbHtexXlEBI29JLRGVcbuJm4HTKGnxhPKd/0BE3atifSY5bwydR68GShvk8dy2+9uVe75qF1ymPBL8mjzP+dtU23IspVfqS5xYUgm0fFjf3hZJHUXvSqD/jjuMbnFTSykUujTN3y+VqpC3fMVAdn7USkkJVTthjjszSv7WLBtgURekBBuwAuNCDodFhmTBQrM+Q6BRyFI3B7BJnAOIsA4cQAmoQEvpEowv3lzkLu8jSDDpxzPTJfGyV6pfOlZznYtm+mbStR1UqPzyROHYaUvxvsBgVFGozock49JSHLEBkET4sYQp5/0WRQIQcrZ4LrifzHdJG7mRIZfpixBsMtcinFPVCTIubsJuO+Z3gvyK4h5RQtmgUMCLIed21Z8mNLBszQivfcauy2YYUO5Q2JvuWEKB3SaCNOs0LIwLU7xOHhz5+Q2mSjEv2YNJZXqeKuSPMUGtn31vZ7MkJH9a3c1D8uVoRoTqdFmJ1ulOCmrHCtnFByfiQaoIi84JBXpQ7z/3MIp+QmN2/6w+gROJxG3DHkkToGHmCu8HK1Yaab34p1Cl0dJnRz6il9GURwalnYi98XkWZL/OqG9L8tzqhM3Pxhgqe7HLEqIk2V61OidmGXZL1YGXdGQgpTsqDhU+CorkQPqPfer0RkPb3Gmhr5os0AH+L aLyfEJ4s 0RfJ4PgJq4WbrMLb8rIdgaZI+LbHg65YHWiOlZB8aVgOJyWWP20kF/KOfEtvJs1QQtKIXCYLfvvayuFecsZISurJ3kXeKIVKPSqM0d8eGr4sMLhgmTmSg2QCzaO+r0AiwNUZXPPCtX9TUyq0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.004189, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/10/9 15:53, Eric Dumazet wrote: > On Mon, Oct 9, 2023 at 5:07 AM Yajun Deng wrote: > >> 'this_cpu_read + this_cpu_write' and 'pr_info + this_cpu_inc' will make >> the trace work well. >> >> They all have 'pop' instructions in them. This may be the key to making >> the trace work well. >> >> Hi all, >> >> I need your help on percpu and ftrace. >> > I do not think you made sure netdev_core_stats_inc() was never inlined. > > Adding more code in it is simply changing how the compiler decides to > inline or not. Yes, you are right. It needs to add the 'noinline' prefix. The disassembly code will have 'pop' instruction. Thanks.