From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx195.postini.com [74.125.245.195]) by kanga.kvack.org (Postfix) with SMTP id F331A6B006C for ; Mon, 29 Oct 2012 09:45:32 -0400 (EDT) Message-ID: <508E886C.20908@parallels.com> Date: Mon, 29 Oct 2012 17:45:16 +0400 From: Glauber Costa MIME-Version: 1.0 Subject: Re: [PATCH v3 1/6] memcg: split mem_cgroup_force_empty into reclaiming and reparenting parts References: <1351251453-6140-1-git-send-email-mhocko@suse.cz> <1351251453-6140-2-git-send-email-mhocko@suse.cz> In-Reply-To: <1351251453-6140-2-git-send-email-mhocko@suse.cz> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Morton , Tejun Heo , Li Zefan , Johannes Weiner , KAMEZAWA Hiroyuki , Balbir Singh On 10/26/2012 03:37 PM, Michal Hocko wrote: > mem_cgroup_force_empty did two separate things depending on free_all > parameter from the very beginning. It either reclaimed as many pages as > possible and moved the rest to the parent or just moved charges to the > parent. The first variant is used as memory.force_empty callback while > the later is used from the mem_cgroup_pre_destroy. > > The whole games around gotos are far from being nice and there is no > reason to keep those two functions inside one. Let's split them and > also move the responsibility for css reference counting to their callers > to make to code easier. > > This patch doesn't have any functional changes. > > Signed-off-by: Michal Hocko > Reviewed-by: Tejun Heo Reviewed-by: Glauber Costa -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org