From: "David Hildenbrand (Red Hat)" <david@kernel.org>
To: Matthew Wilcox <willy@infradead.org>,
Zhang Qilong <zhangqilong3@huawei.com>
Cc: akpm@linux-foundation.org, lorenzo.stoakes@oracle.com,
corbet@lwn.net, ziy@nvidia.com, baolin.wang@linux.alibaba.com,
Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com,
dev.jain@arm.com, baohua@kernel.org, lance.yang@linux.dev,
vbabka@suse.cz, rppt@kernel.org, surenb@google.com,
mhocko@suse.com, wangkefeng.wang@huawei.com,
sunnanyong@huawei.com, linux-mm@kvack.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH next 0/2] THP COW support for private executable file mmap
Date: Mon, 15 Dec 2025 15:26:25 +0100 [thread overview]
Message-ID: <5088b710-cfc5-417e-b629-c01d1eccb9b1@kernel.org> (raw)
In-Reply-To: <aUAUd_XJPVsl_CZL@casper.infradead.org>
On 12/15/25 15:00, Matthew Wilcox wrote:
> On Mon, Dec 15, 2025 at 08:34:05PM +0800, Zhang Qilong wrote:
>> This patch series implementate THP COW for private executable file
>> mmap. It's major designed to increase the iTLB cache hit rate for
>> hot patching application, and we add a new sysfs knob to disable or
>> enable it.
>
> You're going to have to provide data to get this patch in. We've
> deliberately not done this in the past due to memory consumption overhead.
> So you need to prove that's now the wrong decision to make.
>
> Microbenchmarks would be a bare minimum, but what are really needed are
> numbers from actual workloads.
In addition, the sysfs toggle is rather horrible. It's rather clear that
this is not a system-wide setting to be made, as you likely only want
that behavior (if at all ...) for a handful of special processes I assume?
--
Cheers
David
next prev parent reply other threads:[~2025-12-15 14:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-15 12:34 Zhang Qilong
2025-12-15 12:34 ` [PATCH next 1/2] mm/huge_memory: Implementation of THP COW for " Zhang Qilong
2025-12-16 4:42 ` kernel test robot
2025-12-16 5:03 ` kernel test robot
2025-12-16 10:31 ` kernel test robot
2025-12-15 12:34 ` [PATCH next 2/2] mm/huge_memory: Add sysfs knob for executable THP COW Zhang Qilong
2025-12-16 6:07 ` kernel test robot
2025-12-16 11:38 ` kernel test robot
2025-12-16 12:13 ` kernel test robot
2025-12-15 14:00 ` [PATCH next 0/2] THP COW support for private executable file mmap Matthew Wilcox
2025-12-15 14:26 ` David Hildenbrand (Red Hat) [this message]
2025-12-16 2:12 zhangqilong
2025-12-16 2:24 zhangqilong
2025-12-16 2:43 ` David Hildenbrand (Red Hat)
2025-12-16 7:42 zhangqilong
2025-12-30 21:29 ` David Hildenbrand (Red Hat)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5088b710-cfc5-417e-b629-c01d1eccb9b1@kernel.org \
--to=david@kernel.org \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=corbet@lwn.net \
--cc=dev.jain@arm.com \
--cc=lance.yang@linux.dev \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=npache@redhat.com \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=sunnanyong@huawei.com \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=wangkefeng.wang@huawei.com \
--cc=willy@infradead.org \
--cc=zhangqilong3@huawei.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox