From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4952FCFD30C for ; Fri, 11 Oct 2024 09:53:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BEF4B6B00B0; Fri, 11 Oct 2024 05:53:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B9DFB6B00B1; Fri, 11 Oct 2024 05:53:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A17A66B00B2; Fri, 11 Oct 2024 05:53:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8337C6B00B0 for ; Fri, 11 Oct 2024 05:53:21 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3E5B141000 for ; Fri, 11 Oct 2024 09:53:18 +0000 (UTC) X-FDA: 82660858560.20.70E933F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf30.hostedemail.com (Postfix) with ESMTP id C455880006 for ; Fri, 11 Oct 2024 09:53:14 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iGrZ10Xo; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728640354; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=j8JgN0B7e2RGQHwmbcuj8xvOSAz5VKcMMLTM3uCsXkw=; b=DbTJOkqBVL6W62PgRM8OJ2TxKsCwd4VsddjFzsERbQ73o/lsTOY+CTCm8AHwiOOsmGyEXQ 2gwPOfqGi/lsH1QB5tN9WHgfuzQt51f4sqa9ud9tndIbm1xWcslqf2HJ3AsLKL3FBnN4pw IKzptoZhQ7C/s0ipZHnJfPHqvvtSHYc= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iGrZ10Xo; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728640354; a=rsa-sha256; cv=none; b=ebwWUBj53UWszeUvJpf+z6I8yevT5iNv5fIkzkjN2B8vv6lizQU+8FE9e8o/ad9YEalqpf 0VPNwF4KuOhduvfN+TOjG+4j+anUQ1/qEQpybOYlL1HpKYumQ0675y2Pcap4hYW+ntPA9R XoVnXh77aV5sEE3FIe3e5fGL7p14Jhk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728640398; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=j8JgN0B7e2RGQHwmbcuj8xvOSAz5VKcMMLTM3uCsXkw=; b=iGrZ10XoibLsMyJeEMeQlH8tvIaxKIiyDQ5FeFmjD+7JIMx8TSiTOYDx5r+Erv8t5CbAIq rGLBzIjN9sWJqeWHXhKnjMMqzsf2hYMKL+SkG8V80WXEn6i6vFpWflSpDWFu9es0qHi+NE BkC0q8Ab/JAkYXH7qwyAmciL0f5yMXs= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-303-yItOa8ycMjuYla4bw3DRzw-1; Fri, 11 Oct 2024 05:53:17 -0400 X-MC-Unique: yItOa8ycMjuYla4bw3DRzw-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-42cb0b0514bso11462915e9.1 for ; Fri, 11 Oct 2024 02:53:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728640396; x=1729245196; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=j8JgN0B7e2RGQHwmbcuj8xvOSAz5VKcMMLTM3uCsXkw=; b=hKIC5zM+S25+5e0uNuNwgXf6WcYa5iy7mvddSc0N8vFSv9NJ04BgGxzSDK3Du80XYf HGMii4oQVoaN4xsNU1ylAol8OuX0Yp1RT+GXV4UGkoWsf6lsByDhBwypK1m7yvSsxuHy g1HEtmp17Rww1CWr3jk0zj5Fkd83Usi38i5BOcO7998AB8I+FbdxHH7hg9KeihtIjR8Q w2Ww5OKBp3GQKbw+XdsB9DU6Owe7tH12NN8ARYah8beK+v6qmGwJNuvEotQGS+Yxt0fY 9Z3tWo0qjnK9LpSnjv0mcQab+asIjJX+coUyO8xwaPYUzeFVFuOZZZZVco/DIYOz9o91 e/4Q== X-Forwarded-Encrypted: i=1; AJvYcCW9C1JVI1pSseDKGxp1VqcA4vo/uaLDGoebNpudx9yPvdDDjYOzvrtWsJhZSMqM9RF9pQtKw0rtJA==@kvack.org X-Gm-Message-State: AOJu0YzLKwd5ASRGncJTLN83eVX2TPQ9mWUb+LiPv0n/mM0IhXDkZHN2 iSIAeAwyUH2q+2JIijHtGAQR+yyR1WgwhFRghmjDvXhdbvf9NMUAdAizgNeHm7QAFtX7P9vzlm+ tc1kbnxCt/82jet6R6yhsws+68cynaJVB/9phLN7SoUHWTd7d X-Received: by 2002:a05:600c:350f:b0:42e:d4a2:ce67 with SMTP id 5b1f17b1804b1-4311dee8073mr17857795e9.17.1728640395821; Fri, 11 Oct 2024 02:53:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFMlYp7nE25GUUlqYE8/ghORz1FKWYNasIRQ1LAXdxLixDCR0HKVgF11tI6nbCvxAsBI6BWKg== X-Received: by 2002:a05:600c:350f:b0:42e:d4a2:ce67 with SMTP id 5b1f17b1804b1-4311dee8073mr17857465e9.17.1728640395382; Fri, 11 Oct 2024 02:53:15 -0700 (PDT) Received: from ?IPV6:2003:cb:c749:9100:c078:eec6:f2f4:dd3b? (p200300cbc7499100c078eec6f2f4dd3b.dip0.t-ipconnect.de. [2003:cb:c749:9100:c078:eec6:f2f4:dd3b]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-431182ff785sm37510915e9.13.2024.10.11.02.53.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Oct 2024 02:53:14 -0700 (PDT) Message-ID: <50881635-092f-4940-b998-1532d5c9f83a@redhat.com> Date: Fri, 11 Oct 2024 11:53:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH -V2] tdx, memory hotplug: Check whole hot-adding memory range for TDX From: David Hildenbrand To: "Huang, Ying" Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "Kirill A . Shutemov" , x86@kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Dan Williams , Kai Huang , "H. Peter Anvin" , Andy Lutomirski , Oscar Salvador References: <20241010074726.1397820-1-ying.huang@intel.com> <037801d9-8923-4d49-8423-072fd7c73069@redhat.com> <87o73ra0p7.fsf@yhuang6-desk2.ccr.corp.intel.com> <71dc3853-45a6-4fa5-b3c6-b165e0ab6a1b@redhat.com> <87v7xz81jk.fsf@yhuang6-desk2.ccr.corp.intel.com> <4bc038a4-e8ff-4441-acb1-63fcb3dc9068@redhat.com> Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <4bc038a4-e8ff-4441-acb1-63fcb3dc9068@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: schxihtk3i6mt547rus7mtcor493wcqf X-Rspamd-Queue-Id: C455880006 X-Rspamd-Server: rspam11 X-HE-Tag: 1728640394-12026 X-HE-Meta: U2FsdGVkX19lNLJhM9Rxy0HNIDbdeyuSPFhJVYY6V/HeJZ4UfPPNCzFuxqgL7mk+Xtvj+2HZRfzm0CImijEgMwLx2DqXnO/TN2+S+FWT/bR7CLb8ADVtiGIHsz/Csp6kwTqM24bvYDviPuqTvKeFHDtx25IMA/cB5LDPf+YsptrCHUxK/rGKEi4n4rX8CiEPP3NrKRKmKzIS92UZN+Fy9awk4WAtLMyKAx08WBFoo1DpbrFcYMWgU5JOjEC6/34Tf+PILKFJSGN8r3geBDeKmZiIqaeG7KwIgGOy14EdEHuT37g7XLne2gKG9ynSto6Vc1Q09RweCzLRUecv/7yj0gJk8SNQM9hAtlOQAaxEcYXQqxFawyvuMUdc/30gdSHsO6JFZRdcI4A1PcnWoIn//XKCL/75rPQTEft1DBvHLQWvfVed7HK1DOpgxS6V6SGPerUA8zPcBZmAHmHclGmz33zN6mgN5OPaX08QPCDqHohLpIsxzbccGvxfRuFrEMpehOHHtOAOf5FJ9MBgtHe2c/q+KCc+4nFNildlRl7VuseLxYH72KfR6N1ProZIu/wP6qIVUSgs6qSqOM/4MCrK4aRHueUk2LsSHjVq+Fq2MpAlSu6oeCGmGeeV17cdFIAYoiUWBWL2K1Ps6xyrYW2naq5+soYNB2vuX/qN9Se1iPnK4aU4BrIrVz+ZH4FAjQvl2JGjhXa/AUXxKXN/6pFoIrk7ulBTrD32lkO8QclJp51dDAq22aV8VvV3buBXYYHqsKsiwEV3yQ8tyEQBmYZGHx4OGi5g4g5vlJ5cdMlmvWZBj8PZ6+gDNuiPppI7cEixO7PsZWrkh7hf8CoReUGNagx0ZwST25hPoDCjWxO0Nhl3oTfoq5KG2jGGVaypyAOTvmTRgJcFlcWDGbCLpEV5YXoF3Rq1i6bTKpP7XEP5zXBa4fSL29jevzMdqcuNe+PZMAkn06Bf130mRXx1pCR Pc6dX9NF 99H/8eZRrDkO4Xh7HVhCxNapAaDDh0zM4urs90EmUB6LpigNGxetwMLejIC6e2EqYZ52v8AxBSAgyE97iGqxZoFwtB8hcB800z1uNO3/k3QF/OyeEL07zjvSBo5NFJqu8iXFHSaVcmwt0KAkrZRxgWSYiaRaf5joy9MvuUohrsMXIERG80mOC69V0I3vN2Mc+rcgTPtFi225H93BwRx0qA0Gn7T1UqX0SBaDpaeaL2V3vri7hXyCtcUEslqGt614JqUlh5vB16e+r0MB7bbEocvjgpWb8VPOy5lR5i7owjkn6zyn0Am/HxxhsscDQmsAQDOjyQMMnwRuUDjp0raeK7UNbjfd3MHbapyJ2vEfyq2+0zPyvnuqE+TSDnRvV8yJsEIQY2VsJn3sLppSwQX50phhiqvNfv6nt8BigurECunZH94pMu0z8Y+OKkdITVTIcC52izzsJIxSpxdggIuNdjoapkCRS09czAR4IZcgRcjChxIj1mMPsZC0e4UMB4utChqT/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11.10.24 11:48, David Hildenbrand wrote: > On 11.10.24 10:51, Huang, Ying wrote: >> David Hildenbrand writes: >> >>> On 11.10.24 03:27, Huang, Ying wrote: >>>> David Hildenbrand writes: >>>> >>>>>> extern u64 max_mem_size; >>>>>> extern int mhp_online_type_from_str(const char *str); >>>>>> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c >>>>>> index 621ae1015106..c4769f24b1e2 100644 >>>>>> --- a/mm/memory_hotplug.c >>>>>> +++ b/mm/memory_hotplug.c >>>>>> @@ -1305,6 +1305,11 @@ int try_online_node(int nid) >>>>>> return ret; >>>>>> } >>>>>> +int __weak arch_check_hotplug_memory_range(u64 start, u64 size) >>>>>> +{ >>>>>> + return 0; >>>>>> +} >>>>> >>>>> BTW, I remember that "__weak" doesn't always behave the way it would >>>>> seem, which is the reason we're usually using >>>>> >>>>> #define arch_check_hotplug_memory_range arch_check_hotplug_memory_range >>>>> >>>>> #ifndef arch_check_hotplug_memory_range >>>>> ... >>>>> #endif >>>>> >>>>> >>>>> Not that I remember the details, just that it can result in rather >>>>> surprising outcomes (e.g., the wrong function getting called). >>>> I can replace __weak with #define/#ifndef. >>>> However, it appears that "__weak" is still widely used now. >>> >>> Probably better to avoid new ones. >> >> Sure. Will do that in the future versions. >> >>> See also >>> Documentation/dev-tools/checkpatch.rst >>> >>> I assume checkpatch.pl should complain as well? >> >> Double checked again. It doesn't complain for that. > > Indeed, it only checks for usage of "weak" for *declarations*. So maybe > it's fine after all and I am misremembering things. So just leave it as > is for the time being. > For completeness, this is the issue I remembered: commit 65d9a9a60fd71be964effb2e94747a6acb6e7015 Author: Naveen N Rao Date: Fri Jul 1 13:04:04 2022 +0530 kexec_file: drop weak attribute from functions As requested (http://lkml.kernel.org/r/87ee0q7b92.fsf@email.froward.int.ebiederm.org), this series converts weak functions in kexec to use the #ifdef approach. Quoting the 3e35142ef99fe ("kexec_file: drop weak attribute from arch_kexec_apply_relocations[_add]") changelog: : Since commit d1bcae833b32f1 ("ELF: Don't generate unused section symbols") : [1], binutils (v2.36+) started dropping section symbols that it thought : were unused. This isn't an issue in general, but with kexec_file.c, gcc : is placing kexec_arch_apply_relocations[_add] into a separate : .text.unlikely section and the section symbol ".text.unlikely" is being : dropped. Due to this, recordmcount is unable to find a non-weak symbol in : .text.unlikely to generate a relocation record against. -- Cheers, David / dhildenb