From: Ni zhan Chen <nizhan.chen@gmail.com>
To: Bob Liu <lliubbo@gmail.com>
Cc: akpm@linux-foundation.org, mgorman@suse.de, minchan@kernel.org,
m.szyprowski@samsung.com, kamezawa.hiroyu@jp.fujitsu.com,
mhocko@suse.cz, linux-mm@kvack.org
Subject: Re: [PATCH] mm: cma: alloc_contig_range: return early for err path
Date: Tue, 23 Oct 2012 14:55:48 +0800 [thread overview]
Message-ID: <50863F74.2080703@gmail.com> (raw)
In-Reply-To: <1350974757-27876-1-git-send-email-lliubbo@gmail.com>
On 10/23/2012 02:45 PM, Bob Liu wrote:
> If start_isolate_page_range() failed, unset_migratetype_isolate() has been
> done inside it.
>
> Signed-off-by: Bob Liu <lliubbo@gmail.com>
> ---
> mm/page_alloc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index bb90971..b0012ab 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -5825,7 +5825,7 @@ int alloc_contig_range(unsigned long start, unsigned long end,
> ret = start_isolate_page_range(pfn_max_align_down(start),
> pfn_max_align_up(end), migratetype);
> if (ret)
> - goto done;
> + return ret;
looks reasonable to me.
>
> ret = __alloc_contig_migrate_range(&cc, start, end);
> if (ret)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-10-23 6:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-23 6:45 Bob Liu
2012-10-23 6:55 ` Ni zhan Chen [this message]
2012-10-23 12:13 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50863F74.2080703@gmail.com \
--to=nizhan.chen@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=lliubbo@gmail.com \
--cc=m.szyprowski@samsung.com \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
--cc=minchan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox