From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77F6AE77188 for ; Tue, 14 Jan 2025 14:29:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 073006B007B; Tue, 14 Jan 2025 09:29:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 022A26B0083; Tue, 14 Jan 2025 09:29:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E05F96B0085; Tue, 14 Jan 2025 09:29:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C219F6B007B for ; Tue, 14 Jan 2025 09:29:53 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 7E6881A0AA5 for ; Tue, 14 Jan 2025 14:29:53 +0000 (UTC) X-FDA: 83006291466.14.DB7C389 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2052.outbound.protection.outlook.com [40.107.94.52]) by imf20.hostedemail.com (Postfix) with ESMTP id 4B6AD1C0010 for ; Tue, 14 Jan 2025 14:29:50 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b="a/Lx74v2"; dmarc=pass (policy=quarantine) header.from=amd.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf20.hostedemail.com: domain of Thomas.Lendacky@amd.com designates 40.107.94.52 as permitted sender) smtp.mailfrom=Thomas.Lendacky@amd.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1736864990; a=rsa-sha256; cv=pass; b=OEfXasQ7tz3Vu85Nz4DXBn3dEeBMeBP5EYDXB1wxDcRBLCShbv/I9bnpNoCTihkUvjLea7 TNZ/9mkdOnA+J9dAoC09mVPs7HG76rvVPHRV/yDLjk3vHvhFADjN6cdW79RxzQ1tF+N27p OPDkyOT/vx9rjWCc4iCb/lMo5FB4uv8= ARC-Authentication-Results: i=2; imf20.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b="a/Lx74v2"; dmarc=pass (policy=quarantine) header.from=amd.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf20.hostedemail.com: domain of Thomas.Lendacky@amd.com designates 40.107.94.52 as permitted sender) smtp.mailfrom=Thomas.Lendacky@amd.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736864990; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qz5uesCfHD2Gi42H4QR7NYL1MUa8Wo6cNBI7nMbb0n0=; b=0/aSlBopq6mIS/jVmiSJRdK9DzveeexDK9YBe3axWaPR0Il9RtoBeVgPWOPcnI/gpD3XjB gpmPwSwQ9MX92KYwB3vbyn7hZcKjZLdSZPaO0TodHEGpoMrsAe+8FtqJQBBAKsAROozXWq +01dzEKXjVKydU0dfnMPLnT6gi8MPrk= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ECinYkw8WXK1owZ8akSIiDwgmGm2oKOuZ2YrAfwGQj3WTKdNbSyZHchKLGg/10wNa4kF2eYI7N/l9J+mZudhuRGKBmdDYX6YPDIU2mon1hHjadw9SxaVisqs5rqwobwc1sUbqtvzHBm4F9q2NJg+vWbi4dpq6DJtYz2dfSpeDqHLy8pptCoOIeRl0LMzHDzP54hqa9MB8hEIDjkSL/fLROQHu2AGNz2Ws+09LgdcoGgsC3VYQt4R3qf/wiLu8a1SWt2g174dP/5MCDUeEniN0/Q/QZbn1PXCBc/RiwCvmtqhxLauqQ3Hl8kB3GbC0UVEu9qMiF+yuMHA5/KALtNuTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qz5uesCfHD2Gi42H4QR7NYL1MUa8Wo6cNBI7nMbb0n0=; b=KQhgLjFBaxLkddVjOtqtse+emcUp1jirddFxncGCn6jf/YRVJ/CU1k2FIbzEQtTluNWKS4J7fXIXocTaYiJdHAkYid8xjxNqJkvbFaaTeqmv1ZuBgQsiGCRZDkXb5qBRkq4m2pvyv6Qlj8O2XD+oU9y2TadSB8Y0A2eQpxC/VoxWcTZeg3tgLuxPUrvllXxj/J3Ima8MI3UF0XqiTuiLdmRXRB3pZrb+MU7Wh7oexK1VMxkL6wMRb7tENdg5hebsNXjECO0B4WmWfZgfMkrbX0J3agJk/92ZGmc2SJaFIehzZaKNw2nmOiHKMjxTX5CkqbbeuGVf3RnSF39FJulzhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qz5uesCfHD2Gi42H4QR7NYL1MUa8Wo6cNBI7nMbb0n0=; b=a/Lx74v2BI990+7M8bujX2GKoqVY4YSkR34M7uUDg42HaxFbkedDW5f86Okcp79Fi/+zz5f6ezOSv1jFf7MwuQ1yIttCkpM02eL/lsO2zgFHVvfOwLbqcqyoYbN5KqviqHoDqR4BwXlc1iES1d1PkdVV760LzK1QS0v8y0jkbpw= Received: from DM4PR12MB5070.namprd12.prod.outlook.com (2603:10b6:5:389::22) by PH7PR12MB7889.namprd12.prod.outlook.com (2603:10b6:510:27f::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8335.18; Tue, 14 Jan 2025 14:29:46 +0000 Received: from DM4PR12MB5070.namprd12.prod.outlook.com ([fe80::20a9:919e:fd6b:5a6e]) by DM4PR12MB5070.namprd12.prod.outlook.com ([fe80::20a9:919e:fd6b:5a6e%7]) with mapi id 15.20.8335.017; Tue, 14 Jan 2025 14:29:46 +0000 Message-ID: <5085e0aa-5921-40c2-c018-c947b98f5152@amd.com> Date: Tue, 14 Jan 2025 08:29:44 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Content-Language: en-US To: Rik van Riel , x86@kernel.org Cc: linux-kernel@vger.kernel.org, bp@alien8.de, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jannh@google.com References: <20250112155453.1104139-1-riel@surriel.com> <20250112155453.1104139-6-riel@surriel.com> <685632f2-44a4-a7fd-063b-1d426896f297@amd.com> <7045d1666ac5722820a43fffa7f2e6fb3c2eb485.camel@surriel.com> From: Tom Lendacky Subject: Re: [PATCH v4 05/12] x86/mm: add INVLPGB support code In-Reply-To: <7045d1666ac5722820a43fffa7f2e6fb3c2eb485.camel@surriel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SA1P222CA0184.NAMP222.PROD.OUTLOOK.COM (2603:10b6:806:3c4::29) To DM4PR12MB5070.namprd12.prod.outlook.com (2603:10b6:5:389::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR12MB5070:EE_|PH7PR12MB7889:EE_ X-MS-Office365-Filtering-Correlation-Id: 4f199c9f-42bf-4bfc-a9cb-08dd34a7e50e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|7416014|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ZzRveEVHZko0NyttN3hNVTdId2htaEtud092cndyUlhmRzlKK1J1bFYzQlFG?= =?utf-8?B?RzVkWE8vSUFRVXRyNnUzTVFHNEJndG4zdGlEd3pkWm80MjFxNVlQYjhWejNV?= =?utf-8?B?UmtIVjE4RkRLckRFQ1czUlVodG94a1JhUHhsMUxtOWtKQjhhT1Y1UE1uSG43?= =?utf-8?B?WFdGM3FiN2NFNEgyMVFVRHZ2SGpLODJwbDNGWEVGUzVFcDN5UXhPYllaM2pk?= =?utf-8?B?dnFzZlRHbDZKcStzWDQ0aytiN1ViU0t4d3lQOWVvb016bHRPRzhQdzRvYzNT?= =?utf-8?B?M3c5SlQ1OERiNVpzOXIxa1dKZm1RMmtScllGc2c4bmo5SDdYWEE5S0R3enRG?= =?utf-8?B?bnFZYmVNZ2U3STJuQWx2MWE4TVlQYjlDZ2xHRXA1dkhydk4vWHljbk9kUUxp?= =?utf-8?B?L2duTHZ0aU1GcWI3T081b2dkRE5MWjk2Nk93RjZELzY1V2FuaU1RZ0w3UG4v?= =?utf-8?B?M0ZPbTRBMmJZU0dGWmdzcXRsNmFUV3BiV0QrcnpOQW0vSlRrckYrZVB4dGY0?= =?utf-8?B?QXBWdWluaHg0UmVjSEVqc1krbnNOMGovSmhIMGFZQ1dWK1pwVU9tOGpCaUVr?= =?utf-8?B?L1RzMDZ1NGQrdUhhSUFvMGdsbWQzcTAzUytnZ2ZRbG9TK3RnVE14ckplWE1Q?= =?utf-8?B?TnQ3WVo0U293a2xvNEROYlVYcDRlRDcwNkRIWkpqWjZzT2UzTjU1NHZ0S3pk?= =?utf-8?B?RVhtV21xRXNrRzdqNWdhbDdCYWJJMDRhUi8yYWlyZE04SUVQdVFwc09nUHY0?= =?utf-8?B?MHZUZGNLUjRrMEpLY3MrbzBzaysraW0zSmgrWjBHQ3Q3cWczb2hMWUtFY1Nx?= =?utf-8?B?QW9qU2lPeEYxeGk0VXhkOTl0OS9qRmh0c0RScDFkS0d1R3duMmIyMi9FVDVa?= =?utf-8?B?a3laYUtmYWRqMXgwNVd2OVZmYmpqYm5YSjNselpGVkd2YkFqcTlHNnViQ3Fr?= =?utf-8?B?ZWswcGg4UmZERGRPWDVZQ0d3SnVSa3F5cFV5ZWxYWVNlbWV1YUdoU2kwMkUv?= =?utf-8?B?S05YYnc2R3ErZ3ZHeWRyWENFTGJPWG9sWEN0WlAvNlRMczlYYXBJMUxQdjlm?= =?utf-8?B?T2VVSnQxRThvdjRxdnFoK016ZG5rbjJXSGZJZXdyd2hQR21xZDBad1o5NklX?= =?utf-8?B?VjdjMDJqeFVRb2RiMVBDY0UyOHF3dFVTWWNqZG56NmtzNWNsY29LeXB0YjVH?= =?utf-8?B?ZmY5M2x6SXkvK1lCSC9TMURFdGw1WUhSbmdidFdCRC9sRmlKdXdjTWFCYTY3?= =?utf-8?B?N0RMbjB6NzYrOExYQkNMaWQ5TVBWVVhxWVg5NEIvYkRkdTQ3WjRqcGpGNm9y?= =?utf-8?B?ZnBBdkxyaEd4dDRZNXJHTUl3dVJqY29PbVF1SWV5UjBaazNyYXpwV0d6RWJY?= =?utf-8?B?cytyVVJZKy9FK3IwdjV5alRxMUdmMzQ5Z1grTlB3ejQ0dk42WVo0MlpIZXJr?= =?utf-8?B?SzlwTnZCTC9Od1NnVzNTVkFCaGo0N0QyOFRUdEtUVEtWYmwvM1RCdHZYRjNT?= =?utf-8?B?Y0M3R0l1c0E0bUk4dkc3TUhBbG1zUlc5Wm9keFdlNWVMQVVJV25NQUdJUTN5?= =?utf-8?B?d3NiSEsxQmcxZnNDN1RjcXNxWkpZZ2dkOUIxY2JmM3czQjdhU2lTZ2ttTEYw?= =?utf-8?B?SXkvelFueWlIZkRTUTFhYkRwa0luaWMra253QTEycHlUdEYzSkNrNXRpUlZS?= =?utf-8?B?dHlUWTViY1hDMmFNQzRmY0lNTmtoWlMrWml6THliWjArUDdReUdPVi81Q3RY?= =?utf-8?B?cWlZdGVEZCsvdmZCVUUzN0RwR0RTdFVmNEYxaWxoUGJMTlZaNFYwSFVMVFYr?= =?utf-8?B?bnprY0tPSjNURE9abVoyWUMyd3FnVlhVMUtlODBHVzB6NFpkaFJLcENCa0tt?= =?utf-8?Q?vyw0ubCq2S9RR?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB5070.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(7416014)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QUU4R1RGWjdrK2h1TXViUFBNeXFCbTVmeXlCSUp0MlR1aklRVzVUL2kva3M0?= =?utf-8?B?QWNZRkYwd0lOSzd0aUY4a0h4S00wY2V2YjBqeG5oTFJEMkorZWh4RDdNRHl0?= =?utf-8?B?UDZpVmEzRk5vbzJDeXVyQ2V6S1ZYbmJxZUZ5emd4dUlVc1RyTmMvNHZERldC?= =?utf-8?B?Ymo1U1JxZkVzeGVWRHp0TGJjd2FVbFdjMzdQWDg2b0FhVGtEY2R1b0dDT2wy?= =?utf-8?B?NWtOQjlqU1VqMmdyeXM5aE5TeTN1WmsweUZsOUQ5bGphWnN4aHJ3cVNTck91?= =?utf-8?B?N0dGZVdBZzRqVWZLazZySWpOM2dQc25oTElDT0tReHAxYldlMXpQUTRKUmR5?= =?utf-8?B?QksvUFZVc2E0VUY1QStkcmhtSUtXWmZJbXJ5bStqZ1FuRzdvdlJuM0twMm0w?= =?utf-8?B?b09ZNjVaZnlRQjZrM0tNSWJqMzJzWmUybkpFaU1yQlZiRS9ZZVpWaVZDZXJi?= =?utf-8?B?U3N2dWxtK05vaUIrK3NDMXVTYUlteEM0dEFZQkE1RXN2VFNSN1Z6dExqU1Nz?= =?utf-8?B?ZWVFd2JCSWFwWWhtQlEyZVJOeU1mTUgxSU1qelBDVzY0KysvdHBXaTY5dHh5?= =?utf-8?B?MGtnZWprbS9XaUp0dm1IZVdYdm1xcmVJeFJFa0IzdW1DT1JnMHk2bzhxdlJX?= =?utf-8?B?SmMxbVh3NGJ6UlRJeVRpcFNCVDBxM1FFZDNkYnVhVDZEZ2pPVjYrZ3gwZFJJ?= =?utf-8?B?MUdmSkdaNWVleU90VmwvakRYVUU1dStjd1Z4S29tS3krZERRSEhsbzRmMlJw?= =?utf-8?B?MGFoQUVGRFBZMmg3eUZXb0orcnZ1Y1ArUnJEVjFUVmJ0UFRPdHFxZzVwWER6?= =?utf-8?B?L1k1KzRoVDYyYUtybHdDQUFzb1F2eW02NmhKak1aQkx2eENldTZCZExkRDNh?= =?utf-8?B?Uys3VVUxS3NQUU94WXpUL1lxdlZCNC9ybU1qYlE1OG5JQnU0bW9XNU9FQWo3?= =?utf-8?B?VFV6TkpFVEJMVCs0MHVIRUtySlZsWHB1bGp4WCtYKytoeTEyWHNuQUtXMzJB?= =?utf-8?B?Y1BCYTJXbGZMdFZCTVAvM1ZnaGxZejVDb0RpaDZCRmFDaFlzb2VEOFNZOEUx?= =?utf-8?B?VWtDWkpaK21yRmRweGkvUDg2RmZsV2RvY1JweE8vdHR5VWx3Z2Uyckk5ZHhM?= =?utf-8?B?YjV1SjBranp4ZE92VytlWG5JbklWU3ZMRXFMNTJkUzIyVkxKUlJnZUxTdnhy?= =?utf-8?B?MGFpWGxSb1NuM1pUV2o3U0JDMjBIbVAvclMwNVg0ZzNoZkF1SDNXczcraW9w?= =?utf-8?B?eXJ6VGRBNElTZ2ZMM0VWL0ExamRtODZaNnkzUWx6UHNMUS9CaG1SclpycS9O?= =?utf-8?B?NEExK2F5bWloMDNVQVhvU05ldmF2MTlHYXB1bGE4VVI0cTJQcm1uZnFRUDRj?= =?utf-8?B?OXZxdUpsK3M2bTBUc3dmdWxyNWM2VXVRNzZTRUdoZVVsZitjOUpJQ1N2MmpK?= =?utf-8?B?a29tVXlDK3FtKzdDRzZSRUJxSDBaRUl3bEttZ3NuWUhPbTB4TEtsVWltREpw?= =?utf-8?B?ZEVsS1BPeGR5U1JzRHlsYllPaUpVK2VkSFQ0VEg3VW1aeHJsWlZacFZtSHNP?= =?utf-8?B?cjVkK3l0V0xuWm85cHBYblNEdFAxRkhYcmQ2a0VZQkIzQlpCVW5lbjVUR01q?= =?utf-8?B?R2ZMU0ZJUkFVYThzM2xwYzBtUXYrb3BCdTJvRFdlTHdmcGFqYWVCbmlEVEpP?= =?utf-8?B?aDk4RlRWNnYvcWFJVVdKendSdFh5cC9Dakt0ODBRYTEvWnR2bm41clp5cllk?= =?utf-8?B?NEdSWlQ2L2YwWStGYVdWS0o3bGpmTUJYcjJZeWRYMlh2WU0xSDhVWVpNVFJn?= =?utf-8?B?emRiSWxDSzFwUFI2S3FkekY5TzZjOWhZN01jbXcxTExRUVVTME1DK2Z1Q0M4?= =?utf-8?B?ZTV1TVNiTy9MNXNxUVpEOVdMMC9CK0o1aWl2Q3ZxK3Vvd21tYXZBQzRXU1Fo?= =?utf-8?B?UXk4QlBWcUVleEVKUGFuM3dKK0VlS3pyQnoweERpWUtXZGN2TTBBMUlSdXZC?= =?utf-8?B?YWhqMkpsVUlZaysyZmMvTzA4a0I2bE8vTUdBNThZSWdGUStFenExV0hnOE8x?= =?utf-8?B?MHFHK2NXdi8wOG0wdjNlZ2tkSXQvd0xtK0RsSmdxekVOdG9xWmdTY2YvaHJu?= =?utf-8?Q?oLg3H8/FQKc3B80wrXnm1NXfR?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4f199c9f-42bf-4bfc-a9cb-08dd34a7e50e X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5070.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jan 2025 14:29:46.5305 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XN8yoatDrQkQKhiAenGBaSOe0BOnXr+6vCd1xCJ3fEnuxCRtTseDM43uBOnl3+vLrSIyTgPQpGynmC+Iio+lrg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7889 X-Stat-Signature: 7tbroehtgy7eshwwiu31u6o13q18rc8h X-Rspam-User: X-Rspamd-Queue-Id: 4B6AD1C0010 X-Rspamd-Server: rspam08 X-HE-Tag: 1736864990-97543 X-HE-Meta: U2FsdGVkX1+DNG1K5/II6bT3pSX/ql/tFzM8csirqiLjEYIYx+WRPv+I4P1vyTMInhaaKpxwoJ0LMCEv8RZSKqH0CyDEZgs6TigWvV7K0UP6bkh0K/6TjFCfX31vFrcm9lVZvD/Tfdx3GvhpWhKVq14yHxaJyNGSZgyiVVEBdgaxopYbGpexZnndF1sqFnJ8ffQaNI1yIwKmrXe/NsbmZhdr4XU8wtETt8PdViARfd0OzXQFvo4CXOhUBtFOBJYvpdpyaM5vgkpoLMg4Jd+wZvzy3QhlATgEb5gWj0q64FxS+iISbiON2XEgUWDl59o5C47zkMiNZIpSSLE70U9Gi9LFS5k8/sEUMQ/SEps8OkCJIIq6Hm528IxKehlK9+ysxjkQcS1uEiJfZGL2tcZWxWJBC4TVAFPNHDzuB77MJ3cgHOD1zpC/5EFto2z8R5Jb2DUxn/eIJKYjk++rkBubf4eV7h9u66OAH2chCphGX8Y5FVLUC6Mx0z2gspVkn7m7OSvYvkuJyNK7NufWGCYEhJuphGiGZ0UmZfI3jr6BLoo6rBUTsX3FLytAgqCPU64ySyUtVZJcflIXxTM6ntGXx+Fhw37TMj+qMeSsSzbtFE9jJXjewO9T2m3XY7ah/hZRO6USpd9lygQPbjO9wYPK/Bztx0CvVlvbVd7bSRc1Hs9oojyegouTbU3M46nQHRt9IZqcVS4f3pNR0L6/ttLlG+a36bdsIkDwzmX2r5gUZ5YkVIOGHaOojMNi0u0Pd7Ibsvy81GbrrHXxTjXPr+hD6VdprF2jrc0Ufb8J1/WFzOJdjssAJ4CL5dCVPeWD2yzORGS64g8Uw+x6oOLoh0h62uC3GEcxeG7b8k8LxuVSg3DmoZaRGvxzXrJVaYHoNr4eXbIjcl+YB8jLPjgxUjLQTi5gDEvjtrS5ak9g+8HEzSVDD/AW5KsO2di33z7yuYNeZb57V8JNCCKxXNtmPY9 5lPCwW1q geReaRAONxfV6vkNNEepK0PAj+t/IlKZHTa2iTQFkQmNtmnHIgwwsAhZwzefzhAjvLy89OtjVDxnSai95E9WDNZLFqsS+0FXelM0zCCQ8TBzrrC5qHFlwYc1cKnb8SMBbQ7j10rhLvs6kf1ALy7xWolPUUkJJe4qajo+MxqkWp2UgBGb97Mf3gEMepwd1wYabYWU0ODFOudu/8mpQvTRXIEWtoS7IcYtWeglSZAUUxzqHEHhASsjczWZIWxa+0MtFv8zQm7wA99pqdPSi8JpGMWq+0QYD/anjQVx5VqbhrGSaj8AxLl6xu0W7CPQnuqTTEnXCD1trFXQs5AZSucuwc2RAt3lWfLZOiTBMHDiSLQIChnR8QP3TO7cvcbuFa6Q0NKBzko6DhN1TrrFq9tq1DsqJHdo7Aio+uUNP X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/13/25 15:10, Rik van Riel wrote: > On Mon, 2025-01-13 at 08:21 -0600, Tom Lendacky wrote: >> On 1/12/25 09:53, Rik van Riel wrote: >>> >>> +static inline void __invlpgb(unsigned long asid, unsigned long >>> pcid, unsigned long addr, >>> +     int extra_count, bool pmd_stride, >>> unsigned long flags) >>> +{ >>> + u32 edx = (pcid << 16) | asid; >>> + u32 ecx = (pmd_stride << 31); >>> + u64 rax = addr | flags; >>> + >>> + /* Protect against negative numbers. */ >>> + extra_count = max(extra_count, 0); >>> + ecx |= extra_count; >> >> A bad ECX value (ECX[15:0] > invlpgb_count_max) will result in a #GP, >> is >> that ok? > > The calling code ensures we do not call this code > with more than invlpgb_count_max pages at a time. > > Given the choice between "a bug in the calling code > crashes the kernel" and "a bug in the calling code > results in a missed TLB flush", I'm guessing the > crash is probably better. So instead of the negative number protection, shouldn't this just use an unsigned int for extra_count and panic() if the value is greater than invlpgb_count_max? The caller has some sort of logic problem and it could possibly result in missed TLB flushes. Or if a panic() is out of the question, maybe a WARN() and a full TLB flush to be safe? Thanks, Tom >