From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx179.postini.com [74.125.245.179]) by kanga.kvack.org (Postfix) with SMTP id D04766B0062 for ; Mon, 22 Oct 2012 06:14:00 -0400 (EDT) Message-ID: <50851C54.9080600@parallels.com> Date: Mon, 22 Oct 2012 14:13:40 +0400 From: Glauber Costa MIME-Version: 1.0 Subject: Re: [PATCH v5 10/18] sl[au]b: always get the cache from its page in kfree References: <1350656442-1523-1-git-send-email-glommer@parallels.com> <1350656442-1523-11-git-send-email-glommer@parallels.com> <0000013a7a8e764d-5cef2c85-993f-4600-85c7-ce3fe137f16f-000000@email.amazonses.com> In-Reply-To: <0000013a7a8e764d-5cef2c85-993f-4600-85c7-ce3fe137f16f-000000@email.amazonses.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Christoph Lameter Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Mel Gorman , Tejun Heo , Andrew Morton , Michal Hocko , Johannes Weiner , kamezawa.hiroyu@jp.fujitsu.com, David Rientjes , Pekka Enberg , devel@openvz.org, Pekka Enberg , Suleiman Souhlal On 10/19/2012 11:44 PM, Christoph Lameter wrote: > On Fri, 19 Oct 2012, Glauber Costa wrote: > >> struct page already have this information. If we start chaining >> caches, this information will always be more trustworthy than >> whatever is passed into the function > > Yes it does but the information is not standardized between the allocators > yet. Coul you unify that? Come out with a struct page overlay that is as > much the same as possible. Then kfree can also be unified because the > lookup is always the same. That way you can move kfree into slab_common > and avoid modifying multiple allocators. > Ok, this is yet another changelog mistake from mine. This function is not about kfree, but kmem_cache_free. But part of your comment still applies, the page lookup can still be common. I will take a look at that. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org