From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx188.postini.com [74.125.245.188]) by kanga.kvack.org (Postfix) with SMTP id B5C646B002B for ; Wed, 17 Oct 2012 21:25:48 -0400 (EDT) Received: from m1.gw.fujitsu.co.jp (unknown [10.0.50.71]) by fgwmail5.fujitsu.co.jp (Postfix) with ESMTP id 48BCA3EE0BC for ; Thu, 18 Oct 2012 10:25:47 +0900 (JST) Received: from smail (m1 [127.0.0.1]) by outgoing.m1.gw.fujitsu.co.jp (Postfix) with ESMTP id 2FFA045DE5E for ; Thu, 18 Oct 2012 10:25:47 +0900 (JST) Received: from s1.gw.fujitsu.co.jp (s1.gw.fujitsu.co.jp [10.0.50.91]) by m1.gw.fujitsu.co.jp (Postfix) with ESMTP id 0E9C745DE5C for ; Thu, 18 Oct 2012 10:25:47 +0900 (JST) Received: from s1.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s1.gw.fujitsu.co.jp (Postfix) with ESMTP id EFA151DB8043 for ; Thu, 18 Oct 2012 10:25:46 +0900 (JST) Received: from g01jpexchyt09.g01.fujitsu.local (g01jpexchyt09.g01.fujitsu.local [10.128.194.48]) by s1.gw.fujitsu.co.jp (Postfix) with ESMTP id 9B3AA1DB804A for ; Thu, 18 Oct 2012 10:25:46 +0900 (JST) Message-ID: <507F5A78.7030500@jp.fujitsu.com> Date: Thu, 18 Oct 2012 10:25:12 +0900 From: Yasuaki Ishimatsu MIME-Version: 1.0 Subject: Re: [PATCH 1/4] acpi,memory-hotplug : add memory offline code to acpi_memory_device_remove() References: <506C0AE8.40702@jp.fujitsu.com> <506C0C53.60205@jp.fujitsu.com> <50727984.20401@cn.fujitsu.com> <507E54AA.2080806@cn.fujitsu.com> <507E75AA.2000605@cn.fujitsu.com> <507E7FC2.8@cn.fujitsu.com> In-Reply-To: <507E7FC2.8@cn.fujitsu.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Wen Congyang Cc: KOSAKI Motohiro , x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, rientjes@google.com, liuj97@gmail.com, len.brown@intel.com, cl@linux.com, minchan.kim@gmail.com, akpm@linux-foundation.org Hi Wen, 2012/10/17 18:52, Wen Congyang wrote: > At 10/17/2012 05:18 PM, KOSAKI Motohiro Wrote: >>>>>>> Hmm, it doesn't move the code. It just reuse the code in acpi_memory_powerdown_device(). >>>>>> >>>>>> Even if reuse or not reuse, you changed the behavior. If any changes >>>>>> has no good rational, you cannot get an ack. >>>>> >>>>> I don't understand this? IIRC, the behavior isn't changed. >>>> >>>> Heh, please explain why do you think so. >>> >>> We just introduce a function, and move codes from acpi_memory_disable_device() to the new >>> function. We call the new function in acpi_memory_disable_device(), so the function >>> acpi_memory_disable_device()'s behavior isn't changed. >>> >>> Maybe I don't understand what do you want to say. >> >> Ok, now you agreed you moved the code, yes? So then, you should explain why >> your code moving makes zero impact other acpi_memory_disable_device() caller. > > We just move the code, and don't change the acpi_memory_disable_device()'s behavior. > > I look it the change again, and found some diffs: > 1. we treat !info->enabled as error, while it isn't a error without this patch > 2. we remove memory info from the list, it is a bug fix because we free the memory > that stores memory info.(I have sent a patch to fix this bug, and it is in akpm's tree now) > > I guess you mean 1 will change the behavior. In the last version, I don't do it. > Ishimatsu changes this and I don't notify this. > > To Ishimatsu: > > Why do you change this? Oops. If so, it's my mistake. Could you update it in next version? Thanks, Yasuaki Ishimatsu > > Thanks > Wen Congyang > >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> Please read the FAQ at http://www.tux.org/lkml/ >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org