From: Glauber Costa <glommer@parallels.com>
To: David Rientjes <rientjes@google.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@cs.helsinki.fi>
Subject: Re: [PATCH v4] slab: Ignore internal flags in cache creation
Date: Tue, 16 Oct 2012 12:52:49 +0400 [thread overview]
Message-ID: <507D2061.3030101@parallels.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1210151747290.31712@chino.kir.corp.google.com>
On 10/16/2012 04:47 AM, David Rientjes wrote:
> On Mon, 8 Oct 2012, David Rientjes wrote:
>
>>> diff --git a/mm/slab.h b/mm/slab.h
>>> index 7deeb44..4c35c17 100644
>>> --- a/mm/slab.h
>>> +++ b/mm/slab.h
>>> @@ -45,6 +45,31 @@ static inline struct kmem_cache *__kmem_cache_alias(const char *name, size_t siz
>>> #endif
>>>
>>>
>>> +/* Legal flag mask for kmem_cache_create(), for various configurations */
>>> +#define SLAB_CORE_FLAGS (SLAB_HWCACHE_ALIGN | SLAB_CACHE_DMA | SLAB_PANIC | \
>>> + SLAB_DESTROY_BY_RCU | SLAB_DEBUG_OBJECTS )
>>> +
>>> +#if defined(CONFIG_DEBUG_SLAB)
>>> +#define SLAB_DEBUG_FLAGS (SLAB_RED_ZONE | SLAB_POISON | SLAB_STORE_USER)
>>> +#elif defined(CONFIG_SLUB_DEBUG)
>>> +#define SLAB_DEBUG_FLAGS (SLAB_RED_ZONE | SLAB_POISON | SLAB_STORE_USER | \
>>> + SLAB_TRACE | SLAB_DEBUG_FREE)
>>> +#else
>>> +#define SLAB_DEBUG_FLAGS (0)
>>> +#endif
>>> +
>>> +#if defined(CONFIG_SLAB)
>>> +#define SLAB_CACHE_FLAGS (SLAB_MEMSPREAD | SLAB_NOLEAKTRACE | \
>>
>> s/SLAB_MEMSPREAD/SLAB_MEM_SPREAD/
>>
>
> Did you have a v5 of this patch with the above fix?
>
Yes, I sent it bundled in my kmemcg-slab series.
I can send it separately as well, no problem. (Or we can merge the
series!!! =p )
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2012-10-16 8:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-05 10:49 Glauber Costa
2012-10-05 19:00 ` Christoph Lameter
2012-10-08 21:28 ` David Rientjes
2012-10-16 0:47 ` David Rientjes
2012-10-16 8:52 ` Glauber Costa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507D2061.3030101@parallels.com \
--to=glommer@parallels.com \
--cc=cl@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@cs.helsinki.fi \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox