* [PATCH] mm: cleanup register_node()
@ 2012-10-12 8:22 Yasuaki Ishimatsu
2012-10-13 9:56 ` David Rientjes
2012-10-13 23:17 ` KOSAKI Motohiro
0 siblings, 2 replies; 3+ messages in thread
From: Yasuaki Ishimatsu @ 2012-10-12 8:22 UTC (permalink / raw)
To: linux-mm, linux-kernel; +Cc: rientjes, akpm, isimatu.yasuaki
register_node() is defined as extern in include/linux/node.h. But the function
is only called from register_one_node() in driver/base/node.c.
So the patch defines register_node() as static.
CC: David Rientjes <rientjes@google.com>
CC: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
---
drivers/base/node.c | 2 +-
include/linux/node.h | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
Index: linux-3.6/drivers/base/node.c
===================================================================
--- linux-3.6.orig/drivers/base/node.c 2012-10-12 16:35:51.000000000 +0900
+++ linux-3.6/drivers/base/node.c 2012-10-12 16:52:25.294207322 +0900
@@ -259,7 +259,7 @@ static inline void hugetlb_unregister_no
*
* Initialize and register the node device.
*/
-int register_node(struct node *node, int num, struct node *parent)
+static int register_node(struct node *node, int num, struct node *parent)
{
int error;
Index: linux-3.6/include/linux/node.h
===================================================================
--- linux-3.6.orig/include/linux/node.h 2012-10-01 08:47:46.000000000 +0900
+++ linux-3.6/include/linux/node.h 2012-10-12 16:52:55.215210433 +0900
@@ -30,7 +30,6 @@ struct memory_block;
extern struct node node_devices[];
typedef void (*node_registration_func_t)(struct node *);
-extern int register_node(struct node *, int, struct node *);
extern void unregister_node(struct node *node);
#ifdef CONFIG_NUMA
extern int register_one_node(int nid);
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm: cleanup register_node()
2012-10-12 8:22 [PATCH] mm: cleanup register_node() Yasuaki Ishimatsu
@ 2012-10-13 9:56 ` David Rientjes
2012-10-13 23:17 ` KOSAKI Motohiro
1 sibling, 0 replies; 3+ messages in thread
From: David Rientjes @ 2012-10-13 9:56 UTC (permalink / raw)
To: Yasuaki Ishimatsu; +Cc: linux-mm, linux-kernel, akpm
On Fri, 12 Oct 2012, Yasuaki Ishimatsu wrote:
> register_node() is defined as extern in include/linux/node.h. But the function
> is only called from register_one_node() in driver/base/node.c.
>
> So the patch defines register_node() as static.
>
> CC: David Rientjes <rientjes@google.com>
> CC: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
Acked-by: David Rientjes <rientjes@google.com>
Thanks!
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm: cleanup register_node()
2012-10-12 8:22 [PATCH] mm: cleanup register_node() Yasuaki Ishimatsu
2012-10-13 9:56 ` David Rientjes
@ 2012-10-13 23:17 ` KOSAKI Motohiro
1 sibling, 0 replies; 3+ messages in thread
From: KOSAKI Motohiro @ 2012-10-13 23:17 UTC (permalink / raw)
To: Yasuaki Ishimatsu; +Cc: linux-mm, linux-kernel, rientjes, akpm
On Fri, Oct 12, 2012 at 4:22 AM, Yasuaki Ishimatsu
<isimatu.yasuaki@jp.fujitsu.com> wrote:
> register_node() is defined as extern in include/linux/node.h. But the function
> is only called from register_one_node() in driver/base/node.c.
>
> So the patch defines register_node() as static.
>
> CC: David Rientjes <rientjes@google.com>
> CC: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
Acked-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-10-13 23:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-12 8:22 [PATCH] mm: cleanup register_node() Yasuaki Ishimatsu
2012-10-13 9:56 ` David Rientjes
2012-10-13 23:17 ` KOSAKI Motohiro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox