From: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
To: David Rientjes <rientjes@google.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
liuj97@gmail.com, minchan.kim@gmail.com,
akpm@linux-foundation.org, kosaki.motohiro@jp.fujitsu.com,
wency@cn.fujitsu.com
Subject: Re: [PATCH 2/2]suppress "Device nodeX does not have a release() function" warning
Date: Fri, 12 Oct 2012 09:13:50 +0900 [thread overview]
Message-ID: <507760BE.4060906@jp.fujitsu.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1210111326000.28062@chino.kir.corp.google.com>
2012/10/12 5:31, David Rientjes wrote:
> On Thu, 11 Oct 2012, Yasuaki Ishimatsu wrote:
>
>> When calling unregister_node(), the function shows following message at
>> device_release().
>>
>> "Device 'node2' does not have a release() function, it is broken and must
>> be fixed."
>>
>> The reason is node's device struct does not have a release() function.
>>
>> So the patch registers node_device_release() to the device's release()
>> function for suppressing the warning message. Additionally, the patch adds
>> memset() to initialize a node struct into register_node(). Because the node
>> struct is part of node_devices[] array and it cannot be freed by
>> node_device_release(). So if system reuses the node struct, it has a garbage.
>>
>
> Nice catch on reuse of the statically allocated node_devices[] for node
> hotplug.
>
>> CC: David Rientjes <rientjes@google.com>
>> CC: Jiang Liu <liuj97@gmail.com>
>> Cc: Minchan Kim <minchan.kim@gmail.com>
>> CC: Andrew Morton <akpm@linux-foundation.org>
>> CC: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
>> Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
>> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
>
> Can register_node() be made static in drivers/base/node.c and its
> declaration removed from linux/node.h?
Yah. I'll fix it.
Thanks,
Yasuaki Ishimatsu
>
> Acked-by: David Rientjes <rientjes@google.com>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-10-12 0:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-11 5:19 [PATCH v2 0/2] Suppress "Device <device name> " Yasuaki Ishimatsu
2012-10-11 5:22 ` [PATCH 1/2]suppress "Device memoryX " Yasuaki Ishimatsu
2012-10-11 20:23 ` David Rientjes
2012-10-11 22:30 ` KOSAKI Motohiro
2012-10-11 5:26 ` [PATCH 2/2]suppress "Device nodeX " Yasuaki Ishimatsu
2012-10-11 20:31 ` David Rientjes
2012-10-12 0:13 ` Yasuaki Ishimatsu [this message]
2012-10-11 22:33 ` KOSAKI Motohiro
2012-10-17 6:24 ` Wen Congyang
2012-10-17 8:50 ` KOSAKI Motohiro
2012-10-19 5:42 ` Wen Congyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507760BE.4060906@jp.fujitsu.com \
--to=isimatu.yasuaki@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liuj97@gmail.com \
--cc=minchan.kim@gmail.com \
--cc=rientjes@google.com \
--cc=wency@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox