From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx135.postini.com [74.125.245.135]) by kanga.kvack.org (Postfix) with SMTP id 2A39B6B002B for ; Wed, 10 Oct 2012 04:56:44 -0400 (EDT) Message-ID: <5075383A.1000001@parallels.com> Date: Wed, 10 Oct 2012 12:56:26 +0400 From: Glauber Costa MIME-Version: 1.0 Subject: Re: [patch for-linus] memcg, kmem: fix build error when CONFIG_INET is disabled References: In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: David Rientjes Cc: Andrew Morton , Linus Torvalds , Randy Dunlap , KAMEZAWA Hiroyuki , "Kirill A. Shutemov" , "David S. Miller" , "Eric W. Biederman" , Eric Dumazet , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko On 10/10/2012 10:32 AM, David Rientjes wrote: > Commit e1aab161e013 ("socket: initial cgroup code.") causes a build error > when CONFIG_INET is disabled in Linus' tree: > unlikely that something that old would cause a build bug now, specially that commit, that actually wraps things inside CONFIG_INET. More likely caused by the recently merged "memcg-cleanup-kmem-tcp-ifdefs.patch" in -mm by mhocko (CC'd) As a matter of fact, I just tested, and it indeed start failing after that patch. Michal, since it is just a cleanup patch, I'd prefer just reverting if you are okay with it. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org