From: Glauber Costa <glommer@parallels.com>
To: Pekka Enberg <penberg@kernel.org>
Cc: David Rientjes <rientjes@google.com>,
Christoph Lameter <cl@linux.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Michal Hocko <mhocko@suse.cz>
Subject: Re: [PATCH] slab: Ignore internal flags in cache creation
Date: Mon, 1 Oct 2012 11:58:52 +0400 [thread overview]
Message-ID: <50694D3C.8000603@parallels.com> (raw)
In-Reply-To: <CAOJsxLFYSKqq-JexK1Q7NEtQmxtJnWB-WwbNyp9tk9mpAh6vGg@mail.gmail.com>
On 10/01/2012 11:28 AM, Pekka Enberg wrote:
> Hello,
>
> [ Found this in my @cs.helsinki.fi inbox, grmbl. ]
>
> On Fri, Sep 28, 2012 at 11:39 PM, David Rientjes <rientjes@google.com> wrote:
>> The first prototype, SLAM XP1, will be posted in October. I'd simply like
>> to avoid reverting this patch down the road and having all of us
>> reconsider the topic again when clear alternatives exist that, in my
>> opinion, make the code cleaner.
>
> David, I'm sure you know we don't work speculatively against
> out-of-tree code that may or may not be include in the future...
>
> That said, I don't like Glauber's patch because it leaves CREATE_MASK
> in mm/slab.c. And I'm not totally convinced a generic SLAB_INTERNAL is
> going to cut it either. Hmm.
>
> Pekka
>
How about we require allocators to define their own CREATE_MASK, and
then in slab_common.c we mask out any flags outside that mask?
This way we can achieve masking in common code while still leaving the
decision to the allocators.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-10-01 8:02 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-25 11:17 Glauber Costa
2012-09-25 16:26 ` Christoph Lameter
2012-09-26 0:46 ` David Rientjes
2012-09-26 8:43 ` Glauber Costa
2012-09-27 1:16 ` David Rientjes
2012-09-27 6:59 ` Glauber Costa
2012-09-27 22:56 ` David Rientjes
2012-09-28 7:46 ` Glauber Costa
2012-09-28 20:25 ` David Rientjes
2012-09-28 14:12 ` Christoph Lameter
2012-09-28 20:39 ` David Rientjes
2012-09-28 21:20 ` Christoph Lameter
2012-09-28 23:11 ` David Rientjes
2012-10-01 17:54 ` Christoph Lameter
2012-10-01 7:28 ` Pekka Enberg
2012-10-01 7:58 ` Glauber Costa [this message]
2012-09-27 13:54 ` Christoph Lameter
2012-09-27 22:50 ` David Rientjes
2012-09-28 14:04 ` Christoph Lameter
2012-09-28 20:36 ` David Rientjes
2012-09-26 14:57 ` Christoph Lameter
2012-09-27 1:12 ` David Rientjes
2012-09-27 13:57 ` Christoph Lameter
2012-09-27 22:52 ` David Rientjes
2012-09-28 14:10 ` Christoph Lameter
2012-09-28 20:30 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50694D3C.8000603@parallels.com \
--to=glommer@parallels.com \
--cc=cl@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox