From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3153FC3DA4A for ; Thu, 11 Jul 2024 07:54:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6E0716B0088; Thu, 11 Jul 2024 03:54:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 691FE6B0089; Thu, 11 Jul 2024 03:54:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 531E86B008A; Thu, 11 Jul 2024 03:54:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 361336B0088 for ; Thu, 11 Jul 2024 03:54:48 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D59CC1A0373 for ; Thu, 11 Jul 2024 07:54:47 +0000 (UTC) X-FDA: 82326710214.01.351B55E Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf10.hostedemail.com (Postfix) with ESMTP id 6E3FBC0014 for ; Thu, 11 Jul 2024 07:54:45 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=LfZdeTFK; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=jUOhjPon; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=LfZdeTFK; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=jUOhjPon; spf=pass (imf10.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720684469; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZcFE4t9cdlMRrdxbYeT+gV8kwHPzRyyv5xzJ74r0xv4=; b=ijThO75ZRrdWgKv/ALci8paiWGyTDtsSTqx2BWzCl3jvSFnLm3XiMf8TxMuSYPqEI61atx bQO/6JNnmR/Zj6vABXqu2EPk318POJM/n/lKfypu6K6cHnNnq6pr8ALw3l1vJJW0/uNPAq ayA0y0WHTFPGj1RED4JOgx6+tckps6M= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=LfZdeTFK; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=jUOhjPon; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=LfZdeTFK; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=jUOhjPon; spf=pass (imf10.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720684469; a=rsa-sha256; cv=none; b=FWMPphQt6ibwnoIA69lyyFun2FInH/skLPwbikfhnWauphFeZdWB6fx7KQkhLrPFsJEoL/ zgiJC4ui1ZnngJUMUajmoDkXP+lL3HLRogwHnFZcRaRnHUVv7o7hoY0RJnUIoerKs0TBVs GLqErSDEHfVw06F6/7pP+Op635Lbl1g= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 9AB5E1F8B3; Thu, 11 Jul 2024 07:54:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1720684483; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ZcFE4t9cdlMRrdxbYeT+gV8kwHPzRyyv5xzJ74r0xv4=; b=LfZdeTFK2IFC1PSDYA4nTXFEfhIZLx7PMkuwKQgytQqE9gjTehQUhtaoDBFSV1vd4PcuhM fxwse3rHex2HovnsE92f5OTbr0EvsOeFtvYDVPXxy89SPB2UtMwQiL723HlbHc4yQxW/5c tYg3BbvDecgBZ/xKwYuxue3IYzMg0q8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1720684483; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ZcFE4t9cdlMRrdxbYeT+gV8kwHPzRyyv5xzJ74r0xv4=; b=jUOhjPon0Jk7Vuj59hKMC2w2FhR88su1ZLNPC3N97wI2ZOZMa8/DONQCsNO+Iu0aVop9QW RJnrA3uGTGR1W+Aw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1720684483; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ZcFE4t9cdlMRrdxbYeT+gV8kwHPzRyyv5xzJ74r0xv4=; b=LfZdeTFK2IFC1PSDYA4nTXFEfhIZLx7PMkuwKQgytQqE9gjTehQUhtaoDBFSV1vd4PcuhM fxwse3rHex2HovnsE92f5OTbr0EvsOeFtvYDVPXxy89SPB2UtMwQiL723HlbHc4yQxW/5c tYg3BbvDecgBZ/xKwYuxue3IYzMg0q8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1720684483; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ZcFE4t9cdlMRrdxbYeT+gV8kwHPzRyyv5xzJ74r0xv4=; b=jUOhjPon0Jk7Vuj59hKMC2w2FhR88su1ZLNPC3N97wI2ZOZMa8/DONQCsNO+Iu0aVop9QW RJnrA3uGTGR1W+Aw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 891F9139E0; Thu, 11 Jul 2024 07:54:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id VUEkIcOPj2aVGAAAD6G6ig (envelope-from ); Thu, 11 Jul 2024 07:54:43 +0000 Message-ID: <5067a09b-71b5-45dc-916a-d3e7c679bd83@suse.cz> Date: Thu, 11 Jul 2024 09:54:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/6] slub: Use alloc_pages_node() in alloc_slab_page() Content-Language: en-US To: "Christoph Lameter (Ampere)" Cc: "Matthew Wilcox (Oracle)" , Andrew Morton , linux-mm@kvack.org, Johannes Weiner , Hyeonggon Yoo <42.hyeyoo@gmail.com> References: <20231228085748.1083901-1-willy@infradead.org> <20231228085748.1083901-3-willy@infradead.org> <624cc2ee-9335-31e5-4177-97fe676b6e76@gentwo.org> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 6E3FBC0014 X-Stat-Signature: umg9r7gk9ctock5iqw9zm86164sfksm4 X-HE-Tag: 1720684485-598023 X-HE-Meta: U2FsdGVkX196OltMsmowCN/NKM7gTYGr51X+K1d0f8boX8WY+S/cvrivqF1rItUVQ8pI1ARZWq+QzIzhRwxxx4OFdBhbEUP5t+fadG7Vf9rqx66/b3DwZYb8jpFkC0zhvvQ1RWBgDJchO/wEM+/nRJhcGVyNTsy8TmuZ9wmClDM6nZe07x5pS30xt1DlVgd7eVx2tdhBw0TWH5J8rv86lCBHw8gJXLmlo7DKnc+ILXwGYQeztHBr9lsULXDdCLOeviSllhZesebBaSRb7I/3k+oQWomBlqpdwIS6UlDbR+XNvsm6/uwls+xdaGU7tRhtuWIaH9YMGCnAHw5sopwUrKNYgVJPDvwj8q1TkYU4gQQZcYVKOvvEW8fFUgRGxuY9A3BUefrLc5WuxmKmqWR2UnETNkP47MoaE9qawNHN6AfAVqFjevifMv8vLufw7TLK14YYP7XA+pWGc3hnkETQoT9SWoXIdvhKeMFBzFu1RYUB0FuFTkQ6q9/Z335Wl5Njs5Aqj7NgCqVSb0YI8O9jbdJ0TladWslY0ZH80eNpN81hXo9rEA7MVYu82gjDQncU8pZvJrICBFZVaY6Puazc0i3Tld1ccaVPOeMhUoK+q0pWUiD4pLQyqsoHzeNyHXxCiP9hAvvZ1G8FmvSc8I2vPO+iqz7KnrlKTNzexC7DSIjoVM7W/uD8wdCVD8Y1xmU9rtYHvw4oUMdjhECfDRm+7kTiBBpIcyGI0HYXpvQresUyHzBc6dBDatmRTd1bFozLdw4iNvXtoHRIVJgYbeprQFjUOvCPdGK/XhlW5NZN3bCiz18d+pBazC6WXpkmSI0oNDp9a6MDJLVqhZKOwI/X2YifTDeT/7gAJTXyLFwIOOoC8PUluF8qwHWZBSXwDhkkgtsf4SDLwfJhzYqpXhycVt0IMRVea8fIiuNa5ab95GpvtKkQNHPkh+OWCFSHBcp1AyrUU+atoizMC9UcjWZ 4Jg7VSPP qjIRhW2wX3GWWlDW+xyGDzlrvfYsr2JMWF9HAMqMqFvYWLRDJENz+W8B2tiONK9w7lp6IQu8cqQ4EtoAF3NI3hC7g7Yx4U15sNZJmoIk5YsShoWltUJYdRJ+/G39bkYlUdpDfGdjIL3bJQGltfyQfONQ+3buX42G5ZeW42qieMG6F4jrY5wK85ELDv+LEx2MT0YW7rFsDQEm2QZ6h/hKxwL8V7kraoc2O7KJNydFgbhfgaK5OaGxCeJvijoj8ZHvDYqBW1NxDE/UkgBk32LXXm8h0rKfHQG6MMCngM6mvEQqSHR2rcBS/CN8B2cvs2MrRRxwDzSDLREMMHMtrL8RqRoGr8yucKZbP/U+3s3ondVbIRz9DiUQTm6tsIHBMYttojpWH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/10/24 6:43 PM, Christoph Lameter (Ampere) wrote: > On Wed, 10 Jul 2024, Vlastimil Babka wrote: > >>> With this patch cgroup restrictions memory policies etc etc no longer work >>> in the slab allocator. >> >> The only difference is memory policy from get_task_policy(), and the rest is >> the same, right? > > There are also the cpuset/cgroup restrictions via the zonelists that are > bypassed by removing alloc_pages() AFAICS cpusets are handled on a level that's reached by both paths, i.e. prepare_alloc_pages(), and I see nothing that would make switching to alloc_pages_node() bypass it. Am I missing something? >> But this only affects new slab page allocation, while getting objects from >> existing slabs isn't subject to memory policies, so now it's at least >> consistent? Do you have some use case where it matters? > > Yes this means you cannot redirect kmalloc based kernel metadata > allocation when creating f.e. cgroups for another NUMA node. This affects > all kernel metadata allocation during syscalls that used to be > controllable via numa methods. > > SLAB implemented memory allocations policies per object. SLUB moved that > to implement these policies only when allocating a page frame. If this > patch is left in then there wont be any support for memory allocation > policies left in the slab allocators. > > We have some internal patches now that implement memory policies on a per > object basis for SLUB here. > > This is a 10-15% regression on various benchmarks when objects like the > scheduler statistics structures are misplaced. I believe it would be best if you submitted a patch with with all that reasoning. Thanks!