From: Glauber Costa <glommer@parallels.com>
To: Christoph Lameter <cl@linux.com>
Cc: Pekka Enberg <penberg@kernel.org>, Joonsoo Kim <js1304@gmail.com>,
linux-mm@kvack.org, David Rientjes <rientjes@google.com>,
Fengguang Wu <fengguang.wu@intel.com>
Subject: Re: CK1 [00/13] [RFC] Sl[auo]b: Common kmalloc caches V1
Date: Fri, 28 Sep 2012 13:00:05 +0400 [thread overview]
Message-ID: <50656715.1020303@parallels.com> (raw)
In-Reply-To: <0000013a03fe75d9-fa42a2fe-0742-47bd-99ee-5d2886e30436-000000@email.amazonses.com>
On 09/26/2012 11:12 PM, Christoph Lameter wrote:
> This patchset cleans up the bootstrap of the allocators
> and creates a common function to set up the
> kmalloc array. The results are more common
> data structures that will simplify further work
> on having common functions for all allocators.
>
The patchset looks good in general, and the few things that need to be
fixed that I could spot in this review I've sent already.
It seems to touch less bug-prone things than your last round, which is
good. Still, given all the small problems we had, I would insist this
should get a round of build & boot testing to make sure they don't
happen again.
Thankfully, we now have Fengguang's marvelous 0-day test system that
should be able to find all that.
For simplicity, I've uploaded your series to my "slab-common/kmalloc"
branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/glommer/memcg.git
I'll let you know if it spills anything, and you can then fold together
with my comments in v2.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-09-28 9:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-26 19:12 Christoph Lameter
2012-09-28 9:00 ` Glauber Costa [this message]
2012-09-26 20:01 Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50656715.1020303@parallels.com \
--to=glommer@parallels.com \
--cc=cl@linux.com \
--cc=fengguang.wu@intel.com \
--cc=js1304@gmail.com \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox