From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx194.postini.com [74.125.245.194]) by kanga.kvack.org (Postfix) with SMTP id B7B0D6B005A for ; Thu, 27 Sep 2012 10:36:59 -0400 (EDT) Message-ID: <506463BE.1030903@parallels.com> Date: Thu, 27 Sep 2012 18:33:34 +0400 From: Glauber Costa MIME-Version: 1.0 Subject: Re: CK1 [04/13] slab: Use the new create_boot_cache function to simplify bootstrap References: <20120926200005.911809821@linux.com> <0000013a043aca11-926da326-bd96-42b0-8d69-92ce9833912b-000000@email.amazonses.com> <5064538E.7060107@parallels.com> <0000013a0824765e-b3d9f805-f090-45fd-9cca-e6ade916b14d-000000@email.amazonses.com> In-Reply-To: <0000013a0824765e-b3d9f805-f090-45fd-9cca-e6ade916b14d-000000@email.amazonses.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Christoph Lameter Cc: Pekka Enberg , Joonsoo Kim , linux-mm@kvack.org, David Rientjes On 09/27/2012 06:32 PM, Christoph Lameter wrote: > On Thu, 27 Sep 2012, Glauber Costa wrote: > >> On 09/27/2012 12:18 AM, Christoph Lameter wrote: >>> - node = numa_mem_id(); >>> - >>> /* 1) create the kmem_cache */ >>> - INIT_LIST_HEAD(&slab_caches); >>> - list_add(&kmem_cache->list, &slab_caches); >>> - kmem_cache->colour_off = cache_line_size(); >>> - kmem_cache->array[smp_processor_id()] = &initarray_cache.cache; >>> >>> /* >> Don't you have to initialize this list head somewhere ? >> You are deleting this code, but not putting it back anywhere. > > Thought the declaration would do the initialization in mm/slab_common.c: > > enum slab_state slab_state; > LIST_HEAD(slab_caches); > DEFINE_MUTEX(slab_mutex); > struct kmem_cache *kmem_cache; > Fair enough. Because you were removing this in this patch, I was expecting it to go somewhere in this patch as well. But we were actually initializing this twice, in which case the current code seems fine. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org