From: Glauber Costa <glommer@parallels.com>
To: David Rientjes <rientjes@google.com>
Cc: Christoph Lameter <cl@linux.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Michal Hocko <mhocko@suse.cz>,
Pekka Enberg <penberg@cs.helsinki.fi>
Subject: Re: [PATCH] slab: Ignore internal flags in cache creation
Date: Thu, 27 Sep 2012 10:59:24 +0400 [thread overview]
Message-ID: <5063F94C.4090600@parallels.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1209261813300.7072@chino.kir.corp.google.com>
On 09/27/2012 05:16 AM, David Rientjes wrote:
> On Wed, 26 Sep 2012, Glauber Costa wrote:
>
>> So the problem I am facing here is that when I am creating caches from
>> memcg, I would very much like to reuse their flags fields. They are
>> stored in the cache itself, so this is not a problem. But slab also
>> stores that flag, leading to the precise BUG_ON() on CREATE_MASK that
>> you quoted.
>>
>> In this context, passing this flag becomes completely valid, I just need
>> that to be explicitly masked out.
>>
>> What is your suggestion to handle this ?
>>
>
> I would suggest cachep->flags being used solely for the flags passed to
> kmem_cache_create() and seperating out all "internal flags" based on the
> individual slab allocator's implementation into a different field. There
> should be no problem with moving CFLGS_OFF_SLAB elsewhere, in fact, I just
> removed a "dflags" field from mm/slab.c's kmem_cache that turned out never
> to be used. You could simply reintroduce a new "internal_flags" field and
> use it at your discretion.
>
I can do it with you both agree with the approach.
But I still don't see the big reason for your objection. If other
allocator start using those bits, they would not be passed to
kmem_cache_alloc anyway, right? So what would be the big problem in
masking them out before it?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-09-27 7:02 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-25 11:17 Glauber Costa
2012-09-25 16:26 ` Christoph Lameter
2012-09-26 0:46 ` David Rientjes
2012-09-26 8:43 ` Glauber Costa
2012-09-27 1:16 ` David Rientjes
2012-09-27 6:59 ` Glauber Costa [this message]
2012-09-27 22:56 ` David Rientjes
2012-09-28 7:46 ` Glauber Costa
2012-09-28 20:25 ` David Rientjes
2012-09-28 14:12 ` Christoph Lameter
2012-09-28 20:39 ` David Rientjes
2012-09-28 21:20 ` Christoph Lameter
2012-09-28 23:11 ` David Rientjes
2012-10-01 17:54 ` Christoph Lameter
2012-10-01 7:28 ` Pekka Enberg
2012-10-01 7:58 ` Glauber Costa
2012-09-27 13:54 ` Christoph Lameter
2012-09-27 22:50 ` David Rientjes
2012-09-28 14:04 ` Christoph Lameter
2012-09-28 20:36 ` David Rientjes
2012-09-26 14:57 ` Christoph Lameter
2012-09-27 1:12 ` David Rientjes
2012-09-27 13:57 ` Christoph Lameter
2012-09-27 22:52 ` David Rientjes
2012-09-28 14:10 ` Christoph Lameter
2012-09-28 20:30 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5063F94C.4090600@parallels.com \
--to=glommer@parallels.com \
--cc=cl@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=penberg@cs.helsinki.fi \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox