From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A17E5C433EF for ; Tue, 21 Jun 2022 07:44:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4235A6B0072; Tue, 21 Jun 2022 03:44:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3D2F16B007B; Tue, 21 Jun 2022 03:44:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 29B0C8E0002; Tue, 21 Jun 2022 03:44:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1A82B6B0072 for ; Tue, 21 Jun 2022 03:44:58 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id DF53F33763 for ; Tue, 21 Jun 2022 07:44:57 +0000 (UTC) X-FDA: 79601456634.06.5AFC517 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 7DB8B180094 for ; Tue, 21 Jun 2022 07:44:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655797497; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1qyHl9dKG9kw9i0XSv42hyK6a8twaYRBy8w7/SfguIo=; b=bAgD7KF+uA6jW2OFGEuPoXWIKWvzHhmVyLUFUiXOX01PzuJd83m4LcDLd54/EliRZw4T43 vs3PzfgtCOjBPcFVGmuvLtL5vlxJwUfbwAfgISVIQJU9usxHx7uxDZS+j2To69ClE2Jl3S VkNbLp7tXlLrN2PAwt9upgpl+V+oETg= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-620-iP9YCuE5OqGZ9RFJ_FbD4g-1; Tue, 21 Jun 2022 03:44:50 -0400 X-MC-Unique: iP9YCuE5OqGZ9RFJ_FbD4g-1 Received: by mail-wm1-f72.google.com with SMTP id l17-20020a05600c4f1100b0039c860db521so6014945wmq.5 for ; Tue, 21 Jun 2022 00:44:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=1qyHl9dKG9kw9i0XSv42hyK6a8twaYRBy8w7/SfguIo=; b=EtFZvLo1AZXAEocLBgdTiU0fiYnbkaAok5wbsW2S1kr5NIi28JcNGjTGlHUsH2Iu2f ezrgbeei+xdUZC7b1EldYcchYoQ1SwLwi39zqKdfNDJb/wJhTT1lZbr8v1O+KlU1N+PD HWndFXPF5EQH8URH+xl8whYB1ZLmiVGlt0FdPIBO/cSjsHzDRfE8oAdcrDijhsGSoQU9 2iMsgjUcXLpFU6d2AMLbrCcxxfe1F4xKuIAALH1YHfqz/uIT5UC90KY3eLNKBQZ1s2sM yd3314o4FslufHnPsrJFYXgL3wXotRh1Gmo8rnIvEzzUIWplLCayCiEOHe1ebTCjAUdZ qQuA== X-Gm-Message-State: AOAM533un7S6ZRFGKaSLxlOWYopzUDvKg3HdLmAu7bTute7sBSVmD93w tWxlKVfe+J5fIYappDw2q3pzbDOIq7PM1GYMyC9pa9kERW1u9tZG0WWvZ84O+CIZ4kZX3zkdGcV vaRVG+kVyz+U= X-Received: by 2002:a05:600c:2948:b0:39c:6480:f0a9 with SMTP id n8-20020a05600c294800b0039c6480f0a9mr39453635wmd.173.1655797489183; Tue, 21 Jun 2022 00:44:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxvaJMw/HEUBaTx1P16vU3HCLg7qkgcOwhSNvfmheubp6OWfqrNYq2d+gHVU/IWcxc8/SU8jw== X-Received: by 2002:a05:600c:2948:b0:39c:6480:f0a9 with SMTP id n8-20020a05600c294800b0039c6480f0a9mr39453611wmd.173.1655797488899; Tue, 21 Jun 2022 00:44:48 -0700 (PDT) Received: from ?IPV6:2003:d8:2f04:2500:cdb0:9b78:d423:43f? (p200300d82f042500cdb09b78d423043f.dip0.t-ipconnect.de. [2003:d8:2f04:2500:cdb0:9b78:d423:43f]) by smtp.gmail.com with ESMTPSA id j19-20020a05600c1c1300b0039c5645c60fsm29860626wms.3.2022.06.21.00.44.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Jun 2022 00:44:48 -0700 (PDT) Message-ID: <506203e3-1de0-1187-5234-7afc66d4ddfe@redhat.com> Date: Tue, 21 Jun 2022 09:44:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v2 1/2] mm/page_alloc: Do not calculate node's total pages and memmap pages when empty To: Oscar Salvador , Andrew Morton Cc: Michal Hocko , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220621041717.6355-1-osalvador@suse.de> <20220621041717.6355-2-osalvador@suse.de> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220621041717.6355-2-osalvador@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655797497; a=rsa-sha256; cv=none; b=0zvqkYiJDI4HcezUL31fKG6dPP2pl5d/qKbvXMGoOa0Yi4vwsV2K/SLIQG77uYWHjjGPJ/ oQdDMAzmv+xOnybTapRJnDThA9vCGDilqF1MJx04zOfD2Sni7kXmwRmIYhwVxXzdZo6/51 m8BPfPCVvAGQcxBR+pt10agBobr0jzM= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bAgD7KF+; spf=none (imf24.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655797497; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1qyHl9dKG9kw9i0XSv42hyK6a8twaYRBy8w7/SfguIo=; b=g0UYmWk2naQv6780Ol0Dbf+4kDtWZ533WcNyl3yR1beBnS8akpkUAdW7rHGocCnSKLQr3D 9R/fYweinlWvulj28rBOaZ9SIazsqH9dTfS3pB1351kSOTuVNt/kVlm0blbF6/iAq4QMTL +Vn7GFHo4Ts6fFoZQZkeXiyD8JUHTek= X-Stat-Signature: 6qejbutqcydd7sdmjagih888yjzpadf3 X-Rspamd-Queue-Id: 7DB8B180094 Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bAgD7KF+; spf=none (imf24.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam07 X-Rspam-User: X-HE-Tag: 1655797497-394126 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 21.06.22 06:17, Oscar Salvador wrote: > free_area_init_node() calls calculate_node_totalpages() and > free_area_init_core(). The former to get node's {spanned,present}_pages, > and the latter to calculate, among other things, how many pages per zone > we spent on memmap_pages, which is used to substract zone's free pages. > > On memoryless-nodes, it is pointless to perform such a bunch of work, so > make sure we skip the calculations when having a node or empty zone. > > Signed-off-by: Oscar Salvador > --- > mm/page_alloc.c | 16 ++++++++++++---- > 1 file changed, 12 insertions(+), 4 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index e008a3df0485..2b9b2422ba32 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -7361,6 +7361,10 @@ static void __init calculate_node_totalpages(struct pglist_data *pgdat, > unsigned long realtotalpages = 0, totalpages = 0; > enum zone_type i; > > + /* Skip calculation for memoryless nodes */ > + if (pgdat_is_empty(pgdat)) > + goto no_pages; > + > for (i = 0; i < MAX_NR_ZONES; i++) { > struct zone *zone = pgdat->node_zones + i; > unsigned long zone_start_pfn, zone_end_pfn; > @@ -7393,6 +7397,7 @@ static void __init calculate_node_totalpages(struct pglist_data *pgdat, > realtotalpages += real_size; > } > > +no_pages: > pgdat->node_spanned_pages = totalpages; > pgdat->node_present_pages = realtotalpages; > pr_debug("On node %d totalpages: %lu\n", pgdat->node_id, realtotalpages); > @@ -7610,6 +7615,12 @@ static void __init free_area_init_core(struct pglist_data *pgdat) > size = zone->spanned_pages; > freesize = zone->present_pages; > > + /* No pages? Nothing to calculate then. */ > + if (!size) { > + zone_init_internals(zone, j, nid, 0); > + continue; > + } > + > /* > * Adjust freesize so that it accounts for how much memory > * is used by this zone for memmap. This affects the watermark > @@ -7647,9 +7658,6 @@ static void __init free_area_init_core(struct pglist_data *pgdat) > */ > zone_init_internals(zone, j, nid, freesize); > > - if (!size) > - continue; > - > set_pageblock_order(); > setup_usemap(zone); > init_currently_empty_zone(zone, zone->zone_start_pfn, size); > @@ -7730,7 +7738,7 @@ static void __init free_area_init_node(int nid) > pgdat->node_start_pfn = start_pfn; > pgdat->per_cpu_nodestats = NULL; > > - if (start_pfn != end_pfn) { > + if (!pgdat_is_empty(pgdat)) { > pr_info("Initmem setup node %d [mem %#018Lx-%#018Lx]\n", nid, > (u64)start_pfn << PAGE_SHIFT, > end_pfn ? ((u64)end_pfn << PAGE_SHIFT) - 1 : 0); It's worth noting that the check in pgdat_is_empty() is slightly different. I *think* it doesn't matter in practice, yet I wonder if we should simply fixup (currently unused) pgdat_is_empty(). Anyhow Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb