From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx151.postini.com [74.125.245.151]) by kanga.kvack.org (Postfix) with SMTP id BF7076B002B for ; Mon, 24 Sep 2012 04:15:56 -0400 (EDT) Message-ID: <506015E7.8030900@parallels.com> Date: Mon, 24 Sep 2012 12:12:23 +0400 From: Glauber Costa MIME-Version: 1.0 Subject: Re: [PATCH v3 05/16] consider a memcg parameter in kmem_create_cache References: <1347977530-29755-1-git-send-email-glommer@parallels.com> <1347977530-29755-6-git-send-email-glommer@parallels.com> <20120921181458.GG7264@google.com> In-Reply-To: <20120921181458.GG7264@google.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Tejun Heo Cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, kamezawa.hiroyu@jp.fujitsu.com, devel@openvz.org, linux-mm@kvack.org, Suleiman Souhlal , Frederic Weisbecker , Mel Gorman , David Rientjes , Christoph Lameter , Pekka Enberg , Michal Hocko , Johannes Weiner On 09/21/2012 10:14 PM, Tejun Heo wrote: > Hello, Glauber. > > On Tue, Sep 18, 2012 at 06:11:59PM +0400, Glauber Costa wrote: >> +void memcg_register_cache(struct mem_cgroup *memcg, struct kmem_cache *cachep) >> +{ >> + int id = -1; >> + >> + if (!memcg) >> + id = ida_simple_get(&cache_types, 0, MAX_KMEM_CACHE_TYPES, >> + GFP_KERNEL); >> + cachep->memcg_params.id = id; >> +} > > I'm a bit confused. Why is id allocated only when memcg is NULL? > I think you figured that out already from your answer in another patch, right? But I'll add a comment here since it seems to be a a natural search point for people, explaining the mechanism. > Also, how would the per-memcg slab/slubs appear in slabinfo? If they > appear separately it might be better to give them readable cgroup > names. > The new caches will appear under /proc/slabinfo with the rest, with a string appended that identifies the group. > Thanks. > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org