From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97C9BCD5BA6 for ; Thu, 5 Sep 2024 10:22:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 313B36B00DF; Thu, 5 Sep 2024 06:22:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2C0378D0001; Thu, 5 Sep 2024 06:22:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1139D8D0009; Thu, 5 Sep 2024 06:22:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E3C4D8D0001 for ; Thu, 5 Sep 2024 06:22:47 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7FA49140B27 for ; Thu, 5 Sep 2024 10:22:47 +0000 (UTC) X-FDA: 82530295974.08.D976877 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 42AC0C0012 for ; Thu, 5 Sep 2024 10:22:45 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Gff4IPtd; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725531668; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wBauPtDcaZ6X23tUbMEqQdp+l+QLT20d6gNsUmMM1J4=; b=Oo2zw96iQuEoligrcDdxNqpUBPM1fkepGPZ3xhjkGv8VqM+2vCDQq+XZ4qkFWS50h0K1uS Fu0MqlDHeawtdtweby+/mhvWOWvzQpH6A9BLiM23IxQPOo64dZbyCi0aJftmzXbnk5SRBw Z3syY9qUpkZha2CkGQrlQRtnZEcKTGo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725531668; a=rsa-sha256; cv=none; b=ytdenWRjdw02hqASpBVDEfkojAUVBr7IEECX4+gKGshczKf+UNf7yPpHdCBC88kvqwqPTq 6qboov0PLRwM3h9/wOUsCOFCrS1sPAOIH/TbvNK5ABW2elX4CqjVbqliiB7Pm8FRp3qwFm ilxQwdG4db3+oEFvmwe8+IkoS078WFk= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Gff4IPtd; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725531764; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=wBauPtDcaZ6X23tUbMEqQdp+l+QLT20d6gNsUmMM1J4=; b=Gff4IPtdA72e5RKqeud7u6EBrgcQx+ePgXUYhs3l95A6PC3ItLIgO5COXhGoBtf/n/7x1W ptTwQtB6dIqtvYzNwjo046SQ3Y0bGSk0KvFYFnjLSzq3JxLPKjf4ChMx8LALPHQQ1eFg0J np7jlQdNn0n6vb4dtgqnyU6O1oSHRho= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-656-j6kakJd9Mrugo-3b_ze1WA-1; Thu, 05 Sep 2024 06:22:41 -0400 X-MC-Unique: j6kakJd9Mrugo-3b_ze1WA-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-374c960ee7aso483544f8f.3 for ; Thu, 05 Sep 2024 03:22:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725531760; x=1726136560; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wBauPtDcaZ6X23tUbMEqQdp+l+QLT20d6gNsUmMM1J4=; b=Cquc0p3yWEtakTkwcOQS+YGAZq5vLoWn72MjYs7AdarZsutBwnsNRk47lPh58RfNps VqYuVTsnylA1GrhCJjMbePjryjCibIKbm0aOBHPfEaaMA0oJaDDoAzcRUW2kvewgkwY6 7mB/a/bFbft/t+RpaAS2XsE/FXLF3f43/sB/oQ9KaEWlx6GkxfpVxz8Xhz0aIDcrY8JD +wdUaqNdecnrnQ5gg7PSygvQp7aRMjWR+Uq0uAAy4mraTMDhjyemZd9ELzaYIbOb1SsH +K7df68D3PgOySHu5E1qNs9HwHGaH1Q1Has0lhG+/FLirpCPDBiCI3BznTKYWEA5Q73i 25+g== X-Gm-Message-State: AOJu0Yyk9nLgl6BHJwX8oR7gQdZMpVJjdPx5nldHeGFMHsS5qihuPzng m7cMd5y9sipW9NPwRcHNpyp7xDZGSYqUHkG0bD+ZZ2iqqQSrGMVBHUsQF3tUJMpRmtIOzHW8j2q WVgO1RdBcY5ocXd3DB+kjzUznAyA0yg0piFSK1q2PaBCE012DQHD4kftDheQ= X-Received: by 2002:a05:600c:1c12:b0:426:6f87:65fc with SMTP id 5b1f17b1804b1-42c9a36c5c6mr16332055e9.17.1725531760225; Thu, 05 Sep 2024 03:22:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGUHbHDBvHnJH9EC8AJcVxvoiifAHF4EhGB5UHIad66+ayxQ/spxG7PtAt2DbvQSbHV7NoujQ== X-Received: by 2002:a05:600c:1c12:b0:426:6f87:65fc with SMTP id 5b1f17b1804b1-42c9a36c5c6mr16331565e9.17.1725531759047; Thu, 05 Sep 2024 03:22:39 -0700 (PDT) Received: from ?IPV6:2003:cb:c708:5400:6c12:d0e2:3757:2963? (p200300cbc70854006c12d0e237572963.dip0.t-ipconnect.de. [2003:cb:c708:5400:6c12:d0e2:3757:2963]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-374ccab8a76sm9628797f8f.99.2024.09.05.03.22.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Sep 2024 03:22:38 -0700 (PDT) Message-ID: <50595531-87b0-4420-9624-948810066a6e@redhat.com> Date: Thu, 5 Sep 2024 12:22:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: move bad zone checking before getting it To: Wang Yibo , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, trivial@kernel.org, Wang Yibo References: <20240905095216.7888-1-wangyibo@uniontech.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240905095216.7888-1-wangyibo@uniontech.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 42AC0C0012 X-Stat-Signature: cs8rrashyj153ndcfipkdzogqoe64d6y X-HE-Tag: 1725531765-549311 X-HE-Meta: U2FsdGVkX19/w7kzCmNW0RRCUz/Wdm0/XCMfnxMpgyAx1ahVsUh/PVuYIgbih0jxdTdMm/NmXeq2FwZO0in8XxnmYpWmPkreLzXwU/SSZxLukNibd8yTPYq+qOKZ2aKByeeYGlmdtfQpS0njhO9QXw0VV/o7VUFv9KUAxJ9uIf3JaMUqX3PkvuQwbIiq8rnMqP8d6vIDHxmRWSjRdcvAINRy1QBSYsv8yDon7zieiYZrUJ+HSzpd3IIIUxq79iopPI9vJZTx8to3Owb+oUAZshbpV4Qz8woglSQbCat7nHdVNn6Sk6EItmL6jZQlyt+JfGFxudZ6slodgEV1HJXb0zsXiDUWGh7Kw3v9n3iZka/DshGMcPg7D5LSuWIpQJY0rYR8F5fXMfRMIsaCVGlkrt8U8g0plIEdQsFopWhDpDxuPuBdeIgDwiRNyMlwbYoaPDqJQGO+IfW/2K6kUGdhTpbOhdA2nRRS+jDy+lYsKNwYzLtaxviYCgr7TeTxn6MRK/rO4EEj0BFXON0+boEsaQC7mO/Zk+XrH2AN4gBA8ofEzOKiND/v0i6IwlGnDzqwOZYtGe5DdG7D0YfJ1wZmzqIOebCXrfmap9uRic3QbDh2GeLcJA0x9BpQSadSnRo+8dFdj4PWO8YWMsc9THhA7ETMA5XVU0MjIa+Lliy0diUKgqN5f/csuWQOG8Z3Ggp7gnqv34F1NAJO4q6xhXqRIX+uf0fwqtwg1obCJrII4Y/P3+mIpS9VnQCeUk5DuJX5ALI44w2pXtIsYB5iR+KDpAihTSYJOf3J5m+UCL9MGrMnY7xglvqCg/pBxsd6SvpQvicUdm0Xnuj12WYfbXmqFEoG5bI3Oi1ImRVQQgnUBIuJ2G3RubWXniRS4M6lxsHt+QAQ2atajJ/vpBXCWYAc42xYC6MULviTQ0NbODsUUs5LUUSHQKLhNV4fS0pZZ2AO9qkMkHTg9F4Cntuuw5E UmaTgJ16 EOhfEN4/ppbVLyrYEVGgQuccS03OnAF6sKEMmUeFSGM0UDg6sN+r6dh318FsNHN2QR36F+bNEnd3qqI5Ii8WqU213eHzgImCaO/TndomA0eiiB39WNnnlBgcRXfdCZks/ovga1be7tEE0gAPqEOj0k1BaLdlkYy3PbJNiCGDhWVGU3FyHctRyVrhk8Lzk45WLbsAoInteaSNDjqBn9NlNqslHCjO19/RMTaP1+iPJ8AAPRhLsjGuyaVo4GxXT384qECPni2dbxUfnfAy6KLHZGIsccqjPAzNFlIfKFAJtDITZABL+ZGZ3Wcw9lwcKzt3+h2AF2coGlrJeJqLXUCo49PUnA+5GAiSWWLfoWwXyFp65cxIQtyVVTPJymWIl8oNJ3SjiC1GYfCmgrSfyH1SaZEmyUwUuomP0rmu/5gYEqBtLqErpN3biERBk3JcU4COA6V/S+ZbudwbKUaU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05.09.24 11:52, Wang Yibo wrote: > When flags from gfp_zone() has an error combination, VM_BUG_ON() should firt know it before use it. s/firt/first/ Please break long lines. (checkpatch.pl should have warned you) > > Signed-off-by: Wang Yibo > --- > include/linux/gfp.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/linux/gfp.h b/include/linux/gfp.h > index f53f76e0b17e..ca61b2440ab3 100644 > --- a/include/linux/gfp.h > +++ b/include/linux/gfp.h > @@ -133,10 +133,11 @@ static inline enum zone_type gfp_zone(gfp_t flags) > { > enum zone_type z; > int bit = (__force int) (flags & GFP_ZONEMASK); > + VM_BUG_ON((GFP_ZONE_BAD >> bit) & 1); Better use VM_WARN_ON_ONCE() instead while at it. > > z = (GFP_ZONE_TABLE >> (bit * GFP_ZONES_SHIFT)) & > ((1 << GFP_ZONES_SHIFT) - 1); > - VM_BUG_ON((GFP_ZONE_BAD >> bit) & 1); > + Unrelated whitespace change. > return z; > } > But I don't see why we would want this change? It's not like the kernel would crash when calculating z. Or is there some change in behavior I am missing? -- Cheers, David / dhildenb