From: Glauber Costa <glommer@parallels.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, Sachin Kamat <sachin.kamat@linaro.org>
Subject: Re: [PATCH v2] memcg: clean up networking headers file inclusion
Date: Fri, 14 Sep 2012 15:35:50 +0400 [thread overview]
Message-ID: <50531696.1080708@parallels.com> (raw)
In-Reply-To: <20120914113400.GI28039@dhcp22.suse.cz>
On 09/14/2012 03:34 PM, Michal Hocko wrote:
> On Fri 14-09-12 15:21:29, Glauber Costa wrote:
>> On 09/14/2012 03:21 PM, Michal Hocko wrote:
>>> Hi,
>>> so I did some more changes to ifdefery of sock kmem part. The patch is
>>> below.
>>> Glauber please have a look at it. I do not think any of the
>>> functionality wrapped inside CONFIG_MEMCG_KMEM without CONFIG_INET is
>>> reusable for generic CONFIG_MEMCG_KMEM, right?
>> Almost right.
>>
>>
>>
>>> }
>>>
>>> /* Writing them here to avoid exposing memcg's inner layout */
>>> -#ifdef CONFIG_MEMCG_KMEM
>>> -#include <net/sock.h>
>>> -#include <net/ip.h>
>>> +#if defined(CONFIG_INET) && defined(CONFIG_MEMCG_KMEM)
>>>
>>> static bool mem_cgroup_is_root(struct mem_cgroup *memcg);
>>
>> This one is. ^^^^
>
> But this is just a forward declaration. And btw. it makes my compiler
> complain about:
> mm/memcontrol.c:421: warning: ‘mem_cgroup_is_root’ declared inline after being called
> mm/memcontrol.c:421: warning: previous declaration of ‘mem_cgroup_is_root’ was here
>
> But I didn't care much yet. It is probaly that my compiler is too old to
> be clever about this.
>
Weird, this code is in tree for a long time.
So, *right now* this code is used only for inet code, so I won't oppose
your patch on this basis. I'll reuse it for kmem, but I am happy to just
rebase it.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-09-14 11:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-14 11:21 Michal Hocko
2012-09-14 11:21 ` Glauber Costa
2012-09-14 11:34 ` Michal Hocko
2012-09-14 11:35 ` Glauber Costa [this message]
2012-09-14 12:01 ` Michal Hocko
2012-09-14 8:05 ` Glauber Costa
2012-09-14 12:13 ` Michal Hocko
2012-09-14 12:08 ` [PATCH v3] " Michal Hocko
2012-09-14 8:14 ` Glauber Costa
2012-09-14 12:24 ` Michal Hocko
2012-09-14 12:41 ` Fengguang Wu
2012-09-14 12:54 ` Michal Hocko
2012-09-14 12:18 ` [PATCH] " Michal Hocko
2012-09-14 19:45 ` [PATCH v3] " Andrew Morton
2012-09-17 12:02 ` [PATCH v4] memcg: cleanup kmem tcp ifdefs Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50531696.1080708@parallels.com \
--to=glommer@parallels.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox