From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28088C282C1 for ; Fri, 28 Feb 2025 14:17:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 993C9280004; Fri, 28 Feb 2025 09:17:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 942FD6B0088; Fri, 28 Feb 2025 09:17:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 79551280004; Fri, 28 Feb 2025 09:17:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 493516B0085 for ; Fri, 28 Feb 2025 09:17:17 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 988F64FDF5 for ; Fri, 28 Feb 2025 14:17:16 +0000 (UTC) X-FDA: 83169555672.04.BE75E59 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf26.hostedemail.com (Postfix) with ESMTP id 03FBE140008 for ; Fri, 28 Feb 2025 14:17:13 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=LYAKBT+g; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="4GvZ/zPh"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=LYAKBT+g; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="4GvZ/zPh"; spf=pass (imf26.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740752234; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hIseiRro5ZDlr43rKJfqqqfDFAsRrvZFt1JC6oL9YnE=; b=zOV+X9cQZrpjOzC6yJJHhdtnsS9u8CH9lZSpSgL6pK8qgV5LGmIx967One77aQY3PCKJUK pJ1qZzKAnyjMEeRmuDiKCwgKHnjzP3QRxzXZm9VqCH4g/WwwBsQ+1wVjaz+n42U2r7Ld3G 0xy/hLo/Ga3gbDBI4Na89MMZl934iGg= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=LYAKBT+g; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="4GvZ/zPh"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=LYAKBT+g; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="4GvZ/zPh"; spf=pass (imf26.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740752234; a=rsa-sha256; cv=none; b=mcBumg8n7QYO/P0CFLc6E7GdGrx8D5r4g4ycqr+vEYG7J9HKNXcGS7yz9aH1Zp8uaSXXY7 PO0vhUqNEHwLmwMIAIcCHTNj5dujVh4YNrPdr+WTzQAy85KtknFlE7jDYAmC+IL+tm465o aT4l3Zp6K73QW8KxE472wPamwWyL2vk= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id BD1A21F37E; Fri, 28 Feb 2025 14:17:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1740752231; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=hIseiRro5ZDlr43rKJfqqqfDFAsRrvZFt1JC6oL9YnE=; b=LYAKBT+gywT+qOSiQz8ecqjdOm74+q98gaYP+YDKnR/F87TfZ49MUFJCNNaCOcWKbmgQLS WT4Is2KV6rpun1S5H7p1LknkSJMhoBqEGr1nrDGqP/ECkfZ7DWHQ1sXauPaq50BhqIO5Us BRaoMBbN8QL0GNoficVjRfl/n42qetI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1740752231; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=hIseiRro5ZDlr43rKJfqqqfDFAsRrvZFt1JC6oL9YnE=; b=4GvZ/zPhVrNKc8AKw7Z3I51uT11w12XQImbuBKgAD8dbx0C4zOwPocieku2c1mKwRj+N2H 3nfHK40ttQG74GAw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1740752231; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=hIseiRro5ZDlr43rKJfqqqfDFAsRrvZFt1JC6oL9YnE=; b=LYAKBT+gywT+qOSiQz8ecqjdOm74+q98gaYP+YDKnR/F87TfZ49MUFJCNNaCOcWKbmgQLS WT4Is2KV6rpun1S5H7p1LknkSJMhoBqEGr1nrDGqP/ECkfZ7DWHQ1sXauPaq50BhqIO5Us BRaoMBbN8QL0GNoficVjRfl/n42qetI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1740752231; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=hIseiRro5ZDlr43rKJfqqqfDFAsRrvZFt1JC6oL9YnE=; b=4GvZ/zPhVrNKc8AKw7Z3I51uT11w12XQImbuBKgAD8dbx0C4zOwPocieku2c1mKwRj+N2H 3nfHK40ttQG74GAw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8E45C137AC; Fri, 28 Feb 2025 14:17:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id AtGOIGfFwWerMQAAD6G6ig (envelope-from ); Fri, 28 Feb 2025 14:17:11 +0000 Message-ID: <503c4ba7-c667-444a-b396-e85c46469f0a@suse.cz> Date: Fri, 28 Feb 2025 15:17:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 1/5] mm/filemap: add mempolicy support to the filemap layer Content-Language: en-US To: Shivank Garg , akpm@linux-foundation.org, willy@infradead.org, pbonzini@redhat.com Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-coco@lists.linux.dev, chao.gao@intel.com, seanjc@google.com, ackerleytng@google.com, david@redhat.com, bharata@amd.com, nikunj@amd.com, michael.day@amd.com, Neeraj.Upadhyay@amd.com, thomas.lendacky@amd.com, michael.roth@amd.com, tabba@google.com References: <20250226082549.6034-1-shivankg@amd.com> <20250226082549.6034-2-shivankg@amd.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20250226082549.6034-2-shivankg@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Stat-Signature: 8i941on4ci3gug9jbrt5ofzhiwm97kg1 X-Rspamd-Queue-Id: 03FBE140008 X-Rspamd-Server: rspam06 X-Rspam-User: X-HE-Tag: 1740752233-296601 X-HE-Meta: U2FsdGVkX18HeybEug+63Nd1dvHefjlg91C91nN1JnoWYpgY4Q7uD9WRzv/GlWyPmgDsdGVjt5Or5V9zsA8ptxcJPq2CSBwFDYVpHArCwEN17NuOqyVn+YBdxyQRldxmWMklHwk8k6IaTCeNBACodyDOxgEfqL2e2c1tVWsp4dAKOhHOF31XC2N5PKRgEl/+Uk3k5rFqyWdvej7yVvQ3ugZCiVLiFwWsSmDvke1PGUHlhYa88MazqmlV1ykaR7JaABCGuP6WOOw47dp+quO6Wal7Jo70uerzM2o4H7SxMHI4XUmkfCW6yf1yUMdLJmdZZAsm7J+JW9iO+TNEFJgXAvMlAC4//WiR8Cj6qIEBMpqOw8MxPAAOLqsYxUbaCp7LdnEuWtWVj3fyh+7LzD3iDaaZ1mX1IwWzpwUFtCDAy5yq+wDRqaHgAV1TwqbcsYimiI5hPwKA06jnFciIvnAdar6CX+Er2k8GEZ87exuh7bzJDAJghTvGnq9kxE+eSMXK4O0jRWUJupL9XKxIqm4XuuIV4gfXPgxlByprueGKc8iiYrgm2X7JM5UGOWEQ3neayZMw/oL9lzl/7SoPlkkl4mGzTZ4amshR7BJTUej2iwljWBoCPnXEQ23r2UXPXO4buBWuutmVIvVabdtef+nXoP9SjeRwAGoP2MEAmyx+SQEpugu8vC1pylsBId648TbdcSQP2pGyozyWO+HLOxIJ8f+7gEk/XE/A0Gw58/QkNyMRUQsAk3oGx9kfrjxBmL5PQVrE4viWBZ/2eLB4xQdsgFw3RKPz2x7WcWSD/twDSpSacUp25IeF72AeVMKEyZ/vqEFEKLeMyTCtnE/qCBnQQQAsVCJG/uiUKOd4LTuz2B6p5vXhggb9AG69de0MZKGw+Dx12P/PR0b2LLe2SWGeZtLTpezZQjjvK5iOrQ+vsENFvComHfeZhzMDQ9DAHEffQrS4S413iBuyWTtd3Mo Pb0/L1Fb 8QrrPQm5+NEtb9VRVuejaEz/h69Pqb7kg/1QT8h2W8lFV5K/rtvHbmH2GW04n/usk6bajBVfB+evCs8cZSU6AWJPSF2ys5PJQhHRd0updU+f5hDWM6+oojhTTOVsHYVlKeklqcHgCMnPd2dFY8b0daQczIO0Vz4SmB8Un19BNYjZqTN7GG7Zu+yv0yRYFSqQIFhquPkvdvy4ttqMBYcGrhUT0TJv2ZuARBgmq2eQHBuvvHQlzeZMZqQKB9BZjC5KZRqzY7gfMtZgsHjFDZiNPzqnsqjZc9nRjWdhHBMsnF7YdeiNder8lQCK+/g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/26/25 09:25, Shivank Garg wrote: > From: Shivansh Dhiman > > Add NUMA mempolicy support to the filemap allocation path by introducing > new APIs that take a mempolicy argument: > - filemap_grab_folio_mpol() > - filemap_alloc_folio_mpol() > - __filemap_get_folio_mpol() > > These APIs allow callers to specify a NUMA policy during page cache > allocations, enabling fine-grained control over memory placement. This is > particularly needed by KVM when using guest-memfd memory backends, where > the guest memory needs to be allocated according to the NUMA policy > specified by VMM. > > The existing non-mempolicy APIs remain unchanged and continue to use the > default allocation behavior. > > Signed-off-by: Shivansh Dhiman > Signed-off-by: Shivank Garg > --- a/mm/filemap.c > +++ b/mm/filemap.c > @@ -1001,11 +1001,17 @@ int filemap_add_folio(struct address_space *mapping, struct folio *folio, > EXPORT_SYMBOL_GPL(filemap_add_folio); > > #ifdef CONFIG_NUMA > -struct folio *filemap_alloc_folio_noprof(gfp_t gfp, unsigned int order) > +struct folio *filemap_alloc_folio_mpol_noprof(gfp_t gfp, unsigned int order, > + struct mempolicy *mpol) > { > int n; > struct folio *folio; > > + if (mpol) > + return folio_alloc_mpol_noprof(gfp, order, mpol, > + NO_INTERLEAVE_INDEX, > + numa_node_id()); > + > if (cpuset_do_page_mem_spread()) { > unsigned int cpuset_mems_cookie; > do { > @@ -1018,6 +1024,12 @@ struct folio *filemap_alloc_folio_noprof(gfp_t gfp, unsigned int order) > } > return folio_alloc_noprof(gfp, order); > } > +EXPORT_SYMBOL(filemap_alloc_folio_mpol_noprof); > + > +struct folio *filemap_alloc_folio_noprof(gfp_t gfp, unsigned int order) > +{ > + return filemap_alloc_folio_mpol_noprof(gfp, order, NULL); > +} > EXPORT_SYMBOL(filemap_alloc_folio_noprof); > #endif Here it seems to me: - filemap_alloc_folio_noprof() could stay unchanged - filemap_alloc_folio_mpol_noprof() would - call folio_alloc_mpol_noprof() if (mpol) - call filemap_alloc_folio_noprof() otherwise The code would be a bit more clearly structured that way? > @@ -1881,11 +1893,12 @@ void *filemap_get_entry(struct address_space *mapping, pgoff_t index) > } > > /** > - * __filemap_get_folio - Find and get a reference to a folio. > + * __filemap_get_folio_mpol - Find and get a reference to a folio. > * @mapping: The address_space to search. > * @index: The page index. > * @fgp_flags: %FGP flags modify how the folio is returned. > * @gfp: Memory allocation flags to use if %FGP_CREAT is specified. > + * @mpol: The mempolicy to apply when allocating a new folio. > * > * Looks up the page cache entry at @mapping & @index. > * > @@ -1896,8 +1909,8 @@ void *filemap_get_entry(struct address_space *mapping, pgoff_t index) > * > * Return: The found folio or an ERR_PTR() otherwise. > */ > -struct folio *__filemap_get_folio(struct address_space *mapping, pgoff_t index, > - fgf_t fgp_flags, gfp_t gfp) > +struct folio *__filemap_get_folio_mpol(struct address_space *mapping, pgoff_t index, > + fgf_t fgp_flags, gfp_t gfp, struct mempolicy *mpol) > { > struct folio *folio; > > @@ -1967,7 +1980,7 @@ struct folio *__filemap_get_folio(struct address_space *mapping, pgoff_t index, > err = -ENOMEM; > if (order > min_order) > alloc_gfp |= __GFP_NORETRY | __GFP_NOWARN; > - folio = filemap_alloc_folio(alloc_gfp, order); > + folio = filemap_alloc_folio_mpol(alloc_gfp, order, mpol); > if (!folio) > continue; > > @@ -2003,6 +2016,13 @@ struct folio *__filemap_get_folio(struct address_space *mapping, pgoff_t index, > folio_clear_dropbehind(folio); > return folio; > } > +EXPORT_SYMBOL(__filemap_get_folio_mpol); > + > +struct folio *__filemap_get_folio(struct address_space *mapping, pgoff_t index, > + fgf_t fgp_flags, gfp_t gfp) > +{ > + return __filemap_get_folio_mpol(mapping, index, fgp_flags, gfp, NULL); > +} > EXPORT_SYMBOL(__filemap_get_folio); > > static inline struct folio *find_get_entry(struct xa_state *xas, pgoff_t max,